From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3027BCFB441 for ; Mon, 7 Oct 2024 14:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7VpJqPG77cRnKIElit9HVU/ZFAUvGvJjnRRplNr1AFg=; b=NGljEwa7dGbV59a1BN1kNx6yTa SSZWYVMHWciYLQ6IUFlFpO1Q3g4+c7oRjZySoti6HP2VvIFftzk51lOxMS+Z0/H/vNNIRy8lHHh6D ayWmWvE6Te6QAmjahKUSgPeD59Dgav6/+boTQwHaLk0pYRQbbOsIrs5iqIr4UJC3aBv4XgL/x0Xjw KQWLk86BB/NtzSMzXaRk1LQL+n03pnKAjHoGv4A/J9VHMmLk2NeozAEob6x7iR56AbXBa9tQPQ9+c oXl7fKG+r4y256Bvbw8ougcOb1c7lX2JX/5uzpwYI2+VOwRU55YJPJHUrWAg4RnoWaDuIpXtGTCZc aJ1OuXzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxoIM-00000002biF-2NzO; Mon, 07 Oct 2024 14:01:06 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxoH3-00000002bMf-2K89; Mon, 07 Oct 2024 13:59:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C46DBA405B7; Mon, 7 Oct 2024 13:59:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EFC2C4CECC; Mon, 7 Oct 2024 13:59:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728309584; bh=j2KITGRUJh2rGqtoamaW9s2IDnoCKVh9a5TyQQoqQ8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oxo3YbOM3U4jGqobpzw4AzbqBC7mPiB00NqK1EnxGc/OMB9886B7pMMv75qenhW7z d90Zh596aqAa+AohB+60ixcNs1K5ud30z/7fA5u5EGCs81GvFj8nYMVS4fJ6/lE9RN 431MsYszwelYEr+0RNHm5982h9wsPItcGfug5LFNPPqbTWI0ft6YKMO/DEYB7v86ny 37hiRwVNb6NCxrRJs3HW0eHpzICpO9kaGmLN68Vez4IRgX2gExPATx6mQNiAYYqEoV 6QkuIkx7AEvvZLoBhWA8qrwntxS6dWl9/MMhztaWxSnoTey6lVufVFojBUGdTcXaZU goOaz5QCC+TIA== Date: Mon, 7 Oct 2024 14:58:09 +0100 From: Simon Horman To: Lorenzo Bianconi Cc: Felix Fietkau , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net] net: airoha: Update tx cpu dma ring idx at the end of xmit loop Message-ID: <20241007135809.GB32733@kernel.org> References: <20241004-airoha-eth-7581-mapping-fix-v1-1-8e4279ab1812@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241004-airoha-eth-7581-mapping-fix-v1-1-8e4279ab1812@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_065945_673967_5B0961C2 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 03:51:26PM +0200, Lorenzo Bianconi wrote: > Move the tx cpu dma ring index update out of transmit loop of > airoha_dev_xmit routine in order to not start transmitting the packet > before it is fully DMA mapped (e.g. fragmented skbs). > > Fixes: 23020f049327 ("net: airoha: Introduce ethernet support for EN7581 SoC") > Reported-by: Felix Fietkau > Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman