From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97141CFB44F for ; Mon, 7 Oct 2024 17:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ic8at5+otSdzszh8Cqp2pOJxMeWQBAZY6eTCFkXBnAk=; b=OUl7LjdlIyfzNxYcgmICRW838M kCupT9BwotvCfCm/FMzF4KIfIJmk3xuCxcSziMZ2zsaZMByWOs0NRNFF7YEg43DIrQtEbJB+JU8sr CF8KYJEKjPVNiQFSar1QTzj/4fV/610ONTcUqH+QK6rHVtt1WWDPWxU4ZNb25KsdgQsNd/sGu5mAA pOzMZMlpUdv0oNnDRgoXg6fXULJx6Qyp39JR8ST9XRcTXKloiP4GMjgetJNW7ncjqml8RNXLskAnb mFOu2edmL0fVzkQa6c+66l6WbmhXOYVNaFGVABbzE7qEaWPRfh1rSIv1ccUsAIvT4iVacACt4/qxS PR1XcuqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxruj-00000003OQ7-1rGt; Mon, 07 Oct 2024 17:52:57 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxrsQ-00000003O3w-48Vz for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2024 17:50:36 +0000 Received: by mail-qt1-x82d.google.com with SMTP id d75a77b69052e-4581f44b9b4so33240071cf.1 for ; Mon, 07 Oct 2024 10:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1728323433; x=1728928233; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ic8at5+otSdzszh8Cqp2pOJxMeWQBAZY6eTCFkXBnAk=; b=a/7EPjjINhOrab25GPSWYJrDl1oS4G77vS+Gq+wdrPQCenI/oHT2FaXuCslyJC4tbh 4XueTs+lYFgdij3EpntTx+yJlFQ0qZx4SolTr2JP3PvEMFZ4VdKfKpbHHEwfFILDJCNC +pW+BY105vAZn/HBisSFD7oiD5ZbncHLYeINVyNlqUnestcdQZZ4Zhmnm/brwzmBKLoK GSuc5uWvWEqX6tcwn8f+tBAtOJ+Jue3GG1n7FLOvnVOXdsJ58EMbfO+vUel4ot9Il7cD f1X2PS7cvlr5l8JPxLzhmXGvQBYQJ5beSuSwiYyKDhKoTcnQd7uhJ6YWunMhmFWlJnDs I+cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728323433; x=1728928233; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ic8at5+otSdzszh8Cqp2pOJxMeWQBAZY6eTCFkXBnAk=; b=HRLNK/Wl7svpCuq2XBrdTHZqR0P1bzYParuOESi81ABAHnv6N8S8uavcnx8YzMco3n +t6s8fWV+/XJjhaYnp3p29fK+pBUYqj/AXWvF2t7wYxeUlMn6Suy9oodsCNw8pxiZ3NV dRlK2qkW+VVrzciuwyiuwPAXb2KVUKt/rkDzjb1fFqiMPYrYUMQPCl5txSRZj2ulRCnU Gr5S9HUCQQPg5sjzyXXUZaD7ZyZudhrVtAMAAhter9B8ukJrlshdioeRPD3NPG/sjfQ8 2n1D98ratc1PuPVDHvHCDTAcy0c74qerUfiqimjO6a2cFLF1vVvkWzJWDmjIgY6uChXt ErDw== X-Forwarded-Encrypted: i=1; AJvYcCVFmzuWdAoRvzbwPiyCyDi3QqcZiwSbPqIwxgcSJGS3bD6Ij4+VxVNgn03TNrpiZvZo5VTkjRGcQnpCgLrzkc6l@lists.infradead.org X-Gm-Message-State: AOJu0Yyw2/bkA/KVBpPjVwEguRY56DKxd7r3SaC1k4TKMDsF2ygvT2Xb 7Q58lX7HkcnJagOc3zGfPRx1h1VSmNyt27Dq2sd6s9HPOP4cvc1NvC1y3Vd/9RU= X-Google-Smtp-Source: AGHT+IH8DysIajFIpReTEYO72Lftr4AtqQsuMgp01JqOWKWeypQD47i7esStBCXc03ss2SVLA+5wRw== X-Received: by 2002:a05:622a:199e:b0:456:937e:2f76 with SMTP id d75a77b69052e-45d9bb5b3f0mr209203021cf.39.1728323433395; Mon, 07 Oct 2024 10:50:33 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45da7506d6csm28564521cf.37.2024.10.07.10.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 10:50:32 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sxrsO-003MTO-2i; Mon, 07 Oct 2024 14:50:32 -0300 Date: Mon, 7 Oct 2024 14:50:32 -0300 From: Jason Gunthorpe To: Yang Shi Cc: Daniel Mentz , nicolinc@nvidia.com, james.morse@arm.com, will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [v3 PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for 32-bit sid size Message-ID: <20241007175032.GA762027@ziepe.ca> References: <20241004180405.555194-1-yang@os.amperecomputing.com> <87ac9686-cffb-43ac-b8f0-ccd3632fe5cd@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_105035_044486_39FC134C X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2024 at 06:53:25PM -0700, Yang Shi wrote: > Yes, SIZE_MAX is ~(size_t)0, but size_t is unsigned long on ARM64. So the > check actually doesn't do what I expect it should do. U32_MAX should be > used. SIZE_MAX is right: static inline void *dmam_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t gfp) It is up to dmam_alloc_coherent() to not truncate it's arguments, when you pass the u64 bounded to SIZE_MAX you guarentee that size will be a valid value. > > I think it should be capped to STRTAB_MAX_L1_ENTRIES > > I'm not expert on SMMU. Does the linear stream table have the same cap as > 2-level stream table? Is this defined by the hardware spec? If it is not, > why should we pick this value? Well, the way the driver works is in the 2 level mode it caps the whole table to STRTAB_MAX_L1_ENTRIES * STRTAB_NUM_L2_STES total SIDs which is 0x2000000 or 26 bits I guess there is a reasonable argument that linear or 2 level should have the same software enforced max size. Though would put it at a max 2G linear STE which is still larger than Linux can allocate, so it doesn't really make any practical difference compared to SIZE_MAX. Jason