From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 476CECED26B for ; Tue, 8 Oct 2024 05:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0gPPdy2Ftt8jyfONTzvO4gU++dKJ2LnfrBod+GV3jLI=; b=wGwuHdbVy+TRp5MsPr0qo+wOv5 RMhR4NNPJpk0c8V3fmGHjLXGOHbKXp49DG+Z/hJ5d6DT1d1fsln2lhtZPeZQlKoHOFf1RmPvZ4IAu +/tddhxPYUz99r8++PDLNaR7+ipKcythPxnmDeU7nLLEF3SFgagv3Jh6FsjKeOF5vt6r2aFsex5k8 /6PEFTLpGTyIz55DL7xEy6MHxHuDmEwuOJHuVLB6leNBZQPLoAJmW/Oliq36iZFw+6nNAWcewl3bO 4iF+G9bgaNt8ER4cLONz3Tnv2dtz7wdCXBwRTZSRYfhtPnCVpaDDy1PL6lmhl0TFSyHUmXZFVXMRv urGyqmUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy3As-00000004awp-2qTs; Tue, 08 Oct 2024 05:54:22 +0000 Received: from mail-northeuropeazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy38S-00000004aiU-1UEa for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 05:51:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ADVY2A08U7nWN89AB8hShHso+YsvaPhPNd9FtMei17R4JSquEmA/Wtuwjwnh1MBCeYAlqsUzctjeCkffuLof9DcrgPlWSHHn6WO7OIgYvfetH5NqUWGzNT92oXW7uxjLbmKjJsIEEmyKlYhmFuZvedoCQKMy6tBJO+sJsRVogc6DEtasWNd6Smz5exKWYoNkb7uZu97u40QjQxpNEhtCi9lidBb3FOCWgIlp8yTBStS29Ng7OtqjWVDfBQ0NzoAXYGyGQNP+ujDKsTnCl6QIgkFslKJ4bpnMO/1ROqN3Xh+cKie6a3l/ZNADI0LmJqvDySLaXNg2HCGp2gcpn8IY9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gPPdy2Ftt8jyfONTzvO4gU++dKJ2LnfrBod+GV3jLI=; b=JylGluySEVYDHzJS5xDTQLjadQOo50GDbl4jjGa5FrOyW6dtL1XNJnmRF+wWNAmnsqmNPBbPdYNHI5Ufes6vzFtsjmLIKkztWtBT8W7Je/HnXLLcnlW65tvRItK+Y78062lgu1N9wMsC3UPbDwqOTeLr1k8xbh2YUUqdNNqOKk3j9HevzPa7aAG9469+Hv95F1fbMjlTfaTkkYcZn9Z/oJN9QGDxiagYPlKqwkm4awl64t/TBGOZZwZHeP/NzGY78wiqCH2ZXLptOT+993TarvNKpSIWVtXUJRGVAVGHowbftLZLInyR+0pWYAvCOyOeyKnmBpI180KdtmbkCQMPgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gPPdy2Ftt8jyfONTzvO4gU++dKJ2LnfrBod+GV3jLI=; b=lnNBcRk6jCERI3x/1V8ZUyOvSkenFcJFTfMeBg2F2r1GkRsvAsMtwRV3x76E15pfGCmqExCmJN+3vzUpMuGOT88ARiMHKY+vFSaRMw5vfz2EFMqOEYWkmhBBPpgC/i7nUYBV8OZEbUY/pglLUaOW/fkPZMVI/+rlt0io74LCl5I+fIE0AZBeXYwrSxKKYu0UBhaScP3hQY+06yZRI+1jcNrv0ZNaPxejYzXIO3/YxzEqdSUkZyv01qhS7kHsLi66Xaxck1Yn8IC0BG7c2nucbX1rnroB5iLiLTwAffOywoqtxTyynVePx8mKTJuz3E7ueW2dUustp8ZqbHMU5NLVyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by AM8PR04MB7330.eurprd04.prod.outlook.com (2603:10a6:20b:1c4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23; Tue, 8 Oct 2024 05:51:42 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::4e24:c2c7:bd58:c5c7%4]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 05:51:41 +0000 Date: Tue, 8 Oct 2024 13:49:35 +0800 From: Xu Yang To: Namhyung Kim Cc: Frank.li@nxp.com, will@kernel.org, mark.rutland@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, john.g.garry@oracle.com, james.clark@linaro.org, mike.leach@linaro.org, leo.yan@linux.dev, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 3/3] perf vendor events arm64: Add i.MX91 DDR Performance Monitor metrics Message-ID: <20241008054935.zi2kqcaj4fwf2bda@hippo> References: <20240924061251.3387850-1-xu.yang_2@nxp.com> <20240924061251.3387850-3-xu.yang_2@nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SG2PR02CA0122.apcprd02.prod.outlook.com (2603:1096:4:188::10) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|AM8PR04MB7330:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c18412b-4b03-4c75-1d42-08dce75d47ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CH7UFVKYwbJmiYa5DimjQFLDne5LErxYNgvQzY8bicMQdLreYU7Pl7ceT54h?= =?us-ascii?Q?8qdLYF6k3fH6hX3zLgn/sKJ8xnvg4PJtE++mUI32ohAfhlksaxPEyBII9D+Q?= =?us-ascii?Q?BZzTckCZCNv2Ry3796u/M4frmVuZgg4pzC+BmAWs0SzbRCdVespx7UIeLvuL?= =?us-ascii?Q?vL0pL57z5BZQmChodCPpL6EJRL2Rh9W0+1ZrsVNi4hqsuQ/eSvy5V1LNxiS9?= =?us-ascii?Q?n1LvIIFLeMLQHdaVRN+YvN+WPof2hUg7ZIIU8ySzSLQjCmDu7rhzOPOjQOcT?= =?us-ascii?Q?kZjnHTRz+tllOPuXAd6LHuIqbs5m/4BKoW9GQWZuBv31aNe0L843d6uPi+cC?= =?us-ascii?Q?+8gy61FNtgn3CqeRTT9ZJE1PO+nSzvfON1sYchSO2KPXaiGuX95YmdO2iVQH?= =?us-ascii?Q?vuwcYNKIJZt7MXzn4dDuVxCcTqtYuvBGcvXnB3o2Oc1fGecvS1AVbDm7OWtD?= =?us-ascii?Q?b6gvoH9hBETzqsJ1XOofTgiPxy+89Akh2AIL680DYs9VrEGcMVENOwtYaBOw?= =?us-ascii?Q?pMOLdGLF526Ci9vEsb44EYKomLwM6hq1oESoakbbTwyWFAXc0io5fGZQeoe2?= =?us-ascii?Q?dsVrn/aU3vj9el8IjDF8g56vWUURih7AplbQ/7OucVTZIDO2+Tx54vkzDz5O?= =?us-ascii?Q?IVeB9fZEgVR3XxJOVQ6xdFgFOnqd83lhruzYtRMBGQPMQRwok5OqgG09ymep?= =?us-ascii?Q?AjQofoN/XfXOEvmvEGhUKcTlY59AbDksI+g0q/RyAfUeFXFyQIIpzyp6BrbM?= =?us-ascii?Q?frIwamXOdYf1CTMCkAu/XiEMnxyTd2+AciOtcs+VE8S1NEX8jV4EBIEU3hpX?= =?us-ascii?Q?xFc3NJhf2QJ704N5CK+L2OtrwQslPSKbQI6ITPDAqyNVQkfpgWj0B7fygyZQ?= =?us-ascii?Q?8RJu1+fq0RvmAgRpzq/pUFJ9qJOPgDbw/HJOp1PtSU+DL0ZVgAa68LHhmRQ+?= =?us-ascii?Q?5aIsgKIY9bkAW2aCqqE8FR+YkSRs+hqiCtgfWZfHvU5qInYrtCqn3LSIpX/+?= =?us-ascii?Q?wnIp5JA5IPBhqf9LjMiLLp51Gr/X1pLglF9HAiRkAWaxG+rF9Pa0MHCKFACK?= =?us-ascii?Q?Q6vv7yHt6ixDpitlWGAZ+EioMS+KlKSDfXSrWXm+TrDIxlunR3QnF+nOgD3i?= =?us-ascii?Q?Y1FO1BylZZy3ImogATu8u+yj4Nv6xuVEXtCmxce97LIGHZFYN6T62H9LWrB3?= =?us-ascii?Q?DIBuYw6yztVT7y2yrlePLwbqMLdlPFHuuZNVq8/DCUOOlauy/D3pWJ3WRjCH?= =?us-ascii?Q?coKUa3AMZk5DM4lTsOxpBEttR4ksRp6H/baVc0+DlHAM8Z9vgOOqWs30Le7B?= =?us-ascii?Q?80kz8+GRcCz40cfyJ4+daOfQ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?deMfs8O6AIXgDcPjMZjHfvzQtRgUjAwOmYU6GxMSO35vzwsE/2oMyy6PXwyj?= =?us-ascii?Q?HyT0B1Anm/r5crvYtzEyEYf/o/JAW8BcFpcHqItbRXz8GBt/PYfT/HwKyCxJ?= =?us-ascii?Q?6c26+ts2F1HwI3jLeC4hzu21Ut6KTIajUOAmqztP2yxQq8P6s3ZtHdXRzXW/?= =?us-ascii?Q?fC9AbGVbR+4D3pPC+xFciTChLV0Q6VZLTeajCrPYzFMGkJU1HMhEjymJGvU5?= =?us-ascii?Q?Tc1yGtXr7d/KJrKcerrEGYolgSb3EjW7Gu3QsbrUKwluxOajyESXS73bwDmp?= =?us-ascii?Q?O6uYwoB9BP0jSDwQAWzfMWEmzdww+1++Y20ASfgXVvF0AILxXRv35fqv3iOZ?= =?us-ascii?Q?FiVd5z+2bqe/DdCbCM5ztJvtSIrTOpBj5+sY2bj4Gq9Dm3nWbOUfFeuynSnZ?= =?us-ascii?Q?1jFz9+V6lQvEGvXNQj7uhwYKPGMOz93zUnm/S/JYtXsuJDKGqGCILMRBxwBc?= =?us-ascii?Q?B5PI4kMXwNWj6Zgip21Fr78rZSkgToH0TB5+CQT1NBoXEJ+A3nFuihshhtkg?= =?us-ascii?Q?qUfeA741/SqasKClajeel0OyNQnWETHtpyGD3vXs3Z+AbylNvkPZa00FGc6U?= =?us-ascii?Q?Xo4Dc/xxxm9IeENKCUZUB78W5gMCLw5UhA/aV5wqSTQHbLLwo/fr9yGAwaMF?= =?us-ascii?Q?PDq7BeVTDgJTinlH5T7LD0IzXULzOLk7Bm/HPXTI+U4zzm8sFeONsZVfKBYu?= =?us-ascii?Q?gWaMtMII+c98m0oOVRUWaqesv1aG0CvRU0UV8TsYm4A3epiCavIUv3HBxejS?= =?us-ascii?Q?KrRkf8Tk8/Ch9z9DabbpXC0JQ6ujmttKYB0VbnQ7c+4S9cLcheHOc7FwD+th?= =?us-ascii?Q?8Lf/FQt10oAFzfA8tp5wzXuVNosHjk1jOEBpq9eB8oDfAtIhlKWJZzMSisMg?= =?us-ascii?Q?vH+jbJsBO/qk7GDEy6aaS8FkjSvtyOLNeCihqyQqCc/eXN/0CzK9dTe0RYno?= =?us-ascii?Q?zE7TBRVSWiDqCg2xySzi2K0HRi3Gv+rXU4+rvdd9PAQA/OdA7C6hfvWpAtcr?= =?us-ascii?Q?UgzzWvg/ci4tpwrPZwF8flVdVnUZF+SCFjCJByUH5o3zdaVoLKnWNObO6SYh?= =?us-ascii?Q?1k4iDjLQm+7CzuNgaRQqn9nI39f7uQkWhBNCB9XDVqotK7Xelwk8X7T7VSkm?= =?us-ascii?Q?6xT/VGkj71wIMlM191162lXjyG483NZqrxs664sboC9w7Fog8qDCfp0f7bv1?= =?us-ascii?Q?J6nsxcPHLRYN7lK2qeV4xlIu152UPzgw3Z36sIn3GkMbfO2ps8AkyBsJzWSc?= =?us-ascii?Q?1z0963jaSJZxiFJQcbdUlAFepWVOTeZMHketG8uRscvMyzCKK826Yvsy9RC6?= =?us-ascii?Q?POqvg4XUnMlo/GYX5vFSjx2l93FFuk4SIa8aN4sdDqZKto+tSef/ZSU0R91M?= =?us-ascii?Q?nnJkN7kHWgxg6YRTYfyckJrzrgXy37Rs32njF6i21ynyma5RJvJa9MRc7/nB?= =?us-ascii?Q?we7xR4mHIC3BhoJ51m0/veLsjr8HednvjzbueCGYWNdP+7RxVrm4/Gu/E2Jx?= =?us-ascii?Q?A7kAdh9SL54OcY0QDEkSF63ZL4dpq4d7hXeOV5FGFnNer4NN0r2rAra8IHoL?= =?us-ascii?Q?qA/BmotoHt4wankqvkpTxWXCq9xLVkMhMrj/z3wA?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c18412b-4b03-4c75-1d42-08dce75d47ee X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 05:51:41.0446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Df5vK++vjlyyMT7rlqFRke+UUB3Ea3ww+SzCqYwRWqwd6PdZyUiHqs4zGggiyQhiSkjojdAQcmFiTUwkd/drng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7330 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_225152_421664_B8CD608A X-CRM114-Status: GOOD ( 23.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Namhyung, On Mon, Sep 30, 2024 at 02:07:51PM -0700, Namhyung Kim wrote: > Hello, > > On Tue, Sep 24, 2024 at 02:12:51PM +0800, Xu Yang wrote: > > Add JSON metrics for i.MX91 DDR Performance Monitor. > > > > Signed-off-by: Xu Yang > > --- > > .../arch/arm64/freescale/imx91/sys/ddrc.json | 9 +++++++ > > .../arm64/freescale/imx91/sys/metrics.json | 26 +++++++++++++++++++ > > 2 files changed, 35 insertions(+) > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > > create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json > > How do you want to route this? As it's mixed with kernel changes, I > would generally request to split but it's a change just to add new > files so it should be ok to go with other tree. In that case, Sorry for late. How about you pick up this one to perf-tools tree and Will Deacon pick up the first 2 patches to his tree? I didn't see Will apply perf-tools patch before. Thanks, Xu Yang > > Acked-by: Namhyung Kim > > Thanks, > Namhyung > > > > > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > > new file mode 100644 > > index 000000000000..74ac12660a29 > > --- /dev/null > > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/ddrc.json > > @@ -0,0 +1,9 @@ > > +[ > > + { > > + "BriefDescription": "ddr cycles event", > > + "EventCode": "0x00", > > + "EventName": "imx91_ddr.cycles", > > + "Unit": "imx9_ddr", > > + "Compat": "imx91" > > + } > > +] > > diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json > > new file mode 100644 > > index 000000000000..f0c5911eb2d0 > > --- /dev/null > > +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx91/sys/metrics.json > > @@ -0,0 +1,26 @@ > > +[ > > + { > > + "BriefDescription": "bandwidth usage for lpddr4 evk board", > > + "MetricName": "imx91_bandwidth_usage.lpddr4", > > + "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (2400 * 1000000 * 2)", > > + "ScaleUnit": "1e2%", > > + "Unit": "imx9_ddr", > > + "Compat": "imx91" > > + }, > > + { > > + "BriefDescription": "bytes all masters read from ddr", > > + "MetricName": "imx91_ddr_read.all", > > + "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8", > > + "ScaleUnit": "9.765625e-4KB", > > + "Unit": "imx9_ddr", > > + "Compat": "imx91" > > + }, > > + { > > + "BriefDescription": "bytes all masters write to ddr", > > + "MetricName": "imx91_ddr_write.all", > > + "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32", > > + "ScaleUnit": "9.765625e-4KB", > > + "Unit": "imx9_ddr", > > + "Compat": "imx91" > > + } > > +] > > -- > > 2.34.1 > >