* [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
@ 2024-10-08 7:15 Macpaul Lin
2024-10-08 9:09 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 4+ messages in thread
From: Macpaul Lin @ 2024-10-08 7:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin, Sen Chu,
Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai
The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
The error message was:
t-phy@11e30000: 'power-domains' does not match any of the regexes:
'^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
Fix this issue by dropping 'power-domains' of u3phy1 node.
This is because MediaTek tphy dose not need to add mtcmos. It is not
necessary to add 'power-domains'. If the power of the tphy is turned off,
it will affect other functions. From the current USB hardware design
perspective, even if mtcmos is added to the phy, it is always on.
Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
1 file changed, 1 deletion(-)
Changes for v2:
- Add detail description of the tphy design for explaining the reason
of this change.
diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
index ade685ed2190..1c6f08dde31c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
@@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0 0x11e30000 0xe00>;
- power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
status = "disabled";
u2port1: usb-phy@0 {
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-08 7:15 [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
@ 2024-10-08 9:09 ` AngeloGioacchino Del Regno
2024-10-09 9:21 ` Macpaul Lin
0 siblings, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-08 9:09 UTC (permalink / raw)
To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, Seiya Wang, Tinghan Shen, Chunfeng Yun,
Alexandre Mergnat
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai
Il 08/10/24 09:15, Macpaul Lin ha scritto:
> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> The error message was:
> t-phy@11e30000: 'power-domains' does not match any of the regexes:
> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> Fix this issue by dropping 'power-domains' of u3phy1 node.
>
> This is because MediaTek tphy dose not need to add mtcmos. It is not
> necessary to add 'power-domains'. If the power of the tphy is turned off,
> it will affect other functions. From the current USB hardware design
> perspective, even if mtcmos is added to the phy, it is always on.
>
> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> Changes for v2:
> - Add detail description of the tphy design for explaining the reason
> of this change.
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index ade685ed2190..1c6f08dde31c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 0 0x11e30000 0xe00>;
> - power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
> status = "disabled";
>
> u2port1: usb-phy@0 {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-08 9:09 ` AngeloGioacchino Del Regno
@ 2024-10-09 9:21 ` Macpaul Lin
2024-10-23 6:44 ` Macpaul Lin
0 siblings, 1 reply; 4+ messages in thread
From: Macpaul Lin @ 2024-10-09 9:21 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat, Jian Yang, Jianguo Zhang,
Jieyy Yang
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai
On 10/8/24 17:09, AngeloGioacchino Del Regno wrote:
> Il 08/10/24 09:15, Macpaul Lin ha scritto:
>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>> The error message was:
>> t-phy@11e30000: 'power-domains' does not match any of the regexes:
>> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>
>> This is because MediaTek tphy dose not need to add mtcmos. It is not
>> necessary to add 'power-domains'. If the power of the tphy is turned off,
>> it will affect other functions. From the current USB hardware design
>> perspective, even if mtcmos is added to the phy, it is always on.
>>
>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and
>> evaluation board")
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
Sorry for bothering, it seems MediaTek internal still have some
discussion about according to Conor's suggestion:
[1]
https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
Please don't to pick this patch until if MediaTek could have some
conclusions.
>> ---
>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> Changes for v2:
>> - Add detail description of the tphy design for explaining the reason
>> of this change.
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> index ade685ed2190..1c6f08dde31c 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> ranges = <0 0 0x11e30000 0xe00>;
>> - power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
>> status = "disabled";
>> u2port1: usb-phy@0 {
>
>
Thanks!
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
2024-10-09 9:21 ` Macpaul Lin
@ 2024-10-23 6:44 ` Macpaul Lin
0 siblings, 0 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-10-23 6:44 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Seiya Wang, Tinghan Shen,
Chunfeng Yun, Alexandre Mergnat, Jian Yang, Jianguo Zhang,
Jieyy Yang
Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
MediaTek Chromebook Upstream, Chen-Yu Tsai
On 10/9/24 17:21, Macpaul Lin wrote:
>
>
> On 10/8/24 17:09, AngeloGioacchino Del Regno wrote:
>> Il 08/10/24 09:15, Macpaul Lin ha scritto:
>>> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
>>> The error message was:
>>> t-phy@11e30000: 'power-domains' does not match any of the regexes:
>>> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
>>> Fix this issue by dropping 'power-domains' of u3phy1 node.
>>>
>>> This is because MediaTek tphy dose not need to add mtcmos. It is not
>>> necessary to add 'power-domains'. If the power of the tphy is turned
>>> off,
>>> it will affect other functions. From the current USB hardware design
>>> perspective, even if mtcmos is added to the phy, it is always on.
>>>
>>> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and
>>> evaluation board")
>>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno
>> <angelogioacchino.delregno@collabora.com>
>
> Sorry for bothering, it seems MediaTek internal still have some
> discussion about according to Conor's suggestion:
>
> [1]
> https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
>
>
> Please don't to pick this patch until if MediaTek could have some
> conclusions.
Update: This patch could be dropped since the correct fix in
TPHY's DT Schema has been accepted.
[2]
https://lore.kernel.org/all/172917936283.288841.9548294790735623997.b4-ty@kernel.org/
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> Changes for v2:
>>> - Add detail description of the tphy design for explaining the reason
>>> of this change.
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> index ade685ed2190..1c6f08dde31c 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>>> @@ -1920,7 +1920,6 @@ u3phy1: t-phy@11e30000 {
>>> #address-cells = <1>;
>>> #size-cells = <1>;
>>> ranges = <0 0 0x11e30000 0xe00>;
>>> - power-domains = <&spm MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>;
>>> status = "disabled";
>>> u2port1: usb-phy@0 {
>>
>>
>
> Thanks!
> Macpaul Lin
Thanks!
Macpaul Lin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-23 6:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 7:15 [PATCH v2] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy Macpaul Lin
2024-10-08 9:09 ` AngeloGioacchino Del Regno
2024-10-09 9:21 ` Macpaul Lin
2024-10-23 6:44 ` Macpaul Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).