From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2ABACEF176 for ; Tue, 8 Oct 2024 13:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OHp+B5gipswdfD3qLitNztnYqKsl36Fc0ZZW4wEL3Vk=; b=AW/3EWxAZxRFq1wtcf6vc4ROQu QGHtYxaYpixBrdq8xlK3oaaCyqLopeesa7o20QFJOYQXa8HR4KiSLu6/cMvoQy2MDsMh2wg1jtBQd dlecigN3q1qirb8QbWKNBDz9N3Qod5kYiJS0iuThteXCUyb6PjTHB3SXYC/XAqsmMNy7z9N1l9mg2 EZooOkuBBn84r14FcuR0XAAdOIBIfaUG/Z2wWo88/ul7sOhL1PfOavtEeocFLtHxSs4YXwlR+zkkk D3M0wL6XC1oyn8Qa8L6xWZJtstoJxbFDv7t5qMDo8tAScZIvcqwUNMOYeYn1pso3stkkRZyC6iBOR gzHoMrOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syASW-0000000622h-49Zd; Tue, 08 Oct 2024 13:41:04 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syAIz-00000005zrl-1REy; Tue, 08 Oct 2024 13:31:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0225FA4192E; Tue, 8 Oct 2024 13:31:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7D1DC4CECD; Tue, 8 Oct 2024 13:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728394272; bh=Ka0LAzRHGohiEHtrGoJMIPegJU0CmUNQAZsdKWVj+98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h1e0UWeT9/XMcrLegnrhI+5IfBnv4BynAYs6MMbKA+8GjFI1xwdWlbvNA/EOk1wXj cMig09qVCflTAd1Qm91sxeFzoGixOFEPQNlkL24sTuMcqnjjibgl8xe0U5R2Hpfwdy 12SpW74f5vKgrj9Bw4WdZIWt3cMj1WErrbWv8pOA= Date: Tue, 8 Oct 2024 15:22:29 +0200 From: Greg KH To: Mark Brown Cc: Dragan Simic , linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org, heiko@sntech.de, rafael@kernel.org, oss@helene.moe, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] driver core: Add device probe log helper dev_warn_probe() Message-ID: <2024100815-flaky-prelaunch-f5c0@gregkh> References: <2be0a28538bb2a3d1bcc91e2ca1f2d0dc09146d9.1727601608.git.dsimic@manjaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_063113_471335_4C343B32 X-CRM114-Status: GOOD ( 15.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2024 at 03:25:52PM +0100, Mark Brown wrote: > On Sun, Sep 29, 2024 at 11:21:16AM +0200, Dragan Simic wrote: > > Some drivers can still provide their functionality to a certain extent even > > some of their resource acquisitions eventually fail. In such cases, emitting > > errors isn't the desired action, but warnings should be emitted instead. > > > > To solve this, introduce dev_warn_probe() as a new device probe log helper, > > which behaves identically as the already existing dev_err_probe(), while it > > produces warnings instead of errors. The intended use is with the resources > > that are actually optional for a particular driver. > > > > While there, copyedit the kerneldoc for dev_err_probe() a bit, to simplify > > its wording a bit, and reuse it as the kerneldoc for dev_warn_probe(), with > > the necessary wording adjustments, of course. > > Greg, this makes sense to me - are you OK with me applying it? No objection from me, now sent a reviewed-by