From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39695CF042B for ; Tue, 8 Oct 2024 23:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EHWNWQP0MMPT8jCtNvFSEyg3s08DKD+aBnlzkkhHBH0=; b=imsNhcaPUgvYRl5ZpHvdza4OYr 3mdUCWwobEU9ZJgmlu/IwniFxn/ei7rtOGTFKofBvKJLyirjWBS4P1luhtQK9I8+Uds7cfC4H3GnH vOjo38QxVgHSQoxI+Kb5Oj0NukN/atGwG7+AEikjoIcs/AS/kNZh8pTAZRwDZhlOKEtehu52NRq8V a3R6xOPdBMIKbxySkWLfw0ub6q/E7pQAE4odvbrlGgVkKC7p83uUpJ66pGNMZbi7yI3iYBLBYT46X PWqZte8Yq5/7QRmbFzbNryyeykhu1kDpxZn2f6fIsPPHIIvv0dIsylrKd8yeRj+lqiqpHrv1N1d14 GIiICJjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syJBg-00000007NQg-0UxD; Tue, 08 Oct 2024 23:00:16 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syJAK-00000007NHs-3ca0; Tue, 08 Oct 2024 22:58:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2E74BA4299F; Tue, 8 Oct 2024 22:58:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB329C4CEC7; Tue, 8 Oct 2024 22:58:47 +0000 (UTC) Date: Tue, 8 Oct 2024 18:58:51 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux Trace Kernel , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "linux-arch@vger.kernel.org" , "x86@kernel.org" , Mathieu Desnoyers , Mark Rutland , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use Message-ID: <20241008185851.274887ca@gandalf.local.home> In-Reply-To: <20241009074140.b163eceb2f973227b400c962@kernel.org> References: <20241007204743.41314f1d@gandalf.local.home> <20241009074140.b163eceb2f973227b400c962@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_155853_001735_83DEB1EC X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 9 Oct 2024 07:41:40 +0900 Masami Hiramatsu (Google) wrote: > Hi Steve, > > > diff --git a/include/asm-generic/ftrace.h b/include/asm-generic/ftrace.h > > index 3a23028d69d2..ba7b7d6e55d6 100644 > > --- a/include/asm-generic/ftrace.h > > +++ b/include/asm-generic/ftrace.h > > @@ -10,4 +10,17 @@ > > * common definitions are already in linux/ftrace.h. > > */ > > > > +#ifndef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS > > +struct __arch_ftrace_regs { > > + struct pt_regs regs; > > +}; > > + > > +#define arch_ftrace_get_regs(fregs) \ > > + ({ struct __arch_fregs_regs *__f = (struct __arch_ftrace_regs *)(fregs); \ > > + &__f->regs; \ > > + }) > > + > > +struct ftrace_regs; > > +#define arch_ftrace_regs(fregs) ((struct __arch_ftrace_regs *)(fregs)) > > + > > #endif /* __ASM_GENERIC_FTRACE_H__ */ > > There seems no #endif for CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS. > I wonder how it passed the build. (#ifdef block does not affect over > the file boundary? > Yeah I caught that. That's one way I found out that this file is not compiled by most architectures. I'll be sending a v2 very shortly. -- Steve