Re: [PATCH v2 11/14] ARM: dts: rockchip: fix rk3036 acodec node

Dragan Simic
2024-10-09T07:34:37Z

Hello Heiko,

On 2024-10-08 22:39, Heiko Stuebner wrote:
> The acodec node is not conformant to the binding.
> Set the correct nodename, use the correct compatible,
> add the needed #sound-dai-cells and sort the rockchip,grf
> below clocks properties as expected.

Maybe reflow the commit description a bit, to use the available
column width better. :)

> Fixes: faea098e1808 ("ARM: dts: rockchip: add core rk3036 dtsi")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Looking good to me, thanks for the patch. The introduced changes
are obviously correct.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
> arch/arm/boot/dts/rockchip/rk3036.dtsi | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi
> b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> index 96279d1e02fe..37369538483f 100644
> --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi
> +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi
> @@ -384,12 +384,13 @@ reboot-mode {
> };
> };
>
> - acodec: acodec-ana@20030000 {
> - compatible = "rk3036-codec";
> + acodec: audio-codec@20030000 {
> + compatible = "rockchip,rk3036-codec";
> reg = <0x20030000 0x4000>;
> - rockchip,grf = <&grf>;
> clock-names = "acodec_pclk";
> clocks = <&cru PCLK_ACODEC>;
> + rockchip,grf = <&grf>;
> + #sound-dai-cells = <0>;
> status = "disabled";
> };