Re: [PATCH v2 02/14] arm64: dts: rockchip: Drop regulator-init-microvolt from two boards

Dragan Simic
2024-10-08T21:09:07Z

Hello Heiko,

On 2024-10-08 22:39, Heiko Stuebner wrote:
> rk3568-roc-pc and rk3588-toybrick-x0 re-introduced this property
> despite
> previous patches removing older instances already.
>
> regulator-init-microvolt is not part of any regulator binding and is
> only used in the Rockchip vendor kernel. So drop it.
>
> It is used by u-boot in some places to setup initial regulator-state,
> but that should happen in the existing -u-boot devicetree additions.
>
> Fixes: 007b4bb47f44 ("arm64: dts: rockchip: add dts for Firefly
> Station P2 aka rk3568-roc-pc")
> Cc: Furkan Kardame <f.kardame@manjaro.org>
> Fixes: 8ffe365f8dc7 ("arm64: dts: rockchip: Add devicetree support for
> TB-RK3588X board")
> Cc: Elon Zhang <zhangzj@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Looking good to me, thanks for the patch. Having support for the
"regulator-init-microvolt" property in board dts files, or not having
it, goes back to the main purpose of the DTs, which define hardware,
but, in general, do not contain system configuration or policies.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
> arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts | 3 ---
> arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> index e333449ead04..2fa89a0eeafc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-roc-pc.dts
> @@ -272,7 +272,6 @@ vdd_logic: DCDC_REG1 {
> regulator-name = "vdd_logic";
> regulator-always-on;
> regulator-boot-on;
> - regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> regulator-max-microvolt = <1350000>;
> @@ -285,7 +284,6 @@ regulator-state-mem {
>
> vdd_gpu: DCDC_REG2 {
> regulator-name = "vdd_gpu";
> - regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> regulator-max-microvolt = <1350000>;
> @@ -309,7 +307,6 @@ regulator-state-mem {
>
> vdd_npu: DCDC_REG4 {
> regulator-name = "vdd_npu";
> - regulator-init-microvolt = <900000>;
> regulator-initial-mode = <0x2>;
> regulator-min-microvolt = <500000>;
> regulator-max-microvolt = <1350000>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
> b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
> index d0021524e7f9..328dcb894ccb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-toybrick-x0.dts
> @@ -428,7 +428,6 @@ vdd_vdenc_s0: vdd_vdenc_mem_s0: dcdc-reg4 {
> regulator-boot-on;
> regulator-min-microvolt = <550000>;
> regulator-max-microvolt = <950000>;
> - regulator-init-microvolt = <750000>;
> regulator-ramp-delay = <12500>;
>
> regulator-state-mem {