Re: [PATCH v2 05/14] arm64: dts: rockchip: Remove undocumented supports-emmc property

Dragan Simic
2024-10-08T21:19:07Z

Hello Heiko,

On 2024-10-08 22:39, Heiko Stuebner wrote:
> supports-emmc is an undocumented property that slipped into the
> mainline
> kernel devicetree for some boards. Drop it.
>
> Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck)
> SoM with Haikou baseboard")
> Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM
> NanoPi R2S Plus")
> Cc: Sergey Bostandzhyan <jin@mediatomb.cc>
> Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
> Cc: Wenhao Cui <lasstp5011@gmail.com>
> Fixes: cdf46cdbabfc ("arm64: dts: rockchip: Add dts for EmbedFire
> rk3568 LubanCat 2")
> Cc: Andy Yan <andyshrk@163.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Looking good to me, thanks for the patch. The introduced changes
are obviously correct.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
> arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 -
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 -
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 -
> arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> index bb1aea82e666..b7163ed74232 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
> @@ -66,7 +66,6 @@ &emmc {
> bus-width = <8>;
> cap-mmc-highspeed;
> mmc-hs200-1_8v;
> - supports-emmc;
> mmc-pwrseq = <&emmc_pwrseq>;
> non-removable;
> vmmc-supply = <&vcc_3v3>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> index cb81ba3f23ff..3093f607f282 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts
> @@ -27,6 +27,5 @@ &emmc {
> num-slots = <1>;
> pinctrl-names = "default";
> pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
> - supports-emmc;
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> index c1194d1e438d..9a2f59a351de 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -507,7 +507,6 @@ &sdhci {
> non-removable;
> pinctrl-names = "default";
> pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>;
> - supports-emmc;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts
> index a3112d5df200..b505a4537ee8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts
> @@ -589,7 +589,6 @@ &sdhci {
> non-removable;
> pinctrl-names = "default";
> pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>;
> - supports-emmc;
> status = "okay";
> };