Re: [PATCH v2 09/14] arm64: dts: rockchip: Remove 'enable-active-low' from two boards

Michael Riesch
2024-10-09T05:11:14Z

Hi Heiko,

On 10/8/24 22:39, Heiko Stuebner wrote:
> The 'enable-active-low' property is not a valid, because it is the

"is not a valid" -> "is not a valid one"?

> default behaviour of the fixed regulator.
>
> Only 'enable-active-high' is valid, and when this property is absent
> the fixed regulator will act as active low by default.
>
> Both the rk3588-orange-pi-5 and the Wolfvision pf5 io expander overlay
> smuggled those enable-active-low properties in, so remove them to
> make dtbscheck happier.

Ooops :-)

>
> Fixes: 28799a7734a0 ("arm64: dts: rockchip: add wolfvision pf5 io expander board")
> Cc: Michael Riesch <michael.riesch@wolfvision.net>
> Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")
> Cc: Muhammed Efe Cetin <efectn@6tel.net>
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks a lot and best regards,
Michael

> ---
> .../boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso | 1 -
> arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> index ebcaeafc3800..fa61633aea15 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-io-expander.dtso
> @@ -49,7 +49,6 @@ vcc1v8_eth: vcc1v8-eth-regulator {
>
> vcc3v3_eth: vcc3v3-eth-regulator {
> compatible = "regulator-fixed";
> - enable-active-low;
> gpio = <&gpio0 RK_PC0 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&vcc3v3_eth_enn>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> index feea6b20a6bf..6b77be643249 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> @@ -71,7 +71,6 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>
> vcc_3v3_sd_s0: vcc-3v3-sd-s0-regulator {
> compatible = "regulator-fixed";
> - enable-active-low;
> gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_LOW>;
> regulator-name = "vcc_3v3_sd_s0";
> regulator-boot-on;