[PATCH 1/2] tty: atmel_serial: print the controller version

[PATCH 1/2] tty: atmel_serial: print the controller version

[Mihai Sain]

Add support to print the controller version similar
to other at91 drivers like spi and twi.

Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 drivers/tty/serial/atmel_serial.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 09b246c9e389..5f93974918c0 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device *pdev)
 	 */
 	clk_disable_unprepare(atmel_port->clk);
 
+	dev_info(&pdev->dev, "AT91 USART Controller version %#x",
+		 atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION));
 	return 0;
 
 err_add_port:

base-commit: 87d6aab2389e5ce0197d8257d5f8ee965a67c4cd
-- 
2.47.0

Re: [PATCH 1/2] tty: atmel_serial: print the controller version

[Greg KH]

On Tue, Oct 08, 2024 at 11:34:59AM +0300, Mihai Sain wrote:
> Add support to print the controller version similar
> to other at91 drivers like spi and twi.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..5f93974918c0 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device *pdev)
>  	 */
>  	clk_disable_unprepare(atmel_port->clk);
>  
> +	dev_info(&pdev->dev, "AT91 USART Controller version %#x",
> +		 atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION));

No, the other drivers need to be fixed up, when drivers are working
properly, they are quiet.  This driver is correct by being quiet, please
send patches for the other ones to remove these types of lines.

thanks,

greg k-h

Re: [PATCH 1/2] tty: atmel_serial: print the controller version

[Greg KH]

On Tue, Oct 08, 2024 at 09:05:24AM +0000, Mihai.Sain@microchip.com wrote:
> > On Tue, Oct 08, 2024 at 11:34:59AM +0300, Mihai Sain wrote:
> > > Add support to print the controller version similar to other at91
> > > drivers like spi and twi.
> > >
> > > Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> > > ---
> > >  drivers/tty/serial/atmel_serial.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/tty/serial/atmel_serial.c
> > > b/drivers/tty/serial/atmel_serial.c
> > > index 09b246c9e389..5f93974918c0 100644
> > > --- a/drivers/tty/serial/atmel_serial.c
> > > +++ b/drivers/tty/serial/atmel_serial.c
> > > @@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device
> > *pdev)
> > >        */
> > >       clk_disable_unprepare(atmel_port->clk);
> > >
> > > +     dev_info(&pdev->dev, "AT91 USART Controller version %#x",
> > > +              atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION));
> > 
> > No, the other drivers need to be fixed up, when drivers are working properly,
> > they are quiet.  This driver is correct by being quiet, please send patches for
> > the other ones to remove these types of lines.
> 
> Is it acceptable to use dev_dbg instead of dev_info ?

Sure, but why?  What user would ever need/want to turn that on?
dev_dbg() is for developers to help support things, a dbg call at probe
time is rare.

What would you do with such a message?

thanks,

greg k-h

Re: [PATCH 1/2] tty: atmel_serial: print the controller version

[Greg KH]

On Tue, Oct 08, 2024 at 11:34:59AM +0300, Mihai Sain wrote:
> Add support to print the controller version similar
> to other at91 drivers like spi and twi.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>  drivers/tty/serial/atmel_serial.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 09b246c9e389..5f93974918c0 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device *pdev)
>  	 */
>  	clk_disable_unprepare(atmel_port->clk);
>  
> +	dev_info(&pdev->dev, "AT91 USART Controller version %#x",
> +		 atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION));
>  	return 0;
>  
>  err_add_port:
> 
> base-commit: 87d6aab2389e5ce0197d8257d5f8ee965a67c4cd
> -- 
> 2.47.0
>

Did I miss patch 2/2 of this series?  I don't see it anywhere :(