From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD579CED27C for ; Tue, 8 Oct 2024 08:46:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dz62MN50UVTqXRnt1+/tJJemz5SsHwHQN0QIke0Vyq8=; b=jsQMzy0YRf6IWL7YhiT5UlYFU2 wA9FS8aWamGKfYsho/OZ+SGIPjFyxy5b/yDJSv9GKVWguCIJu32GHF1r611bZXhIkjTuBWjN0th4I BFXd7yAd2RGAeJMA3/m+wMg3m9Dg9QVuM94OExc4eGJfNwz98HpJIMrmP/CNUIXww+Kd6mX9sfO/L 6ANhIPX04PaNTuOWrDmRmJmsxcS8W3Lnrg3pksVjDPNxDiuuXYIfEXqhpm7D2vZyk09WK1uSaaJk1 q4WyjgMMO1v4zImUmjFC6N0tvRx+bOrnIT59JNPj1W0CMUfPJXaShWHtP7xN4LgVjSHGjXZKTyIkJ UWuqKKlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy5ri-0000000580V-1AKb; Tue, 08 Oct 2024 08:46:46 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy5jG-000000055Hh-3SUR for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 08:38:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 35F66A43328; Tue, 8 Oct 2024 08:37:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 021C2C4CEC7; Tue, 8 Oct 2024 08:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728376681; bh=6eDVLcMow972i4aZcmm3VEJCEQO7PY9kXFSk28hSIF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qat6nI5xfIlWrewKaqWx+n6UttT1ryoMQ0w0EgzjP6cQVfi1nqBbIFk+MZ1DJ1iQV 3mYE1HMndtI9xwTy18FbAXbqeDX1du1t8G1UhIQF4eI8UlKgcbPy4Gjse8FphTg+UB KW4A/W4y7vjSsTNZ08C+Vm7+HKvZwGFXM7InfldA= Date: Tue, 8 Oct 2024 10:37:58 +0200 From: Greg KH To: Mihai Sain Subject: Re: [PATCH 1/2] tty: atmel_serial: print the controller version Message-ID: <2024100842-luncheon-severity-afc0@gregkh> References: <20241008083459.51249-1-mihai.sain@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241008083459.51249-1-mihai.sain@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_013802_943794_C85561DA X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, richard.genoud@bootlin.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 08, 2024 at 11:34:59AM +0300, Mihai Sain wrote: > Add support to print the controller version similar > to other at91 drivers like spi and twi. > > Signed-off-by: Mihai Sain > --- > drivers/tty/serial/atmel_serial.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 09b246c9e389..5f93974918c0 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device *pdev) > */ > clk_disable_unprepare(atmel_port->clk); > > + dev_info(&pdev->dev, "AT91 USART Controller version %#x", > + atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION)); No, the other drivers need to be fixed up, when drivers are working properly, they are quiet. This driver is correct by being quiet, please send patches for the other ones to remove these types of lines. thanks, greg k-h