From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C203CEF144 for ; Tue, 8 Oct 2024 09:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uPmx61k1zrqN24WneoXad0Wz5F0I3Sdp57fOYOntdhQ=; b=xxOsLePO5JPBPv+B4Vog4x6Bl4 Ve4RaqPGZ60PLDIF2wNLwvT94tPOMOjXIH7sWQPQSHboFZBYONlIb84oaFAv5XGS9ctiAGlHEIJ6E LA8SkHD697cw3je+xujjA+pDruCBXy/cCSyiqrBn4BoYEqPBS2ftVuN/mwPmbFoHHKQL3FnWwa5we pkI1SEmTVVybx3Pw73Eqmf5ocZszsFezMAFi1Dqf2rspj2qFmS1dKmk4V22hgy958UUqW5GdPBNV5 BWG93XRtbIwzlJp/3CNxCTzkvxh9upuN1qN5P4GIQoy92OA/ycA2au3qSI3mb4kfdfu+AEZwcosCf h3DZpvog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy6Qe-00000005HNN-2RCH; Tue, 08 Oct 2024 09:22:52 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sy6E3-00000005F6J-1e7l for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2024 09:09:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D64E5A425A0; Tue, 8 Oct 2024 09:09:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B99C4CEC7; Tue, 8 Oct 2024 09:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1728378590; bh=PdJBOIJCIeq/GPsMhSfGTFSTAi6DRh54T3OVSZccCzw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ogEW73lmnate6m1aBHqomv4ldFMmyzsu/jQyJBpk0aaL7iJSjHZ/3uhgxiZm4EDhX aO7NnyicOyqxS+7/p73abtdZ3Gvk0CH2IAD5DJvvvCFXQF1vmIK6Eu/ezJ2VppBYlS koUo3uJ4h5uFcYudwNtZM64ZYL14xpPyrtPElCIU= Date: Tue, 8 Oct 2024 11:09:47 +0200 From: Greg KH To: Mihai.Sain@microchip.com Subject: Re: [PATCH 1/2] tty: atmel_serial: print the controller version Message-ID: <2024100851-macaroni-giggling-7826@gregkh> References: <20241008083459.51249-1-mihai.sain@microchip.com> <2024100842-luncheon-severity-afc0@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241008_020951_540136_F11EE3FD X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jirislaby@kernel.org, richard.genoud@bootlin.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 08, 2024 at 09:05:24AM +0000, Mihai.Sain@microchip.com wrote: > > On Tue, Oct 08, 2024 at 11:34:59AM +0300, Mihai Sain wrote: > > > Add support to print the controller version similar to other at91 > > > drivers like spi and twi. > > > > > > Signed-off-by: Mihai Sain > > > --- > > > drivers/tty/serial/atmel_serial.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/tty/serial/atmel_serial.c > > > b/drivers/tty/serial/atmel_serial.c > > > index 09b246c9e389..5f93974918c0 100644 > > > --- a/drivers/tty/serial/atmel_serial.c > > > +++ b/drivers/tty/serial/atmel_serial.c > > > @@ -2970,6 +2970,8 @@ static int atmel_serial_probe(struct platform_device > > *pdev) > > > */ > > > clk_disable_unprepare(atmel_port->clk); > > > > > > + dev_info(&pdev->dev, "AT91 USART Controller version %#x", > > > + atmel_uart_readl(&atmel_port->uart, ATMEL_US_VERSION)); > > > > No, the other drivers need to be fixed up, when drivers are working properly, > > they are quiet. This driver is correct by being quiet, please send patches for > > the other ones to remove these types of lines. > > Is it acceptable to use dev_dbg instead of dev_info ? Sure, but why? What user would ever need/want to turn that on? dev_dbg() is for developers to help support things, a dbg call at probe time is rare. What would you do with such a message? thanks, greg k-h