* [PATCH] staging: vchiq_core: Fix code indent errors
@ 2024-10-07 15:22 Hridesh MG
2024-10-07 15:43 ` Dan Carpenter
2024-10-09 10:00 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Hridesh MG @ 2024-10-07 15:22 UTC (permalink / raw)
To: linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel
Cc: Hridesh MG, Florian Fainelli,
Broadcom internal kernel review list, Greg Kroah-Hartman,
Umang Jain, Stefan Wahren, Laurent Pinchart, Kieran Bingham
Replace spaces with tabs to adhere to kernel coding style.
Reported by checkpatch:
ERROR: code indent should use tabs where possible
Signed-off-by: Hridesh MG <hridesh699@gmail.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 1f94db6e0cd9..3f3ef1ca7154 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -2761,13 +2761,13 @@ vchiq_bulk_xfer_queue_msg_interruptible(struct vchiq_service *service,
state->id, service->localport, dir_char, queue->local_insert,
queue->remote_insert, queue->process);
- if (bulk_waiter) {
- bulk_waiter->bulk = bulk;
- if (wait_for_completion_interruptible(&bulk_waiter->event))
- status = -EAGAIN;
- else if (bulk_waiter->actual == VCHIQ_BULK_ACTUAL_ABORTED)
- status = -EINVAL;
- }
+ if (bulk_waiter) {
+ bulk_waiter->bulk = bulk;
+ if (wait_for_completion_interruptible(&bulk_waiter->event))
+ status = -EAGAIN;
+ else if (bulk_waiter->actual == VCHIQ_BULK_ACTUAL_ABORTED)
+ status = -EINVAL;
+ }
return status;
--
2.46.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vchiq_core: Fix code indent errors
2024-10-07 15:22 [PATCH] staging: vchiq_core: Fix code indent errors Hridesh MG
@ 2024-10-07 15:43 ` Dan Carpenter
2024-10-09 10:00 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-10-07 15:43 UTC (permalink / raw)
To: Hridesh MG
Cc: linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
Florian Fainelli, Broadcom internal kernel review list,
Greg Kroah-Hartman, Umang Jain, Stefan Wahren, Laurent Pinchart,
Kieran Bingham
On Mon, Oct 07, 2024 at 08:52:12PM +0530, Hridesh MG wrote:
> Replace spaces with tabs to adhere to kernel coding style.
>
> Reported by checkpatch:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Hridesh MG <hridesh699@gmail.com>
> ---
Thanks.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vchiq_core: Fix code indent errors
2024-10-07 15:22 [PATCH] staging: vchiq_core: Fix code indent errors Hridesh MG
2024-10-07 15:43 ` Dan Carpenter
@ 2024-10-09 10:00 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-10-09 10:00 UTC (permalink / raw)
To: Hridesh MG
Cc: linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
Florian Fainelli, Broadcom internal kernel review list,
Umang Jain, Stefan Wahren, Laurent Pinchart, Kieran Bingham
On Mon, Oct 07, 2024 at 08:52:12PM +0530, Hridesh MG wrote:
> Replace spaces with tabs to adhere to kernel coding style.
>
> Reported by checkpatch:
>
> ERROR: code indent should use tabs where possible
>
> Signed-off-by: Hridesh MG <hridesh699@gmail.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 1f94db6e0cd9..3f3ef1ca7154 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -2761,13 +2761,13 @@ vchiq_bulk_xfer_queue_msg_interruptible(struct vchiq_service *service,
> state->id, service->localport, dir_char, queue->local_insert,
> queue->remote_insert, queue->process);
>
> - if (bulk_waiter) {
> - bulk_waiter->bulk = bulk;
> - if (wait_for_completion_interruptible(&bulk_waiter->event))
> - status = -EAGAIN;
> - else if (bulk_waiter->actual == VCHIQ_BULK_ACTUAL_ABORTED)
> - status = -EINVAL;
> - }
> + if (bulk_waiter) {
> + bulk_waiter->bulk = bulk;
> + if (wait_for_completion_interruptible(&bulk_waiter->event))
> + status = -EAGAIN;
> + else if (bulk_waiter->actual == VCHIQ_BULK_ACTUAL_ABORTED)
> + status = -EINVAL;
> + }
>
> return status;
>
> --
> 2.46.1
>
>
No longer applies to the tree due to other changes that were submitted
before you, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 15:22 [PATCH] staging: vchiq_core: Fix code indent errors Hridesh MG
2024-10-07 15:43 ` Dan Carpenter
2024-10-09 10:00 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).