From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1859CFC5E7 for ; Thu, 10 Oct 2024 17:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R92vcsI553pFwZfYzMEB81wCGSzpOrK//QbPylDnkrk=; b=CChNC7IgW9rvHPaaaQrrRWXMLH 2KXNRuC2JUjpo9+37p5/X0AuUQ8/6mRdviZRJ9sg+XWVfsv9zHAekpL9bN/jsVgkeNNVHIAs/UekU UXVkq6BAm9fvqWFf/ywNpIoA9disE1urSKyx09KTPYU9aG+2vWvxtfT8GTaREVPz8+NGGyqMrZ0DY JBXqntGtAz9NR6eWqabKXOLE4cjZWbtaVqXSt50lgNigzu49ILibwe75b4HUyL/KzMwZJrsY/1TjT smBMwexzSo4hy4N6RjFkceZMiREVOFsk/h+KX/0824WZSnlv/ks/TbNx7TtTBFbDurslJOrS51NeE 6OPMmPDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syxEv-0000000Dj33-38oF; Thu, 10 Oct 2024 17:46:17 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syvz8-0000000DVzI-2JEY for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 16:25:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 122AEA44BB7; Thu, 10 Oct 2024 16:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97E75C4CEC5; Thu, 10 Oct 2024 16:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728577553; bh=dvlME7cIGafoPlXr0vrZLAnMPMxd5hylDvxsIK90mBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bEFaeSdYbaJNRDBzMzt5gJDKMbtLJZS07gnhmIHJoS4Q8dpJA6mdXqdEzvRbKnebR 3PPRJ0h4OosI45rxXD4Vfq/7YOH8H2k+KxTDnEJJoytdpiWWbteZ6pdGidxMFSLAiG teGVlM0BzRssrV9DfwvtVt9C+D1ABgFGQY5rhugpGtDf+xgTRZHZRxvd/vhBo2oMfy VwVZUEHabjN84pA66Wd8Y1DYaqR2sbJnK8JjK7CqZNHWRNthh1YJRz3vR/Hp4P370d xwIhFw2vXyyKVVqE0vJuRiojWLA1QX1nV3L+eb+aEhBi6SYtnZDxqQGGmY2ktKAo0i yrq/ClO/qL7uQ== Date: Thu, 10 Oct 2024 17:25:47 +0100 From: Lee Jones To: Manikandan Muralidharan Subject: Re: [PATCH] drm: atmel-hlcdc: bypass LCDC pixel clock divider when using LCDC Generic Clock Message-ID: <20241010162547.GK661995@google.com> References: <20241010093132.235177-1-manikandan.m@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241010093132.235177-1-manikandan.m@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_092554_671574_D6DE6C1F X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: simona@ffwll.ch, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, bbrezillon@kernel.org, sam@ravnborg.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, claudiu.beznea@tuxon.dev, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, airlied@gmail.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Oct 2024, Manikandan Muralidharan wrote: > In sam9x7 SoC where XLCDC IP is used,add support to bypass the LCDC pixel > clock divider when LCDC Generic clock is enabled.Used to match > and drive the panel requested Pixel clock. > > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 8 +++++++- > include/linux/mfd/atmel-hlcdc.h | 1 + Acked-by: Lee Jones > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 0f7ffb3ced20..c54770cecaa8 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -146,13 +146,19 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > > if (div_low >= 2 && > (10 * (prate / div_low - mode_rate) < > - (mode_rate - prate / div))) > + (mode_rate - prate / div))) { > /* > * At least 10 times better when using a higher > * frequency than requested, instead of a lower. > * So, go with that. > */ > div = div_low; > + } else { > + if (crtc->dc->desc->is_xlcdc) { > + cfg |= ATMEL_XLCDC_CLKBYP; > + mask |= ATMEL_XLCDC_CLKBYP; > + } > + } > } > > cfg |= ATMEL_HLCDC_CLKDIV(div); > diff --git a/include/linux/mfd/atmel-hlcdc.h b/include/linux/mfd/atmel-hlcdc.h > index 80d675a03b39..982f494e6307 100644 > --- a/include/linux/mfd/atmel-hlcdc.h > +++ b/include/linux/mfd/atmel-hlcdc.h > @@ -44,6 +44,7 @@ > #define ATMEL_XLCDC_HEO_UPDATE BIT(3) > > #define ATMEL_HLCDC_CLKPOL BIT(0) > +#define ATMEL_XLCDC_CLKBYP BIT(1) > #define ATMEL_HLCDC_CLKSEL BIT(2) > #define ATMEL_HLCDC_CLKPWMSEL BIT(3) > #define ATMEL_HLCDC_CGDIS(i) BIT(8 + (i)) > -- > 2.25.1 > -- Lee Jones [李琼斯]