From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D9C8D24451 for ; Thu, 10 Oct 2024 20:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/I/lOPCvj/ZjeWChjY+DvX2ksqrYKCeJpqQ5rwBLawg=; b=36F2s26ppH45Jms/NAa8RclaGP 1Ic9IeFS0wEbsf2nIQAOuSWP6PVDKZzykVjpNyI0auPU05xgdQ6QxEDnpo7zWQtiFYESEwg/fZw9u DL4QNfVLMdRkHK24KpMqTKZxm3wrIyz5w2abFo48SRcchoJILoFyqWpkKi73gSgLy4CqS/Y/I9OAC BvWxNkcuvQzHDpx4MjztkBMfHgaKtBwCApvf5izpSvKRdPt/Sl0AfjMa/9wfj0sYaYC1BpOjTzWXj pTQ7FJgjZfju8vltebJzGJupXigPRh7F74sJAagifJ2amxKRcv402/9C3r3s6ljlAMRr+rwGYgxqT /lsiB+Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sz01U-0000000EK1l-0SLj; Thu, 10 Oct 2024 20:44:36 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syzVU-0000000EEXH-1pZg for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 20:11:35 +0000 Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id E31AD1F969; Thu, 10 Oct 2024 22:11:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1728591086; bh=/I/lOPCvj/ZjeWChjY+DvX2ksqrYKCeJpqQ5rwBLawg=; h=From:To:Subject; b=pMF193xbTFIzRJTY6djU4mXUsm9R6/HW+dM2v2iOS9lqEfsk32VpZ1E+pXfqj1ZCx 1iPu8rpsjf/LD2jXnV7Qpun5CQDjei5WZC0/I8J7v/9OfxbirdO2ZA16oZzQ3qvEyL M9869aCZ+4aUDBQ0dcZDu9qR72BPi8TOd8FGDfgD8tm2mM6sl5OipwVagnB8xIn7CW UgwZiMmbL+u1yMEi3VfclrXSkFe3PQmQkDQCioAVXdt1IocqHiZsE+gsoVZHcrP3Fc pu/9bUqsvXMpwD6T6I2b71P/zRbSSvrzg0Q0J+BERe6M+88IgeIVMLM/lx1WzGL+tx 48dIdF46pK8/g== Date: Thu, 10 Oct 2024 22:11:21 +0200 From: Francesco Dolcini To: Frank Li Cc: Stefan Eichenberger , hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, bhelgaas@google.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, francesco.dolcini@toradex.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v2] PCI: imx6: Add suspend/resume support for i.MX6QDL Message-ID: <20241010201121.GA88411@francesco-nb> References: <20241009131659.29616-1-eichest@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_131133_549925_5D421AC5 X-CRM114-Status: GOOD ( 21.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Frank, On Thu, Oct 10, 2024 at 04:01:21PM -0400, Frank Li wrote: > On Wed, Oct 09, 2024 at 03:14:05PM +0200, Stefan Eichenberger wrote: > > From: Stefan Eichenberger > > > > The suspend/resume support is broken on the i.MX6QDL platform. This > > patch resets the link upon resuming to recover functionality. It shares > > most of the sequences with other i.MX devices but does not touch the > > critical registers, which might break PCIe. This patch addresses the > > same issue as the following downstream commit: > > https://github.com/nxp-imx/linux-imx/commit/4e92355e1f79d225ea842511fcfd42b343b32995 > > In comparison this patch will also reset the device if possible. Without > > this patch suspend/resume will not work if a PCIe device is connected. > > The kernel will hang on resume and print an error: > > ath10k_pci 0000:01:00.0: Unable to change power state from D3hot to D0, device inaccessible > > 8<--- cut here --- > > Unhandled fault: imprecise external abort (0x1406) at 0x0106f944 > > > > Signed-off-by: Stefan Eichenberger > > --- > > Thank you for your patch. > > But it may conflict with another suspend/resume patch > https://lore.kernel.org/imx/1727245477-15961-8-git-send-email-hongxing.zhu@nxp.com/ Thanks for the head-up. Do you see any issue with this patch apart that? Because this patch is fixing a crash, so I would expect this to be merged, once ready, and such a series rebased afterward. I am writing this explicitly since you wrote a similar comment on the v1 (https://lore.kernel.org/all/ZsNXDq%2FkidZdyhvD@lizhi-Precision-Tower-5810/) and I would like to prevent to have this fix starving for long just because multiple people is working on the same driver. Francesco