From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F9F7D1A431 for ; Sat, 12 Oct 2024 06:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tm+CjjmF+8X+/H05Bxg8usWBkcPnBrCtCrDgxghNmlg=; b=LnFNv8/49bPKzX4Ns/4mTuhnMd U6K/UGODtPROVTeW99WzmXI8TCc9iQdj7XA1UOCikrVrvAe+v3I1tQ34x74H2EfxsfQDilSPh8ZQO KUfxAuPSpxypuHQlQYy4vLNNNBymN58KnaBFaPD4GClvjgnDmNkNWnvoDybCYSyrm1yfAMFwn5sUe EUz+gA2CQQI8iI/WzfXIFaEX74NM1b52H6jeYBX2NMwqDpzgIqEFau2iEaRH7auvRCuKnswknlB0A HqG8xpnmU3DsPZ9xp3BdGZIlZGblE7pjrhimXayC0MpQ2o8pemFn23zS9v63ZRNd1sudgRj9tv3qk i0xe4JXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szVKV-00000000cN2-3LiJ; Sat, 12 Oct 2024 06:10:20 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szVJ8-00000000cH9-3lS9 for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 06:08:56 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-71e467c3996so702964b3a.2 for ; Fri, 11 Oct 2024 23:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728713334; x=1729318134; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tm+CjjmF+8X+/H05Bxg8usWBkcPnBrCtCrDgxghNmlg=; b=nAfD6dHco8JwmzyWj0st4QcTFKt+uxZrPaQsjIr9VGITpkdnR3D7Z0BA//aNATzYVL PJ8VYyHzZphsmR1GIQdn8uEGObpVAjvhLJgwMR+Yzqff2GoIJC787vF1iOJg83SCaVVm WHUCkI8asiNEp3CPlmA3AXtFfRRZmAuWD1e7yDPiKda2+sSqNpAGwAAC0tsfCGIttiAG FormbGIWvbJT1p7q+HWazyGAG/q8gyOI9x8pI7L0HhcpG/vi0pbvqwKJOrjkhAK75lSU 4ZW6Gv73PK1FeG80LqqRCMm89+QboOeQAra170r7N+Pa8M4Ze2Seou6VGotnG+y4F0A8 GMKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728713334; x=1729318134; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tm+CjjmF+8X+/H05Bxg8usWBkcPnBrCtCrDgxghNmlg=; b=FqkAunGXRkocrtcL5ftj6I5E3i/NmdN+R3cL1b2mqaLzJzGNlJfB0Z8BMvdp0eqpnP wwxBVAJe6f9oS7NO4PAaiiR5d310k4QRj0JMqFzc6aveaR4FSz5lAupQbBoU5Erm9Pdq kJARYjV5x/WjGdzo1SbL6Pe60awowmXoqwiMh7OdzNY3VwzBqd8mHvXFzUpMtleK9ywD WVIMh1cMnCFzdEtuhxE1u8hK+bzV6A9XPVXObhJxmHbu7Ym/DKcN6a4+paD+4nMf/TVa bs0MBqlli+h25T7E5uLdfonbF7uenrBz0MQ7Ia+FxZE2xKZZlr2JXuxqcNGxFAfZRdp2 PfZA== X-Forwarded-Encrypted: i=1; AJvYcCVosqDdCAaqmzgqNIi85If2iWoPUj0zuLW2V6+EUNDmdMCSkNexSP0ibTT5fYZDgvxQ8I42hCCTEfKiE8aaWvSw@lists.infradead.org X-Gm-Message-State: AOJu0YxqQRLjJR205FYzGu+1sO07Vszj+rNC6mUrp5In4p+pSTM9LrLq zLanYv64xBMiraj2oAdZlP9930qsU4K9/Ip4OoKDnGDaYBP4DRJiat7hULLr4g== X-Google-Smtp-Source: AGHT+IEOdJrCawaHpKf+RauJKcw0b+JnkybZXuZ8BcDrpMdner6dqxfzlp6iHTXNerTNdqRm7x4xqg== X-Received: by 2002:a05:6a00:188f:b0:714:2198:26b9 with SMTP id d2e1a72fcca58-71e37e982camr8122107b3a.13.1728713333711; Fri, 11 Oct 2024 23:08:53 -0700 (PDT) Received: from thinkpad ([220.158.156.122]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e474889a8sm1454250b3a.29.2024.10.11.23.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 23:08:53 -0700 (PDT) Date: Sat, 12 Oct 2024 11:38:47 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , "open list:PCIE DRIVER FOR ROCKCHIP" , "open list:PCIE DRIVER FOR ROCKCHIP" , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH v7 1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function Message-ID: <20241012060847.6teuutvy2u2es2qw@thinkpad> References: <20241012050611.1908-1-linux.amoon@gmail.com> <20241012050611.1908-2-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241012050611.1908-2-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_230854_976322_1B1190E3 X-CRM114-Status: GOOD ( 26.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 10:36:03AM +0530, Anand Moon wrote: > Refactor the clock handling in the Rockchip PCIe driver, > introducing a more robust and efficient method for enabling and > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, I think I mentioned earlier to use impreative tone in commit messages. > the clock handling for the core clocks becomes much simpler. > Could you please elaborate how? i.e., devm_clk_bulk_get_all() allows the driver to get all clocks defined in the DT thereby removing the hardcoded clock names in the driver. > - Replace devm_clk_get() with devm_clk_bulk_get_all(). > - Replace clk_prepare_enable() with clk_bulk_prepare_enable(). > - Replace clk_disable_unprepare() with clk_bulk_disable_unprepare(). > > Signed-off-by: Anand Moon With above changes, Reviewed-by: Manivannan Sadhasivam - Mani > --- > v7: Update the functional change in commmit message. > v6: None. > v5: switch to use use devm_clk_bulk_get_all()? gets rid of hardcoding the > clock names in driver. > v4: use dev_err_probe for error patch. > v3: Fix typo in commit message, dropped reported by. > v2: Fix compilation error reported by Intel test robot. > --- > drivers/pci/controller/pcie-rockchip.c | 65 +++----------------------- > drivers/pci/controller/pcie-rockchip.h | 7 ++- > 2 files changed, 10 insertions(+), 62 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index c07d7129f1c7..2777ef0cb599 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -127,29 +127,9 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) > "failed to get ep GPIO\n"); > } > > - rockchip->aclk_pcie = devm_clk_get(dev, "aclk"); > - if (IS_ERR(rockchip->aclk_pcie)) { > - dev_err(dev, "aclk clock not found\n"); > - return PTR_ERR(rockchip->aclk_pcie); > - } > - > - rockchip->aclk_perf_pcie = devm_clk_get(dev, "aclk-perf"); > - if (IS_ERR(rockchip->aclk_perf_pcie)) { > - dev_err(dev, "aclk_perf clock not found\n"); > - return PTR_ERR(rockchip->aclk_perf_pcie); > - } > - > - rockchip->hclk_pcie = devm_clk_get(dev, "hclk"); > - if (IS_ERR(rockchip->hclk_pcie)) { > - dev_err(dev, "hclk clock not found\n"); > - return PTR_ERR(rockchip->hclk_pcie); > - } > - > - rockchip->clk_pcie_pm = devm_clk_get(dev, "pm"); > - if (IS_ERR(rockchip->clk_pcie_pm)) { > - dev_err(dev, "pm clock not found\n"); > - return PTR_ERR(rockchip->clk_pcie_pm); > - } > + rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks); > + if (rockchip->num_clks < 0) > + return dev_err_probe(dev, err, "failed to get clocks\n"); > > return 0; > } > @@ -372,39 +352,11 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip) > struct device *dev = rockchip->dev; > int err; > > - err = clk_prepare_enable(rockchip->aclk_pcie); > - if (err) { > - dev_err(dev, "unable to enable aclk_pcie clock\n"); > - return err; > - } > - > - err = clk_prepare_enable(rockchip->aclk_perf_pcie); > - if (err) { > - dev_err(dev, "unable to enable aclk_perf_pcie clock\n"); > - goto err_aclk_perf_pcie; > - } > - > - err = clk_prepare_enable(rockchip->hclk_pcie); > - if (err) { > - dev_err(dev, "unable to enable hclk_pcie clock\n"); > - goto err_hclk_pcie; > - } > - > - err = clk_prepare_enable(rockchip->clk_pcie_pm); > - if (err) { > - dev_err(dev, "unable to enable clk_pcie_pm clock\n"); > - goto err_clk_pcie_pm; > - } > + err = clk_bulk_prepare_enable(rockchip->num_clks, rockchip->clks); > + if (err) > + return dev_err_probe(dev, err, "failed to enable clocks\n"); > > return 0; > - > -err_clk_pcie_pm: > - clk_disable_unprepare(rockchip->hclk_pcie); > -err_hclk_pcie: > - clk_disable_unprepare(rockchip->aclk_perf_pcie); > -err_aclk_perf_pcie: > - clk_disable_unprepare(rockchip->aclk_pcie); > - return err; > } > EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks); > > @@ -412,10 +364,7 @@ void rockchip_pcie_disable_clocks(void *data) > { > struct rockchip_pcie *rockchip = data; > > - clk_disable_unprepare(rockchip->clk_pcie_pm); > - clk_disable_unprepare(rockchip->hclk_pcie); > - clk_disable_unprepare(rockchip->aclk_perf_pcie); > - clk_disable_unprepare(rockchip->aclk_pcie); > + clk_bulk_disable_unprepare(rockchip->num_clks, rockchip->clks); > } > EXPORT_SYMBOL_GPL(rockchip_pcie_disable_clocks); > > diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h > index 6111de35f84c..bebab80c9553 100644 > --- a/drivers/pci/controller/pcie-rockchip.h > +++ b/drivers/pci/controller/pcie-rockchip.h > @@ -11,6 +11,7 @@ > #ifndef _PCIE_ROCKCHIP_H > #define _PCIE_ROCKCHIP_H > > +#include > #include > #include > #include > @@ -299,10 +300,8 @@ struct rockchip_pcie { > struct reset_control *pm_rst; > struct reset_control *aclk_rst; > struct reset_control *pclk_rst; > - struct clk *aclk_pcie; > - struct clk *aclk_perf_pcie; > - struct clk *hclk_pcie; > - struct clk *clk_pcie_pm; > + struct clk_bulk_data *clks; > + int num_clks; > struct regulator *vpcie12v; /* 12V power supply */ > struct regulator *vpcie3v3; /* 3.3V power supply */ > struct regulator *vpcie1v8; /* 1.8V power supply */ > -- > 2.44.0 > -- மணிவண்ணன் சதாசிவம்