From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BD55D1A431 for ; Sat, 12 Oct 2024 06:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L0zqzAhZZVC6sbBIGKcvUCuXRGhVE6bE7pX/LBTwZjg=; b=KYrl/5nOSiLkvSPzT+L/oyGUN3 AOIRFbBHKQGZAJuFDqsiak2XCOFRTapI9+u6weK9u6FpTkkFvOiw8cy92e9pH4KFusI9dEJ741JZ9 +grir8liLawtCFM0WTBx+Brv3VnT6j2nNCsr+mIfn46ummOYdaFkMfw3AqtDpEQsS1hAbGgtlnPRa 95WrN8rAurZ9m2b1Pnflpa8oGyVjbmaFSGW4FQ2NQLX3zBad/+35Oiv/FD9SIkrvBts1o5vMosOpJ trpqMH+3MaOBb+JWxmImUoQnPutu61BZuIIvpSpVcfGmZzyM+Q+6y1v0EFN1+GCPXnnbouG7tMfVG XPQ3Nybw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szVUk-00000000d4b-1X9Y; Sat, 12 Oct 2024 06:20:54 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szVSa-00000000crb-1RNy for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 06:18:42 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-7db1f13b14aso2281523a12.1 for ; Fri, 11 Oct 2024 23:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728713919; x=1729318719; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=L0zqzAhZZVC6sbBIGKcvUCuXRGhVE6bE7pX/LBTwZjg=; b=RdNnGq3yVWBfhWh87vHfl33ZpoCRju9/Lo9+QDcvGtQnPc51rNP74BgGOUFEZE0Kpw STEO7Uh4fg1Na3ZLlaqFHMjCZqe7vM0L3covdPJkfKOEnwRCeKz3Q5z0zkOt6KWt29C9 ADHsDHIWlvdjrkeix9nwIftgW4CIwDNz0wdykEdJWhrs64IE/aHN4ZgJICMGyWHfwt2D tkou+uj0eV3odbQJDeUF3i2apnF5ho+CJtJyzJP8tmLpbbLGDk7mvFJoxncJlGGsiQlf u8Y4lBKFk7xoaK0fJIwEiQ570jQ3DSujdMRYavrS6KY8sS0QU72IPXTZxChKq88MYmKQ RjiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728713919; x=1729318719; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L0zqzAhZZVC6sbBIGKcvUCuXRGhVE6bE7pX/LBTwZjg=; b=OwURFLpjzpq+ozqDzyYl7BmvvEWi7JzfnH+xzbYIa01O7E8THAxph4BlrugHUWsgAn c84Tclmnaj/+Ri40pORgROtGfTmg4LfyJ274dr/XTdZOngGyujMUryDUScWh2tTC133D ABsMBwqk6YYzlGkVychFvfAKG+FEIxpFiwP4IUd7/M8wkEfKWx4uMj3BgZTuuD4liwQL YPulMlb/gsydu9pVhg3BDVqBZO+7wqTWFNtLwvCoQdf1ggc19J9GAIMbaiIQg2kniVOg NnoJYnX+n6bkqLovJ0aOlzXVYI5H8Qecqxl2quiW4H7DAQouNG9ZaYSsqlw8qA8qQfez LY5w== X-Forwarded-Encrypted: i=1; AJvYcCULfm+O00z50zG3CMSb0RnF2AvDuS4AkwoBnIhpEL3iK9s8HhuBc76cfECxALZYV02OTuPkRFtIcAyhpeO4cgID@lists.infradead.org X-Gm-Message-State: AOJu0YzMlzH+1JhawgSrk8nbmrR9cLsGFdcrdu2Z+eeUeqhKgwj+OjIh oo6t22UOEbhfJCZ52QCO75qX4dBrpcJAC+67DwHP5hkWWtK52YhFu6ZibRJ9yA== X-Google-Smtp-Source: AGHT+IF27/xVzp5EIA//SfiQ9fpAegP+0cn68oU11c0gnNhVwSd+ux7I7X/VZZO+jOqHNNBZJ8cLLQ== X-Received: by 2002:a05:6a21:2d89:b0:1cf:2a35:6d21 with SMTP id adf61e73a8af0-1d8bcfb3cf1mr8403778637.45.1728713919188; Fri, 11 Oct 2024 23:18:39 -0700 (PDT) Received: from thinkpad ([220.158.156.122]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2ab0b661sm3596531b3a.191.2024.10.11.23.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 23:18:38 -0700 (PDT) Date: Sat, 12 Oct 2024 11:48:34 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , "open list:PCIE DRIVER FOR ROCKCHIP" , "open list:PCIE DRIVER FOR ROCKCHIP" , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH v7 2/3] PCI: rockchip: Simplify reset control handling by using reset_control_bulk*() function Message-ID: <20241012061834.ksbtcaw3c7iacnye@thinkpad> References: <20241012050611.1908-1-linux.amoon@gmail.com> <20241012050611.1908-3-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241012050611.1908-3-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_231840_414405_CC6677EA X-CRM114-Status: GOOD ( 24.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 10:36:04AM +0530, Anand Moon wrote: > Refactor the reset control handling in the Rockchip PCIe driver, > introducing a more robust and efficient method for assert and > deassert reset controller using reset_control_bulk*() API. Using the > reset_control_bulk APIs, the reset handling for the core clocks reset > unit becomes much simpler. > Same comments as previous patch. > Spilt the reset controller in two groups as pre the RK3399 TRM. *per Also please state the TRM name and section for reference. > After power up, the software driver should de-assert the reset of PCIe PHY, > then wait the PLL locked by polling the status, if PLL > has locked, then can de-assert the reset simultaneously > driver need to De-assert the reset pins simultionaly. > > PIPE_RESET_N/MGMT_STICKY_RESET_N/MGMT_RESET_N/RESET_N. > > - replace devm_reset_control_get_exclusive() with > devm_reset_control_bulk_get_exclusive(). > - replace reset_control_assert with > reset_control_bulk_assert(). > - replace reset_control_deassert with > reset_control_bulk_deassert(). > > Signed-off-by: Anand Moon > --- > v7: replace devm_reset_control_bulk_get_optional_exclusive() > with devm_reset_control_bulk_get_exclusive() > update the functional changes. > V6: Add reason for the split of the RESET pins. > v5: Fix the De-assert reset core as per the TRM > De-assert the PIPE_RESET_N/MGMT_STICKY_RESET_N/MGMT_RESET_N/RESET_N > simultaneously. > v4: use dev_err_probe in error path. > v3: Fix typo in commit message, dropped reported by. > v2: Fix compilation error reported by Intel test robot > fixed checkpatch warning. > --- > drivers/pci/controller/pcie-rockchip.c | 151 +++++-------------------- > drivers/pci/controller/pcie-rockchip.h | 26 +++-- > 2 files changed, 49 insertions(+), 128 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index 2777ef0cb599..9a118e2b8cbd 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -30,7 +30,7 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) [...] > + err = reset_control_bulk_assert(ROCKCHIP_NUM_PM_RSTS, > + rockchip->pm_rsts); > + if (err) > + return dev_err_probe(dev, err, "reset bulk assert pm reset\n"); 'Couldn't assert PM resets' > > for (i = 0; i < MAX_LANE_NUM; i++) { > err = phy_init(rockchip->phys[i]); > @@ -173,47 +128,17 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip) > } > } > > - err = reset_control_assert(rockchip->core_rst); > - if (err) { > - dev_err(dev, "assert core_rst err %d\n", err); > - goto err_exit_phy; > - } > - > - err = reset_control_assert(rockchip->mgmt_rst); > - if (err) { > - dev_err(dev, "assert mgmt_rst err %d\n", err); > - goto err_exit_phy; > - } > - > - err = reset_control_assert(rockchip->mgmt_sticky_rst); > - if (err) { > - dev_err(dev, "assert mgmt_sticky_rst err %d\n", err); > - goto err_exit_phy; > - } > - > - err = reset_control_assert(rockchip->pipe_rst); > - if (err) { > - dev_err(dev, "assert pipe_rst err %d\n", err); > - goto err_exit_phy; > - } > + err = reset_control_bulk_assert(ROCKCHIP_NUM_CORE_RSTS, > + rockchip->core_rsts); > + if (err) > + return dev_err_probe(dev, err, "reset bulk assert core reset\n"); 'Couldn't assert Core resets' > > udelay(10); > > - err = reset_control_deassert(rockchip->pm_rst); > - if (err) { > - dev_err(dev, "deassert pm_rst err %d\n", err); > - goto err_exit_phy; > - } > - > - err = reset_control_deassert(rockchip->aclk_rst); > + err = reset_control_bulk_deassert(ROCKCHIP_NUM_PM_RSTS, > + rockchip->pm_rsts); > if (err) { > - dev_err(dev, "deassert aclk_rst err %d\n", err); > - goto err_exit_phy; > - } > - > - err = reset_control_deassert(rockchip->pclk_rst); > - if (err) { > - dev_err(dev, "deassert pclk_rst err %d\n", err); > + dev_err(dev, "reset bulk deassert pm err %d\n", err); 'Couldn't deassert PM resets' > goto err_exit_phy; > } > > @@ -256,31 +181,15 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip) > * Please don't reorder the deassert sequence of the following > * four reset pins. I don't think my earlier comment on this addressed. Why are you changing the reset order? Why can't you have the resets in below (older) order? static const char * const rockchip_pci_core_rsts[] = { mgmt-sticky", "core", "mgmt", "pipe", }; Also, this comment should be removed now. > */ > - err = reset_control_deassert(rockchip->mgmt_sticky_rst); > - if (err) { > - dev_err(dev, "deassert mgmt_sticky_rst err %d\n", err); > - goto err_power_off_phy; > - } > - > - err = reset_control_deassert(rockchip->core_rst); > + err = reset_control_bulk_deassert(ROCKCHIP_NUM_CORE_RSTS, > + rockchip->core_rsts); > if (err) { > - dev_err(dev, "deassert core_rst err %d\n", err); > - goto err_power_off_phy; > - } > - > - err = reset_control_deassert(rockchip->mgmt_rst); > - if (err) { > - dev_err(dev, "deassert mgmt_rst err %d\n", err); > - goto err_power_off_phy; > - } > - > - err = reset_control_deassert(rockchip->pipe_rst); > - if (err) { > - dev_err(dev, "deassert pipe_rst err %d\n", err); > + dev_err(dev, "reset bulk deassert core err %d\n", err); 'Couldn't deassert Core resets' - Mani -- மணிவண்ணன் சதாசிவம்