From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C827FD1A431 for ; Sat, 12 Oct 2024 06:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vvc97tx45kd3GdJFZQqd4tuk2ye7G9u+HV8rsNF8eb8=; b=iPg3R+27IpGuFXs3aZOdsXMaVf YtnYgZAYgggdD2tEEtYrziIVRXu+tbWyk2IgdUcZyRtMa9NRRfXZLRlAMkhTRxr5gaCkXF73R8dMj 8HFasADo0u9XPfRgefheBa8A+pOS3p7H8+pvT/8S2hgog7CSIHfV2Lcdr8kPdViTwB2k36MAMHF+o TqzB85aMcl1qNvVtsiBz81qtMU2WvpD0zjz20GQAogJte/Y11vJzRhJduyzdogb+ONJgvU95usOFf 5dUUuQuUu9xdrFovYNjyHVyopMIEwqMNByMoLP9gmu3WlFRlRoebF6DDLIZeceFtonq9GrClTkE6P 3tRFXJ2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szVW5-00000000dBZ-1iyK; Sat, 12 Oct 2024 06:22:17 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szVUV-00000000d2K-1zbD for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 06:20:41 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20ca388d242so9915135ad.2 for ; Fri, 11 Oct 2024 23:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728714038; x=1729318838; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Vvc97tx45kd3GdJFZQqd4tuk2ye7G9u+HV8rsNF8eb8=; b=ty3bAX5bWE33ejnyuLGle8dKQH/bcP4KR80P4YxVzYc1GPQIctB5eUDSE8BXz86WQG qKiDh+CYVMTHx/uZD7kSya//NFrjJ0gaDo6E/15nilrJUREAzjpDNHJP5vOyuTUzIlJc L+hbWTQSawx+m5ypeuAIpf08qB/HInJ5Lte9bzm7eq53rZsbZuWGqe1qEiDPozSAo76v fbPzrDfTbO2X37SoQTMEellYImsruAuBn0iabdI73rdM16YvZz98xEI1ZqODKwS0C7ux EngjyqhWVur3BkYJsKhHl9EIvE7ckCSiySrYWHUaa7UDX7dn6iLpxVY7U+EG1tr8lECC hPiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728714038; x=1729318838; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vvc97tx45kd3GdJFZQqd4tuk2ye7G9u+HV8rsNF8eb8=; b=fFDLcJ3U+VA4cE8GpfwqObu5XeHxjEI0DoBPyKwLMU8ArsdLt/9Bjf0fHRVCwrL8l1 o5E6gH8GjstW4w7w+i7hwDpoyjdwegOZu2d5qC2xjydUP8cOoc/Kef4x29raUcuhtYjq 252fXzpZGLt6CoelmFv3Tgce+R1ZfvMXv0RK1oBs3lZFsD/E3Lxhvs46DvJapyWgkILR LMgF/GfADFUpeJtPfdPpo24n63oz3tYg+/y/kTUEQ4zm8LirLPVSIahLsdIp/YbjmCmP O7SlLEDbNVaj3wEe6CwLniLKcwCWmjRwo288tMwTbtBt+VGDBL+mfGNQc6MCoYhzesQ8 oFfg== X-Forwarded-Encrypted: i=1; AJvYcCUd6uQbUwrUmjO6pOvfEF7h2m6UqjpfvA/NRn6mpkv3atMk3GpWAbca8aNy387VO2ax9KT15NeIsjejLJqZvGCA@lists.infradead.org X-Gm-Message-State: AOJu0YyuJo9+eP0ZRjHPUSBnr94eBklmh6xsM3p9KpRkLABVpn6DP1qP 5jdkVPhY/CNEq9HB/qvxucIOaAoXeB7i3N2HDQoLUg1J4gpZmeE3zWAcYcEJ+Q== X-Google-Smtp-Source: AGHT+IE9MibCsUxYlp5xvQC7TUKij7uDrYwOeTEXKfHPdmVzk+hiCpUdru94Jk7kYya9WtbYeISqmQ== X-Received: by 2002:a17:902:dad2:b0:20c:7be3:2832 with SMTP id d9443c01a7336-20cbb1ae2f7mr24955435ad.31.1728714038373; Fri, 11 Oct 2024 23:20:38 -0700 (PDT) Received: from thinkpad ([220.158.156.122]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c8bc3cea4sm32451225ad.115.2024.10.11.23.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 23:20:37 -0700 (PDT) Date: Sat, 12 Oct 2024 11:50:33 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , "open list:PCIE DRIVER FOR ROCKCHIP" , "open list:PCIE DRIVER FOR ROCKCHIP" , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH v7 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks() function signature Message-ID: <20241012062033.2w7jbfiptvdlklzl@thinkpad> References: <20241012050611.1908-1-linux.amoon@gmail.com> <20241012050611.1908-4-linux.amoon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241012050611.1908-4-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_232039_587730_9B65B630 X-CRM114-Status: GOOD ( 18.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 10:36:05AM +0530, Anand Moon wrote: > Refactor the rockchip_pcie_disable_clocks function to accept a > struct rockchip_pcie pointer instead of a void pointer. This change > improves type safety and code readability by explicitly specifying > the expected data type. > > Reviewed-by: Manivannan Sadhasivam > Signed-off-by: Anand Moon > --- > v7: None > v6: Fix the subject, add the missing () in the function name. Did you remove it in v7? Please don't do that, it just increases the burden on reviewers. - Mani > v5: Fix the commit message and add r-b Manivannan. > v4: None > v3: None > v2: No > --- > drivers/pci/controller/pcie-rockchip.c | 3 +-- > drivers/pci/controller/pcie-rockchip.h | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c > index 9a118e2b8cbd..c3147111f1a7 100644 > --- a/drivers/pci/controller/pcie-rockchip.c > +++ b/drivers/pci/controller/pcie-rockchip.c > @@ -269,9 +269,8 @@ int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip) > } > EXPORT_SYMBOL_GPL(rockchip_pcie_enable_clocks); > > -void rockchip_pcie_disable_clocks(void *data) > +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip) > { > - struct rockchip_pcie *rockchip = data; > > clk_bulk_disable_unprepare(rockchip->num_clks, rockchip->clks); > } > diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controller/pcie-rockchip.h > index 2761699f670b..7f0f938e9195 100644 > --- a/drivers/pci/controller/pcie-rockchip.h > +++ b/drivers/pci/controller/pcie-rockchip.h > @@ -347,7 +347,7 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rockchip); > int rockchip_pcie_get_phys(struct rockchip_pcie *rockchip); > void rockchip_pcie_deinit_phys(struct rockchip_pcie *rockchip); > int rockchip_pcie_enable_clocks(struct rockchip_pcie *rockchip); > -void rockchip_pcie_disable_clocks(void *data); > +void rockchip_pcie_disable_clocks(struct rockchip_pcie *rockchip); > void rockchip_pcie_cfg_configuration_accesses( > struct rockchip_pcie *rockchip, u32 type); > > -- > 2.44.0 > -- மணிவண்ணன் சதாசிவம்