From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36F71D1A44B for ; Sat, 12 Oct 2024 08:04:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wZqk1gpDcpLbh6iDyY6xdY16qjHfIm4cSq6P6zQlQhI=; b=Mro1NkoiiL6qBbR8kMtEbczMx6 JjNNCczJ+1nc0ittVJ0y8555rDphyHp36RnxJp34tkJW4youlQpLdT9HV1Dlu/CwOEobn5XKwL1Bg 0uH99peGQzElNLL952DyKzo2wc+M0dDGh8lHEDAOE8rTNhDlUdrnBpLy4leFTo4altcze8vnC+KGy BWAUkA2P/uX3yks5+CcgdkLwWTLBNliRJTDy1IZIq4XKHX7CPRLg1S+ZXWZAuH4qcWkqoYWfDqVU7 tqXKQ5u0fNtBMl5CtTx3YrVnhSQUz/4vt2Prl+01fsK6o9LvCNsXXyRgHFhyHbIMguCeIDeQ9g38s QDUKH8/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szX7K-00000000nkJ-2Hsn; Sat, 12 Oct 2024 08:04:50 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szX4u-00000000nSV-1eQH for linux-arm-kernel@lists.infradead.org; Sat, 12 Oct 2024 08:02:21 +0000 Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-7ea06275ef2so1901814a12.0 for ; Sat, 12 Oct 2024 01:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728720139; x=1729324939; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=wZqk1gpDcpLbh6iDyY6xdY16qjHfIm4cSq6P6zQlQhI=; b=KY8aE5twJqdaE1It4U3DdlWFLqfpxZPinF5PqUAbEsPyD8xEsjaHFCSxj0WyMUqC7K VwQOysY6xliRaCFkrucYNLIrgDFJGsY4x+KzYMZP1OXUIEDI1dI0iULyeGdfgsU+/IJj 88Yv6+L/43tDdbRMSJIyfvAiyyRX3n/BhQFjilx+xc5pgwfw3XUcQaRJvE0chrQODS0z Gb8k/CHKnFa4ifEqa4Yi8Hsb4ulsa7h1CgNm+1dzi5/Gb5Bpk9ZvWoB3mGeRqPVAgIMa /uv0GF1KMuBBN9G+Qr8wIQCnGmSNJ7faxUMP9iepuOSW+V8Xp5nAQnRp9tZUCavscyGP p1+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728720139; x=1729324939; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wZqk1gpDcpLbh6iDyY6xdY16qjHfIm4cSq6P6zQlQhI=; b=D/+/Vg88TPCzvKI2J5AkbTErLTFsQd9O1Xp+V9tUdythJBHvdtv6SKA3F+I81QJrKG XmJ5sxpH5NDsdoYvu1Nqx1Zfy8RL9CdhkE3ZM4sOx9Nzg6oHvClXyEt3h4QtSCjohBXE IpHzIJH1fi4oASEsMiWoKMh9e+DTeXABW4VJ7Rpa0DpeFvg5OzWqsGHZchSofGWoDLn8 RpGO9zq34hvaVXK9Hro5z9bORvW9nA8XG+r1cVrMcJ4fQywXNynEq+1MKgx5y6o+fnuF 51p9twxq+PsSisXDhVxvrdA/3Y3Pw1tYZo5L3f8PT/xP30poIqNNfXNoJfaeqTFFEjLp 0mKw== X-Forwarded-Encrypted: i=1; AJvYcCWo86d4oCIRnJvaDaKg1sw9PrRkx7fNLYGaFHFCPoOwSQlK0+bUUg7c7U3iTnxI4vhnI3eI/25ILqI/ARNApMqS@lists.infradead.org X-Gm-Message-State: AOJu0YxvywmT00fsmv7IadiXsTfCwHv7TPVu/GpF53jxdq/i822F5i76 CCla5mp3luqS9bI3/wa3WNAx42gS69b6maezAuTEB36xzqbl/jO4jAa1OnEVqg== X-Google-Smtp-Source: AGHT+IGoErZ1DMvXi7PdOjqOtgBagJx8Ivw1+HU2C6hiM6DJX1nWFZSKvbxbRddh3deh5/zJxscDyg== X-Received: by 2002:a17:90b:1495:b0:2e2:e6c8:36a7 with SMTP id 98e67ed59e1d1-2e31536e312mr2565945a91.31.1728720139502; Sat, 12 Oct 2024 01:02:19 -0700 (PDT) Received: from thinkpad ([220.158.156.122]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e31af38baasm869855a91.41.2024.10.12.01.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Oct 2024 01:02:19 -0700 (PDT) Date: Sat, 12 Oct 2024 13:32:13 +0530 From: Manivannan Sadhasivam To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , "open list:PCIE DRIVER FOR ROCKCHIP" , "open list:PCIE DRIVER FOR ROCKCHIP" , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH v7 3/3] PCI: rockchip: Refactor rockchip_pcie_disable_clocks() function signature Message-ID: <20241012080213.rxllcpofy2at5vnz@thinkpad> References: <20241012050611.1908-1-linux.amoon@gmail.com> <20241012050611.1908-4-linux.amoon@gmail.com> <20241012062033.2w7jbfiptvdlklzl@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241012_010220_464077_47C281D6 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Oct 12, 2024 at 12:55:38PM +0530, Anand Moon wrote: > Hi Manivannan, > > Thanks for your review comments. > > On Sat, 12 Oct 2024 at 11:50, Manivannan Sadhasivam > wrote: > > > > On Sat, Oct 12, 2024 at 10:36:05AM +0530, Anand Moon wrote: > > > Refactor the rockchip_pcie_disable_clocks function to accept a > > > struct rockchip_pcie pointer instead of a void pointer. This change > > > improves type safety and code readability by explicitly specifying > > > the expected data type. > > > > > > Reviewed-by: Manivannan Sadhasivam > > > Signed-off-by: Anand Moon > > > --- > > > v7: None > > > v6: Fix the subject, add the missing () in the function name. > > > > Did you remove it in v7? Please don't do that, it just increases the burden on > > reviewers. > > > > - Mani > Earlier, it was reported that function () should be used in the function name. Hmm. Why can't you do the same for the description also? - Mani -- மணிவண்ணன் சதாசிவம்