From: Will Deacon <will@kernel.org>
To: Ryo Takakura <ryotkkr98@gmail.com>
Cc: catalin.marinas@arm.com, broonie@kernel.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: Remove the check for CONFIG_TINY_RCU
Date: Mon, 14 Oct 2024 14:10:43 +0100 [thread overview]
Message-ID: <20241014131042.GA17353@willie-the-truck> (raw)
In-Reply-To: <20240914090040.166671-1-ryotkkr98@gmail.com>
On Sat, Sep 14, 2024 at 06:00:40PM +0900, Ryo Takakura wrote:
> Since the commit 4b3dc9679cf77 ("arm64: force CONFIG_SMP=y and remove
> redundant #ifdefs"), arm64 defaults to CONFIG_SMP but TINY_RCU is cofigured
> only for !SMP systems.
>
> Remove the check for CONFIG_TINY_RCU as it should always be false.
>
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
> ---
> arch/arm64/kernel/entry-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
> index b77a15955f28..a9765364fc67 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -40,7 +40,7 @@ static __always_inline void __enter_from_kernel_mode(struct pt_regs *regs)
> {
> regs->exit_rcu = false;
>
> - if (!IS_ENABLED(CONFIG_TINY_RCU) && is_idle_task(current)) {
> + if (is_idle_task(current)) {
> lockdep_hardirqs_off(CALLER_ADDR0);
> ct_irq_enter();
> trace_hardirqs_off_finish();
I think this code was deliberately written to follow kernel/entry/common.c
as closely as possible, as we should be able to switch over to that at
some point.
Come to think of it, Mark, what work is needed before we can move to the
generic code? Is there anything you need a hand with?
Will
next prev parent reply other threads:[~2024-10-14 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 9:00 [PATCH] arm64: Remove the check for CONFIG_TINY_RCU Ryo Takakura
2024-10-14 13:10 ` Will Deacon [this message]
2024-10-15 10:08 ` Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014131042.GA17353@willie-the-truck \
--to=will@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ryotkkr98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox