From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A281D16274 for ; Mon, 14 Oct 2024 14:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vw4K6FS8SbC+3FBSba9ckVMNrGSAbE7YLTr7+1mDY9U=; b=u+bcKb3xX4CQ13jvg+dPJZhTYG Xg6wDCE2JCo38U6jD4FiUR9vC9ua4Z9zbYFU8BNd/u5UD1XxW4f+t6HgNzLibJacutOMoCb06l3q9 T2xogDFUFShfDHtEnbS6o1imHHOFb5fZSLU0mfIei5jev+2bwa4YA/r5p019Q6dq35sovFAh7wKw0 9iM+W/moPOwwvZgt7tUwx+ATTUohQUtF9BksSpiFNo6H/EsuL34EUcVZz/DeCl86nim/llUccE5/X fL8zga4CtokYwRN/iqP9QEae6669qFRkxXDYdydsfUVWBScroIhhNItMT8WXhsbRLf2bb0Mx/lK/+ RhHdtWXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0Lo3-00000005QdR-0pu2; Mon, 14 Oct 2024 14:12:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0Kyk-00000005EXZ-3xTp for linux-arm-kernel@bombadil.infradead.org; Mon, 14 Oct 2024 13:19:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vw4K6FS8SbC+3FBSba9ckVMNrGSAbE7YLTr7+1mDY9U=; b=fvGBuF2SI2Qq2Rcc7Wgc/37cFV FxMpEpsorPKNN0LaFC6TwHp8TsmrkkfL+nVEPKPIBWcVQ4K0MVPJZOo2Y8Gx+AjOOdvNiTODwNLei qFDc1zuZxhJdjnCHUupll4TdBu55qNmIsSscEkBOaaQdXp3r8qcx5S6AYIme8JMytdXPyX97opNSi NwsR5V08kmLtvpoQ7UFgLJ2mPSbykVQStTjcpOtodCmYskfI/DJ5vMdTdMn6HVmmEyfR936pH06Nz b/MWTD4fRr7HdJwDUsnvpFkvgLUzN+Q8lf13xZAj+31CDybMmGDxMJiREVUEC3//dmrCVqfLqfJBV fGa0QPOA==; Received: from dfw.source.kernel.org ([139.178.84.217]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0Kyh-00000006Lpf-2RB3 for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 13:19:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 352795C0C37; Mon, 14 Oct 2024 13:19:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE49AC4CEC3; Mon, 14 Oct 2024 13:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728911952; bh=JGKigdVvMLsH2/kU1hL1nsXpEbmGXTAgoSDJw55UxFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T/nqCKst6pRIAcqnLe5hg1LCOMvlRlgtGoK2rWQ4Y66VzJxqxE0MfNlzlvHmf4Hgw ZkBtQ62j/ZXvye5sipLr6CG2kOfxTBf85xCy6z9LkVCzVo72C3qxMtntZhgr2mff6A EtUF+SoB4WqpSkdr24eYLBldbSYerikp3iDx3Jzf5BXA2SFq33j7ewyFogaKUo588s UsWlFZFTCiYtjEFWQDwhRvdX7TFGOI6ddJ5rNOsUo6tqqrwiHyJZg45yS0nYMrVajO mvG+oC/kI4F7gmDbE3mDLRa8Je+xz0uy+GeRfV4M2nCMLgsuS0q4tITOkCz9q47JgV K4144lBtC8oUw== Date: Mon, 14 Oct 2024 14:19:06 +0100 From: Will Deacon To: Besar Wicaksono Cc: suzuki.poulose@arm.com, robin.murphy@arm.com, catalin.marinas@arm.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, treding@nvidia.com, jonathanh@nvidia.com, vsethi@nvidia.com, rwiley@nvidia.com, rknight@nvidia.com Subject: Re: [PATCH 2/3] perf: arm_cspmu: nvidia: update CNVLINK PMU events Message-ID: <20241014131903.GB17353@willie-the-truck> References: <20240918215846.1424282-1-bwicaksono@nvidia.com> <20240918215846.1424282-3-bwicaksono@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240918215846.1424282-3-bwicaksono@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_141915_893505_2E72C0B7 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 18, 2024 at 09:58:45PM +0000, Besar Wicaksono wrote: > Rename loc* and rem* events in CNVLINK PMU to cmem* and gmem* events. > > Signed-off-by: Besar Wicaksono > --- > drivers/perf/arm_cspmu/nvidia_cspmu.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/perf/arm_cspmu/nvidia_cspmu.c b/drivers/perf/arm_cspmu/nvidia_cspmu.c > index ea2d44adfa7c..d1cd9975e71a 100644 > --- a/drivers/perf/arm_cspmu/nvidia_cspmu.c > +++ b/drivers/perf/arm_cspmu/nvidia_cspmu.c > @@ -112,6 +112,25 @@ static struct attribute *mcf_pmu_event_attrs[] = { > NULL, > }; > > +static struct attribute *mcf_cnvlink_pmu_event_attrs[] = { > + ARM_CSPMU_EVENT_ATTR(rd_bytes_cmem, 0x0), > + ARM_CSPMU_EVENT_ATTR(rd_bytes_gmem, 0x1), > + ARM_CSPMU_EVENT_ATTR(wr_bytes_cmem, 0x2), > + ARM_CSPMU_EVENT_ATTR(wr_bytes_gmem, 0x3), > + ARM_CSPMU_EVENT_ATTR(total_bytes_cmem, 0x4), > + ARM_CSPMU_EVENT_ATTR(total_bytes_gmem, 0x5), > + ARM_CSPMU_EVENT_ATTR(rd_req_cmem, 0x6), > + ARM_CSPMU_EVENT_ATTR(rd_req_gmem, 0x7), > + ARM_CSPMU_EVENT_ATTR(wr_req_cmem, 0x8), > + ARM_CSPMU_EVENT_ATTR(wr_req_gmem, 0x9), > + ARM_CSPMU_EVENT_ATTR(total_req_cmem, 0xa), > + ARM_CSPMU_EVENT_ATTR(total_req_gmem, 0xb), > + ARM_CSPMU_EVENT_ATTR(rd_cum_outs_cmem, 0xc), > + ARM_CSPMU_EVENT_ATTR(rd_cum_outs_gmem, 0xd), > + ARM_CSPMU_EVENT_ATTR(cycles, ARM_CSPMU_EVT_CYCLES_DEFAULT), > + NULL, > +}; > + > static struct attribute *generic_pmu_event_attrs[] = { > ARM_CSPMU_EVENT_ATTR(cycles, ARM_CSPMU_EVT_CYCLES_DEFAULT), > NULL, > @@ -234,7 +253,7 @@ static const struct nv_cspmu_match nv_cspmu_match[] = { > .filter_default_val = NV_CNVL_FILTER_ID_MASK, > .name_pattern = "nvidia_cnvlink_pmu_%u", > .name_fmt = NAME_FMT_SOCKET, > - .event_attr = mcf_pmu_event_attrs, > + .event_attr = mcf_cnvlink_pmu_event_attrs, > .format_attr = cnvlink_pmu_format_attrs > }, Hmm. Isn't this a user-visible change? For example, will scripts driving 'perf' with the old event names continue to work after this patch? Will