From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ED93D1812A for ; Mon, 14 Oct 2024 16:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NJQLSY61KBWw6RfxKIX8YmFJXnI1kRCs41jjR3HcYgk=; b=uh9QhxUslMnUGYZfRNQ+AcQUsE oEZNVOLWGZxwKE+kCYyKzrdtdcFV3D5RHZhbRYVvwH5YquJBwXTtPf682f8ZYaoui7FWSr1nJ4PAh RircKL52Z2PQrP0kISYLERE+/N5AqONPpqt9jMajANSxwn6WiW7n3BfqocnNBkKvPio61fkxuOr9Y gVJYOXvSu96ZjANEnfFd248z+r23i/WT/t1S1qknsC20S44Y2US0Vt/vbGEBQYSapr7UQH8Rotlel 7OaUlfuLXVxIj579IBIRuS4lRz8i4m7ppxnboNcCk7BCMoMt1dHTF5PJ8DZmKB+/858VJT18Ja37/ ua99OTNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0NbG-00000005nvi-0UYu; Mon, 14 Oct 2024 16:07:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0NZo-00000005nfP-2lD2 for linux-arm-kernel@lists.infradead.org; Mon, 14 Oct 2024 16:05:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C47775C5B05; Mon, 14 Oct 2024 16:05:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBC5FC4CEC3; Mon, 14 Oct 2024 16:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728921944; bh=FUNAbuY9VUcTA6rdkAbpB+TVHERbMMF8fyXegm8bPCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j0ky43CRdBYlLqSD4pVVStMEw9RnvSHgsyM+mNapUSvdEu/ji90zrTmNpCgUa+/TW MQCFkR8RwUq3+1YuP2fLMfqIiWQczdDyV9sLl8OIjfwXA3leapGA1AwCXwnOA4fpcb rmYf/t3h4stqk+7XYXpJ43hqU4dwo6vGosSn1F2dB4el0EuJKiHTosgz+viFwm4WFo TCt6H1gigkORIonvsjmDlDr7oeY0uF+6V79A5QHOUno4x28czobP7qKfNSwBZX2IC/ xTH/k05IsgQZRGBCoo9s7+2yaxbrJl39R38LfaqxNW0JVxnRdoqxSntopY6OF/A4qC 40Wvn6S5+iuGA== Date: Mon, 14 Oct 2024 17:05:39 +0100 From: Will Deacon To: Robin Murphy Cc: Mark Rutland , Ba Jing , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: arm-ccn: remove unused macros Message-ID: <20241014160539.GA17809@willie-the-truck> References: <20241012091629.2369-1-bajing@cmss.chinamobile.com> <24019386-6ecc-4715-9486-503ccc828113@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24019386-6ecc-4715-9486-503ccc828113@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_090544_761394_9FAF17FA X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2024 at 04:40:52PM +0100, Robin Murphy wrote: > On 14/10/2024 10:19 am, Mark Rutland wrote: > > On Sat, Oct 12, 2024 at 05:16:29PM +0800, Ba Jing wrote: > > > By reading the code, I found these marcos are never > > > referenced in the code. Just remove them. > > > > > > Signed-off-by: Ba Jing > > > > These are control bit values, so I don't see a strong reason to delete > > them unless we're certain we're not going to use them in future. > > > > Anyhow, Robin Murphy wrote this driver, so its up to him. Please Cc him > > for any changes to this driver in future. > > Er, this is CCN - FWIW I didn't claim this one, nor CCI, as supported in my > maintainers entry largely because active development on them has long > finished, but also because I *didn't* write them, so wouldn't claim to > understand them much better than you or Will do ;) > > However, I'd agree that there doesn't seem to be any significant benefit to > removing these (certainly showing at a glance that ALL_ERRORS_DISABLE is > composed equivalently to PMU_EVENTS_DISABLE seems like no bad thing.) Yup. FWIW, I wasn't intending to take any of the patches removing unused #defines in the PMU drivers. I'll pick the one removing an unused 'list_head', though, as that at least makes a structure a bit smaller. Will