From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F1BED18131 for ; Mon, 14 Oct 2024 17:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=kgO/2lNKY78OCEJdRzyKNvnoP2fxZOJlTf/xYGDUm28=; b=TTFDaW6ljnQ6vf Nb1Sk/Uolxp1iyKpv8fUDEBMS48nTSZTFEFe6HEzsjJT+hFrdg+LTbLTn8lF0XuLOCK1sWCpXyuSh IrQ3OuFkAgePZjZE5S0/xXapo2Jic1RwxhbIcCl+yrQtLE0T3GsrE6mOfTHbPOb4HAehOkNrTkdqP vDIuaVxiFzEkLHpnRfxS57gKKBcjtMVQPMwpAfeRTHL/9nfOHp1GXGtcdytaq1r8Wi5tDOaCs3mv6 JLz8RTtcloCZ0gsWxow2pf7Tof04MaUiAh1r7nxOCLU1FAFZK1y6C/aArBKGvAnwyOoML+N3brGlB QQRwCz4w65akmKIovwOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0OXD-00000005yYb-0Nee; Mon, 14 Oct 2024 17:07:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0OTL-00000005xj7-07H4; Mon, 14 Oct 2024 17:03:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0038D5C5B68; Mon, 14 Oct 2024 17:03:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB77C4CECF; Mon, 14 Oct 2024 17:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728925386; bh=7EBzx9TKWhfNLZhoOLG6+HPFV0q3qnPTqrLIobCq0yk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=liodWHvAXSwdRZ24OJzo6b6dLba0jDpqemmMj8zSUmIq9dn7iIj8+tA5c+NR4vtps lswpBORi48/kw9Bq0kYm+Jy4P4x2h6u0FoWoxesxIe/ylqM+s0Oryy5HSoYy4T/D12 GU8UAryRP7jazy4N4TIJv9IKn7EzsKbbwkHqsc6rwuIAwlqxto0MicNd8GGrg3oGpA dTlN1IWPy/GG0ZHiiUnj9JGrcfhO2/TAJhrOAK/ZqUcPPIGLPK0d4Om/Jom/m+sz9K 8/KRYAKSnh3nAdOc+yOIVZMQw5woos+TmB0LBTOLN948+VKJhJHmPCMNbt13R8cQMd Qnwe3bP0pa5SA== Date: Mon, 14 Oct 2024 12:03:03 -0500 From: Bjorn Helgaas To: Stanimir Varbanov Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Broadcom internal kernel review list , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Jim Quinlan , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , kw@linux.com, Philipp Zabel , Andrea della Porta , Phil Elwell , Jonathan Bell Subject: Re: [PATCH v3 08/11] PCI: brcmstb: Reuse config structure Message-ID: <20241014170303.GA611791@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014130710.413-9-svarbanov@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_100307_131612_5BB8C41F X-CRM114-Status: UNSURE ( 6.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2024 at 04:07:07PM +0300, Stanimir Varbanov wrote: > Instead of copying fields from pcie_cfg_data structure to > brcm_pcie reference it directly. This seems good. I would consider moving it earlier in the series so you don't have to touch the CFG_QUIRK_AVOID_BRIDGE_SHUTDOWN stuff twice. Bjorn