From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F886CFC273 for ; Tue, 15 Oct 2024 08:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UCWhCFC1nCnipKcYnROrt7/QHUQp4Uyi0FOnqd7XWdA=; b=bh2JNPIXwTnFJSK11U9DfxI6mF +bMfifflDScy4ACT1eNoJU+pWvhvf7CopMqM8cANovhKv4TLXaXIZz3pR5RP5mJrSAiyEd6q5Aeqv Mxxdc3hUaffUtFxnnUErPkM9AuIx135qPxQQNU8SNcpAWxokkC3LvsN11WM7ZI7hl8LkUWskyVM7y gGmJlJGvdIgLK0aLWduQ+9Bk6EdT0++sWvjN6x/rew/AiXfHKasdfabiQeinLOSXDrmXxVwvyXVA7 l6OrqGXybwy45VrCJOywOtAEWYvvH9d1cbfHDVXwekxRiG0mgWxMR+BAuwACpLJd3os4F2Bg9SqXH KMQkJROQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0cTm-00000007QFR-3kQd; Tue, 15 Oct 2024 08:00:30 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0bU3-00000007HVs-1Xjy for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 06:56:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1728975403; x=1760511403; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4Sj4pR4hDeqqU2JhHI+sXnxUm8jUqiCpTHuhpkV97O4=; b=2hL0BQAF+FKXuxRAWpfMiE8uiJEQaWyq6ZfK8UfyyhS93FDUuEZ4KqwM 6uedrr75rW9FJurMJHFnTEb8/5tKtgWflYcmk8ckLc4oIumhg6feOYV0i DYMyyACwSR/Kz5IGOWL7WiaERMXwuNlh0T+b+LYd1JRn8KhBW4r5/dz55 uHDdQ8XpeZd6VFUhVzfQPAq/VTVHub39EaPDZ84BSk81Uenfv3N7lDKRB vcS2joTlxZJLjpfh0/279lrVWCXCm5l2DYp23LG+1Ha00Vs9oNaLTamSw b8Sruj4lNJ+5R02QoG8h5LD/awsjL0cH3jidMKNFM656Vkcf2P6buFa8A w==; X-CSE-ConnectionGUID: XyjmHW/JQKad8t5tqwiT3A== X-CSE-MsgGUID: wlxq7VeBR3KD9OaaVPDVjA== X-IronPort-AV: E=Sophos;i="6.11,204,1725346800"; d="asc'?scan'208";a="33020112" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Oct 2024 23:56:42 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 14 Oct 2024 23:56:40 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 14 Oct 2024 23:56:39 -0700 Date: Tue, 15 Oct 2024 07:56:20 +0100 From: Conor Dooley To: Naresh Solanki CC: Andrew Jeffery , "Rob Herring (Arm)" , , Krzysztof Kozlowski , , , Joel Stanley , Conor Dooley , Subject: Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add IBM SBP1 board Message-ID: <20241015-portion-parish-4ca08647bb4c@wendy> References: <20241010112337.3840703-1-naresh.solanki@9elements.com> <172857036038.1533242.5775916298170949713.robh@kernel.org> <4d596ac9a2215be8510369c948e0b9680ee2fce3.camel@codeconstruct.com.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zgnNujWOZf5FzJWM" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_235643_441210_867B1DCF X-CRM114-Status: GOOD ( 25.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --zgnNujWOZf5FzJWM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 11, 2024 at 01:38:52PM +0530, Naresh Solanki wrote: > Hi Andrew, >=20 >=20 > On Fri, 11 Oct 2024 at 05:15, Andrew Jeffery > wrote: > > > > Hi Naresh, > > > > On Thu, 2024-10-10 at 09:30 -0500, Rob Herring (Arm) wrote: > > > On Thu, 10 Oct 2024 16:53:31 +0530, Naresh Solanki wrote: > > > > Document the new compatibles used on IBM SBP1. > > > > > > > > Signed-off-by: Naresh Solanki > > > > Acked-by: Conor Dooley > > > > --- > > > > Changes in V4: > > > > - Retain Acked-by from v2. > > > > - Fix alphabetic order > > > > --- > > > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > My bot found new DTB warnings on the .dts files added or changed in t= his > > > series. > > > > > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warni= ngs > > > are fixed by another series. Ultimately, it is up to the platform > > > maintainer whether these warnings are acceptable or not. No need to r= eply > > > unless the platform maintainer has comments. > > > > > > If you already ran DT checks and didn't see these error(s), then > > > make sure dt-schema is up to date: > > > > > > pip3 install dtschema --upgrade > > > > > > > > > New warnings running 'make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.= dtb' for 20241010112337.3840703-1-naresh.solanki@9elements.com: > > > > > > > ... > > > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mux@77: interrupts:= False schema does not allow [[44, 4]] > > > from schema $id: http://devicetree.org/schemas/i2c/i2c-mux-pca9= 54x.yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regu= lators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-c= pu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccf= a-cpu0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/trivial-devices.= yaml# > > > > These still must be addressed as mentioned on v3 (with more specific > > comments regarding the infineon,ir38263 on v4). Please look through the > > binding documents for the affected nodes and make sure the nodes in > > your DTS conform to their definitions. You can check your work with > > `make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.dtb` prior to sending. >=20 > These are the warnings coming for trivial devices. Even for regulator@5f >=20 > grep -rsn mp2973 Documentation/ > Documentation/devicetree/bindings/trivial-devices.yaml:286: > # Monolithic Power Systems Inc. multi-phase controller mp2973 > Documentation/devicetree/bindings/trivial-devices.yaml:287: - > mps,mp2973 It coming from trivial-devices.yaml means that the device does not actually qualify as a trivial device, but rather needs to be described in a binding of its own. --zgnNujWOZf5FzJWM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZw4SEwAKCRB4tDGHoIJi 0nIjAPwIEU8NPVESdU3NKkpEF0S/EBcc+8Exu+WbEkvqoq2nIAD+KK53TduJay6t 7wAqGuWhZfn8YbO16ghift7SX79yeg8= =Gv8+ -----END PGP SIGNATURE----- --zgnNujWOZf5FzJWM--