From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12B3BCFC285 for ; Tue, 15 Oct 2024 10:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PpvgnMomw0Uq56+eW9heIDg2o6H/iBcUs4/VOkLS8oc=; b=UYmc+KwQapgT/byt8fWxm/P7lA NZgblBmvpTo57CD/4sEmxjaLSzzj/l3o8BiabQHgQBinUvbaGaIC7FMJrASXpFZoQvNogiWssaGml 96mhLIav8R0nZ0PG1nlvVlQnHD1syprrMbH2caxW3rVthpxzFhX9Nzj1ZI6epoy5Lr0Z3ddU3VrSl jdXo6efPqYCKv24s2aM/szSooVwkgjzHlEFUTO/td8RqIhOFPfUk5xBLOwjX59yUVuEwD7tgIVI2f KgK5x4LERf/nz0cb4qI/PXjBCfX1gqknZNFRidSJzuwiMpz+lvE7AYzte06r5o/MPxQMtnWW2A1WR qiPek8dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0eXL-00000007miN-26o6; Tue, 15 Oct 2024 10:12:19 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0eTS-00000007m06-05Cz for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 10:08:19 +0000 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-8354845c5dcso222023939f.0 for ; Tue, 15 Oct 2024 03:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728986896; x=1729591696; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PpvgnMomw0Uq56+eW9heIDg2o6H/iBcUs4/VOkLS8oc=; b=U7DTjCf1goeNuhSjPErq6sPGV8G/9V6jfDadlKorRQ0q99XZb9xawUeTzoaN1XmXFy oVrMI9emrQTvLza7o4WrVF4ewDNazN0ZYXejWweHqYqw20d6sjNC2vpJXDFbGOHy0yk3 qrOhezPIp8xoy3E5GiTnJY1SiGwD9Ny94emObmBdNhlWzdUkR2FdEkgb0xq50wOhqxD5 SC7FVq/+vLnzEsbpFg2iQrBhaEPcTRFCbtGyPzhxJX5+QQaHFqajRrviaxYXn2BDmwcg eCsDAGs/cyMBDFIixxKAbZPCYH1Qh2OUWVIDPE+sasxYPJWgpqohBZAwChsNIOwVVjnW EptQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728986896; x=1729591696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PpvgnMomw0Uq56+eW9heIDg2o6H/iBcUs4/VOkLS8oc=; b=FPyGM4eo9hwMHhdLGs9Gg/VZF7oZJlvkEBppGzMtXCuRR1+bFlZCBpqB200HFFZc/e Ry5RMfaNXfkwPzLmXE3OFZyhC6gegRox8WtpHWO4n28w1w5+eZ/5PC+D57j8ng7MoRqD lGzYAcyCOVvehY7X4pq4Wys28I7f9xc85EzbE5biicHclDcyTnILTyGtM6qwW87afapW v/a/2fk3UWBRn6FdBKVL1mucGcsZ7Ki9mfzP/ADQ5ecfXbLuLSpQo9EmO/boze3N+4Cx s/4fuj8zWa0Ex+3xLsn9zwGSLDvNQTd9jd3ZFdYlcuxZk0eOJUIYoJG1ojEggCsjsDee BYzw== X-Forwarded-Encrypted: i=1; AJvYcCVKZNtpX4ZzxWCHkkVwmno541kKTny+9sB3vzumvsgxF9F86vjBSw3dnquqWaUOEIZ26XdySR9J0lHLCuYMLodQ@lists.infradead.org X-Gm-Message-State: AOJu0YxP2xyDR8aF+SAg+/LbRdW6VS/nZO21jLgRV0s7PHW8F40+SEW+ 3lF9LEdTQV+UixuZfORJELgtJIJS82cCaYsIPSoiT/TbfbjgaclO X-Google-Smtp-Source: AGHT+IE2DPjntaI4HEsSMYwUNRJ10+nrrbcsv/I0ULix1C0zQoZ3ELz+C4Gg6T4rh6U/IVcloMnjrw== X-Received: by 2002:a05:6602:1486:b0:82c:d744:2936 with SMTP id ca18e2360f4ac-8378f92ee97mr1440446739f.0.1728986896433; Tue, 15 Oct 2024 03:08:16 -0700 (PDT) Received: from DESKTOP-NBGHJ1C.local.valinux.co.jp (vagw.valinux.co.jp. [210.128.90.14]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83a8b28be7fsm23462739f.11.2024.10.15.03.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 03:08:15 -0700 (PDT) From: Ryo Takakura To: will@kernel.org Cc: broonie@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, ryotkkr98@gmail.com Subject: Re: [PATCH] arm64: Remove the check for CONFIG_TINY_RCU Date: Tue, 15 Oct 2024 19:08:09 +0900 Message-Id: <20241015100809.15581-1-ryotkkr98@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241014131042.GA17353@willie-the-truck> References: <20241014131042.GA17353@willie-the-truck> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_030818_106583_8E28BE83 X-CRM114-Status: GOOD ( 19.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Will, On 2024-10-14, Will Deacon wrote: >On Sat, Sep 14, 2024 at 06:00:40PM +0900, Ryo Takakura wrote: >> Since the commit 4b3dc9679cf77 ("arm64: force CONFIG_SMP=y and remove >> redundant #ifdefs"), arm64 defaults to CONFIG_SMP but TINY_RCU is cofigured >> only for !SMP systems. >> >> Remove the check for CONFIG_TINY_RCU as it should always be false. >> >> Signed-off-by: Ryo Takakura >> --- >> arch/arm64/kernel/entry-common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c >> index b77a15955f28..a9765364fc67 100644 >> --- a/arch/arm64/kernel/entry-common.c >> +++ b/arch/arm64/kernel/entry-common.c >> @@ -40,7 +40,7 @@ static __always_inline void __enter_from_kernel_mode(struct pt_regs *regs) >> { >> regs->exit_rcu = false; >> >> - if (!IS_ENABLED(CONFIG_TINY_RCU) && is_idle_task(current)) { >> + if (is_idle_task(current)) { >> lockdep_hardirqs_off(CALLER_ADDR0); >> ct_irq_enter(); >> trace_hardirqs_off_finish(); > >I think this code was deliberately written to follow kernel/entry/common.c >as closely as possible, as we should be able to switch over to that at >some point. Oh I see, thanks for taking a look at the patch! >Come to think of it, Mark, what work is needed before we can move to the >generic code? Is there anything you need a hand with? > >Will If there is anything I can be of help, let me know! Sincerely, Ryo Takakura