From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC1CD1D87B for ; Tue, 15 Oct 2024 15:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ClKe/KioyYjPhrBy/n0Jg+jjrJCcmgHV3R97QP+glyc=; b=v1EjYG9k6vx60X6bsX3ssbpCOS gWR4QtbuVK/Cyubh9FelwmVaIDMVR5KEvcq0XPWICRXw+rWPHggZMF2J0LPlFKWJo1IsPpHxptAOX dGWSe4er7Cj6t0m3RX3mSppVTCuNPjeIKmkSztqm5lYB55FiqSWbeCThzfDu5xR4LW2fyx4LjvO+G YdBWNMaP4sA0SxH9ir7vWYolEXiu0T7orlDLRUHke8/b7gdXZaDPwPnmKZytgvJk8eq+gLA8GOaRH iZxl3GszokVki42JIDP9CDsSdzSNC/XBd3ocq1E0K0mvxz9BzpThTBzhJ6FFBlLnWwnN8Nqlger0x W93ABHvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0jqJ-00000008n2w-23MS; Tue, 15 Oct 2024 15:52:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0jnQ-00000008mk1-0j1k for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 15:50:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 96F745C5AF3; Tue, 15 Oct 2024 15:49:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A2CEC4CEC6; Tue, 15 Oct 2024 15:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729007354; bh=8rs5FX8euimoaM+3TEF5t4bWzdqlREeZB9JxJ8XE8xM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GmB4dJ1EdYGO/ZUli8Icg0bDOLS/0AUWPsg/90a/xeHWFCI7amjMB6XsK9a0MT3hj p4lF7AKbO6OIIg6f1FbAfYokBk7rGOFWBopSlm4fwr3yCnCq87JzoShYWAF1vXDdn0 pYg5PVf4V0zXkIzdl6zQk0+o8lqu4ac7jI+qRzvV+MD/RyKl4UbyMWCgacoQubTBc5 2ARx5JvudAYmFhS3WJ/AzMLSRlbO7DQgpnSOucWZdeT6tZVbTgu9g4pEzhYuJy6Zz+ IsyCW49MFuG3635ZcmrN1AurDeoiGWu5A/PO3mvr5GPkm0h5+sKN49KNcBkcncETIQ b11D/Z6vhhsxg== Date: Tue, 15 Oct 2024 10:49:12 -0500 From: Rob Herring To: Kuninori Morimoto Cc: Daniel Vetter , David Airlie , Helge Deller , Jaroslav Kysela , Laurent Pinchart , Liam Girdwood , Maarten Lankhorst , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Saravana Kannan , Takashi Iwai , Thomas Zimmermann , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sound@vger.kernel.org, Sakari Ailus Subject: Re: [PATCH v7 0/9] of: property: add of_graph_get_next_port/port_endpoint() Message-ID: <20241015154912.GA1152221-robh@kernel.org> References: <87wmiirqwy.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wmiirqwy.wl-kuninori.morimoto.gx@renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_084916_321044_C62073F0 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2024 at 01:44:30AM +0000, Kuninori Morimoto wrote: > > Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark > > This is v7 patch-set > > Current Of-graph has "endpoint base" for loop, but doesn't have > "port base" loop. "endpoint base" loop only is not enough. > This patch-set add new "port base" for loop, and use it. > > v6 -> v7 > - based on latest linus/master branch > - remove "ports" base functions > - use "port" base function on "endpoint" function ([3/9]) > - tidyup [1/9] explanation > > v5 -> v6 > - based on latest linus/master branch > - [9/9]: fixed compile warrning > > v4 -> v5 > - tidyup comments > - [8/9]: parent NULL check was removed > - [9/9]: use for_each_of_graph_port() > > v3 -> v4 > - new for_each loop includes __free() > - comment indicates to use return_ptr() or no_free_ptr() if > it need to continue to use node > - each driver based on it > - care "prev" leak on of_graph_get_next_ports() > - of_graph_get_next_port_endpoint() indicates WARN() if port > has non-endpoint node > - tidyup each git-log > > v2 -> v3 > - return NULL if it it doesn't have ports / port > - add visible comment on of_graph_get_next_ports() > > v1 -> v2 > - add each Reviewed-by / Acked-by > - tidyup/update Kernel Docs > - use prev as parameter > - update git-log explanation > - remove extra changes > > Kuninori Morimoto (9): > of: property: add of_graph_get_next_port() > of: property: add of_graph_get_next_port_endpoint() > of: property: use new of_graph functions > ASoC: test-component: use new of_graph functions > ASoC: audio-graph-card: use new of_graph functions > ASoC: audio-graph-card2: use new of_graph functions > gpu: drm: omapdrm: use new of_graph functions > fbdev: omapfb: use new of_graph functions > media: xilinx-tpg: use new of_graph functions The DT parts look fine to me now. I see Mark acked this so he's not expecting to take it. I can take it, but need acks on the fbdev and media patches. Rob