From: Linus Walleij <linus.walleij@linaro.org>
To: Clement LE GOFFIC <clement.legoffic@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
Kees Cook <kees@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ardb@kernel.org>
Cc: Antonio Borneo <antonio.borneo@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
stable@vger.kernel.org
Subject: [PATCH v2 0/2] Fix KASAN crash when using KASAN_VMALLOC
Date: Wed, 16 Oct 2024 21:15:20 +0200 [thread overview]
Message-ID: <20241016-arm-kasan-vmalloc-crash-v2-0-0a52fd086eef@linaro.org> (raw)
This problem reported by Clement LE GOFFIC manifest when
using CONFIG_KASAN_IN_VMALLOC and VMAP_STACK:
https://lore.kernel.org/linux-arm-kernel/a1a1d062-f3a2-4d05-9836-3b098de9db6d@foss.st.com/
After some analysis it seems we are missing to sync the
VMALLOC shadow memory in top level PGD to all CPUs.
Add some code to perform this sync, and the bug appears
to go away.
As suggested by Ard, also perform a dummy read from the
shadow memory of the new VMAP_STACK in the low level
assembly.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Implement the two helper functions suggested by Russell
making the KASAN PGD copying less messy.
- Link to v1: https://lore.kernel.org/r/20241015-arm-kasan-vmalloc-crash-v1-0-dbb23592ca83@linaro.org
---
Linus Walleij (2):
ARM: ioremap: Sync PGDs for VMALLOC shadow
ARM: entry: Do a dummy read from VMAP shadow
arch/arm/kernel/entry-armv.S | 8 ++++++++
arch/arm/mm/ioremap.c | 25 +++++++++++++++++++++----
2 files changed, 29 insertions(+), 4 deletions(-)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241015-arm-kasan-vmalloc-crash-fcbd51416457
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
next reply other threads:[~2024-10-16 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 19:15 Linus Walleij [this message]
2024-10-16 19:15 ` [PATCH v2 1/2] ARM: ioremap: Sync PGDs for VMALLOC shadow Linus Walleij
2024-10-17 10:30 ` Mark Rutland
2024-10-17 11:03 ` Ard Biesheuvel
2024-10-21 8:17 ` Linus Walleij
2024-10-16 19:15 ` [PATCH v2 2/2] ARM: entry: Do a dummy read from VMAP shadow Linus Walleij
2024-10-17 10:17 ` Clement LE GOFFIC
2024-10-17 12:55 ` Linus Walleij
2024-10-17 12:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016-arm-kasan-vmalloc-crash-v2-0-0a52fd086eef@linaro.org \
--to=linus.walleij@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antonio.borneo@foss.st.com \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=clement.legoffic@foss.st.com \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox