From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74C6FD2A538 for ; Wed, 16 Oct 2024 18:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AGUSxJLSmS2t2McaXLEaoam4uNrhNWjevpowsdK4u6E=; b=FuiLj6T/9NKaF7OVd73ZkCWWVA 1+hVrlHfBpivN1IH/MoAbqFYAwavfYktO3fM2jX/jcJwi175O7QebWXgLsv/po6m2KzT+xc0ZyPo6 EJAx8oZCrnoLmn4+BQJrQ2bu6XA0+sm3LDyV9qYRrg8b8NiZhR7HBPGiSx0E85vbRIWLz4NVQoCcY /psm3iRqvPDUNlvYgj6XCwrhfSEEsnUSDKj/PyvkzgT6FMFb3ku9bWgHCXdRAW/L/1nI6KSJwg4YD ITjjZu4+ISgPvhTrU+dU0N5ydmR1PSnsC/k9sxwuHBV+doAuiTHariu0kmMlNzhHsC1kq8N1I/MYH 0Xv+ON8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t18Wn-0000000CeUP-0UYn; Wed, 16 Oct 2024 18:13:45 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t18VM-0000000CeN5-1JWk for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 18:12:17 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20c693b68f5so1133605ad.1 for ; Wed, 16 Oct 2024 11:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729102335; x=1729707135; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=AGUSxJLSmS2t2McaXLEaoam4uNrhNWjevpowsdK4u6E=; b=iv8NjX/5/cICZb3R25YR0aiGj4P+bswb9VxNNs8lpzM3DS6zQ7GnpNjyBh4h0BWta4 jR4zwgrMM+lBAkRCBOVcgZ0Kj44LCD6449/dmeTD5iLS6X0WnAJrDt/P7YrbAHUGLtr5 UmUZXuCYxi5FhB1cb3eva3jHDujqisdr/4ybhg47F6nOnhfuLVmbCdacy3gQqQyaMOHc b+QPm6RrT1uvXWimZsfk1uLvAJ0qbcZj1G11FYqHbZH5WhDZRV9ROINlTMk1RvEb1S5X rDwwbg5XQow1o4JMkt4KHk1gG1OZVTd/yzlCZ64IK3NemI+PkcQD1BYRrXtY5Xcm2a7V nyFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729102335; x=1729707135; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AGUSxJLSmS2t2McaXLEaoam4uNrhNWjevpowsdK4u6E=; b=jx29WrG+x2gGVSCUFh5Ho3NbDqkTMRDZPoN7d9gmW5GFn0mOz81mvEZb7OuDp40t/U DF8McUpaOqc4QvLWK3HjJ5e0s/4fqUTnumJ0gVaP2ekChopIN/UbgZr3YDVs+2TO6ewr DHiCMw9JRTXeupq9bh7HJcI0oAPy2iJ9YQ4yu27uU2IdMyQZwRpl6EDi7VI2z6+/P4nL Av2fK3JGWNkWXSSjEq8GiHh9dO24le/6fRpmzaqIjd+2IObukJpk7B/rlCprFQXLj8Mz fQsO0DQeOtFYhJTHH6wKHuwCVEUUFHTjYqqIIaD0tuUZSNMnH+IWl1kH1iAYDFaCuoWM 9otQ== X-Forwarded-Encrypted: i=1; AJvYcCX+WVkYRfwbp9NHWcDdCLwnuDsDvw6Ze5oYxo1tYpeUMOcLRpSS3F5GZ79QYQGFIkYrLdJ7lqm1jdu4N1o4lRhG@lists.infradead.org X-Gm-Message-State: AOJu0Yx/vEPBgQ0urRHXxNaDSL7jIsAw37+V/ZQOMM60fIKeGFitYzwH dIAURWz713R1QaHJ73cSGKjugPlIeRszBV1xuGWX0hMEZYdcHpW0UZ+B80sCSA== X-Google-Smtp-Source: AGHT+IEC4f0FCA7jD/T3S9Y3FpFfE6YgpsYbswvi8qmMeUEzDMbMadrb3Bae263HJGs3xq7PNu5TDg== X-Received: by 2002:a05:6a20:d80c:b0:1d9:1c20:4092 with SMTP id adf61e73a8af0-1d91c2047f1mr608016637.16.1729102335093; Wed, 16 Oct 2024 11:12:15 -0700 (PDT) Received: from thinkpad ([220.158.156.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e774d2a0csm3376997b3a.181.2024.10.16.11.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 11:12:14 -0700 (PDT) Date: Wed, 16 Oct 2024 23:42:07 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Abraham I , Saravana Kannan , Jingoo Han , Gustavo Pimentel , Jesper Nilsson , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v2 3/4] PCI: imx6: Pass correct sub mode when calling phy_set_mode_ext() Message-ID: <20241016181207.qhjkhz266quak6ve@thinkpad> References: <20240923-pcie_ep_range-v2-0-78d2ea434d9f@nxp.com> <20240923-pcie_ep_range-v2-3-78d2ea434d9f@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240923-pcie_ep_range-v2-3-78d2ea434d9f@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_111216_379382_9A1714E0 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2024 at 02:59:21PM -0400, Frank Li wrote: > Fix hardcoding to Root Complex (RC) mode by adding a drvdata mode check. > Pass PHY_MODE_PCIE_EP if the PCI controller operates in Endpoint (EP) mode. > Patch descriptions should fit within 75 columns. > Fixes: 8026f2d8e8a9 ("PCI: imx6: Call common PHY API to set mode, speed, and submode") > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 808d1f1054173..bdc2b372e6c13 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -961,7 +961,9 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) > goto err_clk_disable; > } > > - ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC); > + ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, > + imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE ? > + PHY_MODE_PCIE_EP : PHY_MODE_PCIE_RC); > if (ret) { > dev_err(dev, "unable to set PCIe PHY mode\n"); > goto err_phy_exit; > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்