From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91777D2A538 for ; Wed, 16 Oct 2024 18:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JqcNJoZn1LzotoHmCYaem8+wwJv3TspcxGY5Y2wT3qE=; b=U41j57r/tz04cXxsg7p63dejVN UtqEFGwjnLvxQJMGYCoJ3d2n4aF7pVS7jFXdmT8J+O2QGHDRiPyv5ReR6zYvoKoW3sAcvjij0rTLp lDvaOpe8omeCUq99x4E4tw5zZBLH9+q0JoTYFY5A/mrANXWElBjTzNbSNXeY4Kf1AsUGtpT8qTcxY iF1DzA5U7wbA2Xg9END9dxUFiaJqQQ6q+3A5mUruJdc0qjD2G3bkYj3n+QjocGuWcD/wKumS/AifX jO5oVqABjcpcBP1Ce6fDOBDlUYKALwFWf+qt2BaAvSVKdIlrfoAAwSdBK/VCvpmQ5O3KtCMCUeWxk B9RqNCSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t18ZT-0000000Cesh-0M8R; Wed, 16 Oct 2024 18:16:31 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t18Y1-0000000CegO-0XBH for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 18:15:03 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20cb47387ceso1005545ad.1 for ; Wed, 16 Oct 2024 11:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729102500; x=1729707300; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JqcNJoZn1LzotoHmCYaem8+wwJv3TspcxGY5Y2wT3qE=; b=OL0MlEaTggfSBGl/AXDedgflsls1qM2iE6x2n3e0avdPcC4iJQdHRT/zeLDNAK2ZCS 7SAurHHIi/YxcO5/g5aHUJ1kGveXDiQ8tGTgQaL17wYTNq2228XyejPaVC3dUj5rELPn ijf96IJz/4VYlNPvfQezz4rJyYG01swdi50XSwtgrYAeLb7H6X+fTxZuPUXkFPqw5tLe gFjPMbjtMIpaOGKXcXiEtBZMAFMvNS2jEVg2CCRgrYd+/Kef5L4QEHvXAQg/fg1FZzex mQNHg3xbalH9bz5P0aauxDYco4EFyM7ojeEVTcv/AxdCfd1wLzZKBx2P2lOzY4CAKFn7 psHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729102500; x=1729707300; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JqcNJoZn1LzotoHmCYaem8+wwJv3TspcxGY5Y2wT3qE=; b=hSfrXx1mLLGMyN5WU5XnoBQvlyd7jzZME1xzVtODYQH1OlSZqlNgxitQz0RK77Yx0V JygzTr/8z0S6ws5MhDFJuI8gPx/lTDnRGBg1WzCz3qe7HLNqQNJTVfG0lGvQaYuYFfEc oHGLm6uAwT+MkpQUqeigjDcM/lwEG+K4qXxT9uzPa8K5/ycHBgh3IhWlINYUM7wHBrEn 3QQrRbyyQjTvgQtMenRbxl9A5j1QVcQweGgrMPoLpsca5I6xcLKUdq9euCY/eu+Ua0wn t2QS3j0GAIhAn1NWP2E0wiPSwu5jZPrXsg7JqUF+8yWF1KP0K6vsd0b5UDxFOz7XDnsD oGJg== X-Forwarded-Encrypted: i=1; AJvYcCWFI+OVwSmE7HtQtv7mw0kUWKsjJdkgKiEZzUQyDkGBH/UQD7VUI3fRo7ZQKPjIblIDXxu1FCxoIWUrh6ImDuuL@lists.infradead.org X-Gm-Message-State: AOJu0Yx+0ggfd/fd9A5ccVrSKJIGJ5JpnAWasmMSdkiUHEPOznPQvnO0 BMuAhUwyFg1w95RBQEw4bBPnjTzVMb3xnguKMgD08aeSOmJMfTS0pyBh7Ie/cg== X-Google-Smtp-Source: AGHT+IFkhn/1WXaFJTfDH4EjM24/sVzkY4clftH7mc2KR4khd66Aw1VpnRIVe5BuWrMJFdiif8PjyA== X-Received: by 2002:a17:903:2405:b0:20c:9bf9:1d97 with SMTP id d9443c01a7336-20d27f41971mr51867625ad.60.1729102500172; Wed, 16 Oct 2024 11:15:00 -0700 (PDT) Received: from thinkpad ([220.158.156.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d1805a175sm31465615ad.247.2024.10.16.11.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 11:14:59 -0700 (PDT) Date: Wed, 16 Oct 2024 23:44:51 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Abraham I , Saravana Kannan , Jingoo Han , Gustavo Pimentel , Jesper Nilsson , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH v2 4/4] PCI: imx6: Add i.MX8Q PCIe Endpoint (EP) support Message-ID: <20241016181451.atzbuvubsxrpsaiw@thinkpad> References: <20240923-pcie_ep_range-v2-0-78d2ea434d9f@nxp.com> <20240923-pcie_ep_range-v2-4-78d2ea434d9f@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240923-pcie_ep_range-v2-4-78d2ea434d9f@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_111501_600363_707D4D9B X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 23, 2024 at 02:59:22PM -0400, Frank Li wrote: Subject should specify 'i.MX8Q series of SoCs'. So it would become: 'PCI: imx6: Add PCIe Endpoint (EP) support for i.MX8Q series of SoCs' > Add support for i.MX8Q series (i.MX8QM, i.MX8QXP, and i.MX8DXL) PCIe > Endpoint (EP). On i.MX8Q platforms, the PCI bus addresses differ from the > CPU addresses. The DesignWare (DWC) driver already handles this in the > common code. > > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pci-imx6.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index bdc2b372e6c13..1e58c24137e7f 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -70,6 +70,7 @@ enum imx_pcie_variants { > IMX8MQ_EP, > IMX8MM_EP, > IMX8MP_EP, > + IMX8Q_EP, > IMX95_EP, > }; > > @@ -1079,6 +1080,16 @@ static const struct pci_epc_features imx8m_pcie_epc_features = { > .align = SZ_64K, > }; > > +static const struct pci_epc_features imx8q_pcie_epc_features = { > + .linkup_notifier = false, > + .msi_capable = true, > + .msix_capable = false, > + .bar[BAR_1] = { .type = BAR_RESERVED, }, > + .bar[BAR_3] = { .type = BAR_RESERVED, }, > + .bar[BAR_5] = { .type = BAR_RESERVED, }, > + .align = SZ_64K, > +}; > + > /* > * BAR# | Default BAR enable | Default BAR Type | Default BAR Size | BAR Sizing Scheme > * ================================================================================================ > @@ -1645,6 +1656,14 @@ static const struct imx_pcie_drvdata drvdata[] = { > .epc_features = &imx8m_pcie_epc_features, > .enable_ref_clk = imx8mm_pcie_enable_ref_clk, > }, > + [IMX8Q_EP] = { > + .variant = IMX8Q_EP, > + .flags = IMX_PCIE_FLAG_HAS_PHYDRV, > + .mode = DW_PCIE_EP_TYPE, > + .epc_features = &imx8q_pcie_epc_features, > + .clk_names = imx8q_clks, > + .clks_cnt = ARRAY_SIZE(imx8q_clks), > + }, > [IMX95_EP] = { > .variant = IMX95_EP, > .flags = IMX_PCIE_FLAG_HAS_SERDES | > @@ -1674,6 +1693,7 @@ static const struct of_device_id imx_pcie_of_match[] = { > { .compatible = "fsl,imx8mq-pcie-ep", .data = &drvdata[IMX8MQ_EP], }, > { .compatible = "fsl,imx8mm-pcie-ep", .data = &drvdata[IMX8MM_EP], }, > { .compatible = "fsl,imx8mp-pcie-ep", .data = &drvdata[IMX8MP_EP], }, > + { .compatible = "fsl,imx8q-pcie-ep", .data = &drvdata[IMX8Q_EP], }, > { .compatible = "fsl,imx95-pcie-ep", .data = &drvdata[IMX95_EP], }, > {}, > }; > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்