From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A0FDD2F7D2 for ; Wed, 16 Oct 2024 23:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W649ciFRM8rbVAGw5XNBosXQcXGpXdRG+9QrhIYNObU=; b=hIJEaZ5SMMwb951VDUp/bg1tfC 5fJuFMX5ScUFGEAj3RbK4ErAQd2FeGJB6Rvq8GTbjFXQ3932Hz43fXB1daxcRZPFwPZwNEBK1l8uW sdZkWi3Gcppk0jK61lMoWDJveFN2iQXIEOyGjUsTGsdbtptMxWfevL9jgE+VdO51r1A56Qf1M8Nnf 6onsTLTr1uhaATu3QdnoolZhLL9Bk/hvzDi19bAHtEgqkWVat1sKshKQ3BqSJYMSyyp8dfZj1yOT0 8/4+lGso6EgOqw71TzZyKwAR1kL8fJ7nffmwThvGxJl86ldM/w8NYZeENPrayUbuRiQZTexcUhPZ2 55rrvSEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1DFB-0000000DD9V-0pyM; Wed, 16 Oct 2024 23:15:53 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1C7T-0000000D7q8-11ZJ for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2024 22:03:52 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 415081C0003; Wed, 16 Oct 2024 22:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1729116228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W649ciFRM8rbVAGw5XNBosXQcXGpXdRG+9QrhIYNObU=; b=Tz7CXQc7iVINk4/iYg6zXg1Xx669sH2r9t5RJWIqVYo3Nnr9W19lh7b0enuDCtajEtTlFv dh0hibF53mm97MDz+dOFX9tLpWvQhXkITOGMx9BEZy2m11kaIEa/g5VLX17IFDG2dpqI8n jx3pD3T2eeP6WswiQAFLX61WQSa7uge9iQ2AtrAUosvZVbVZ6jH/zjNupWlLgH42HZZV7C 4MJLIDN3s0O8z6+oowJPgcaJLCGkmSXSh8UlzaBjXwDlp3/FySheLG81bCM8+H+RlwNMlO jsC50H95GM33spkAhj1ps6f1tbxQGMIlD4tvH2OhrYi507O62AXpOprCrD/mpQ== Date: Thu, 17 Oct 2024 00:03:46 +0200 From: Alexandre Belloni To: claudiu beznea Cc: Geert Uytterhoeven , mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea Subject: Re: [PATCH v3 08/12] arm64: dts: renesas: r9a08g045: Add RTC node Message-ID: <2024101622034648032b39@mail.local> References: <20240830130218.3377060-1-claudiu.beznea.uj@bp.renesas.com> <20240830130218.3377060-9-claudiu.beznea.uj@bp.renesas.com> <4ff318b0-cd7c-4857-888c-a07c8985fce9@tuxon.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ff318b0-cd7c-4857-888c-a07c8985fce9@tuxon.dev> X-GND-Sasl: alexandre.belloni@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_150351_457326_A30420AC X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/10/2024 13:28:55+0300, claudiu beznea wrote: > >> + compatible = "renesas,r9a08g045-rtca3", "renesas,rz-rtca3"; > >> + reg = <0 0x1004ec00 0 0x400>; > >> + interrupts = , > >> + , > >> + ; > >> + interrupt-names = "alarm", "period", "carry"; > >> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb VBATTB_VBATTCLK>; > >> + clock-names = "bus", "counter"; > >> + assigned-clocks = <&vbattb VBATTB_MUX>; > >> + assigned-clock-parents = <&vbattb VBATTB_XC>; > > > > Don't the assigned-clock* properties belong in the board DTS? > > It makes sense to be in the board DTS, indeed. > > > In addition, I think they should be documented in the DT bindings, > > and be made required, so board developers don't forget about them. > > It would be better, indeed. There were multiple recent emails from Rob saying that assigned-clocks should not be part of the bindings. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com