From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBE8AD2F7DA for ; Thu, 17 Oct 2024 02:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6PTLp9rNOc6PjJ/wRq0EWdp2+KT+2YSuEOgH0ybqdgA=; b=PcJgAmMnLs5re7MbHZ7BreyOI1 0jIf+R5woRI/H249WEifvu8PCdX1xGPVhjcmZFBOi6ub/UQe2fnzN5pWVlcLNHl2JrUmgbj2ITl8C hAqLNNF65SbehvrApyxQN6NyDtD5aCM9KsY81lNI94+aZUb0V4KTcMT2GlcVcBOlAoHlW+JLq6Kks Adrxffuu6Kz7mgwk9VyyLdXhvT8V4OXHgxGh2Bf5wxhReStVa1aHrvCtdnIYjG5jgRCpcAzxDE2E7 YmT31HJCR27UpvK6q+JG9KVNP0U9QjUy+62L6cnZ8mOHQezLMqUsQYY5RTjAKkRDE0HBBSkxQ4X0h F7u39DxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1GRJ-0000000DZWP-33TC; Thu, 17 Oct 2024 02:40:37 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1GOm-0000000DZGh-0WCX for linux-arm-kernel@bombadil.infradead.org; Thu, 17 Oct 2024 02:38:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6PTLp9rNOc6PjJ/wRq0EWdp2+KT+2YSuEOgH0ybqdgA=; b=WAhFso+lXskAJXgZ82wd1RS0kk QDagR42KQk21tgpQeZCKAQe5d6ibqsyLGdS9LxGAWaNBfXmBB/k05HjDPPh3XSL9ejtOxxxiOD4AE YZqCRNsFC1hlpW0TYBke4cjQce7BBz+9iPalpldZdHs0Y1shZfzUdzMhXc7DbJeKlWILPzxBn9vzU ydvOR4tUgnQEZpvj8aH0E7cXeMBZ7nDgD6t/e2vtnoWvXPa8DgH5ZP1t8p2HIc6OKFaOMX6QqbVz7 1v7qBcNUQrxsh1C+bPU+Jdpd1ZcmSFqJSWF3AEmu1b9U+5WTpN1vbjl9W1mWjV2E/+QzmQihPQvQY gRaqtilQ==; Received: from nyc.source.kernel.org ([147.75.193.91]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1GOh-000000071sU-0njW for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 02:37:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A8B00A43369; Thu, 17 Oct 2024 02:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A077C4CEC5; Thu, 17 Oct 2024 02:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729132673; bh=WSsIBEfsPbip9F6mfb36q0p5MQac5KhNKsxsnPuS9Jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+J0z41KFHQhTIF9rju/4KOx73aHX2pUclKJA/zmf68YgOHlDUYLmNA7+YghWgTng 6e4LMtMBsxJLB+b53X1t2hfvUmabSc6vMjKBOMG5oXhSPOACaKZZ+Pij1yEz44UKfR TSMAs/M4GpwuGDDFfJz1o3LW5FkHesYTdWXq9COIp9w2EQ1lz8BR72MsCg/8xPwwnQ jH+/PXj/PHmjxiiHiROid7IrjqdUiwwtDdnPWRhPG0wySvfq6Ro5HCn4iW9zDjOOa1 oa3wzoo+vstBzAXePr9t/PuwkHuU9bzuD2gnUQecm3o0MIe7FYUcKovnURd7iwkML4 McmEWbgtqMNNw== Date: Wed, 16 Oct 2024 19:37:51 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, will@kernel.org, catalin.marinas@arm.com, Ard Biesheuvel , Kees Cook Subject: Re: [PATCH v2 1/2] arm64/lib: Handle CRC-32 alternative in C code Message-ID: <20241017023751.GA1780@sol.localdomain> References: <20241016192640.406255-4-ardb+git@google.com> <20241016192640.406255-5-ardb+git@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016192640.406255-5-ardb+git@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_033757_210832_861140D0 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 16, 2024 at 09:26:42PM +0200, Ard Biesheuvel wrote: > diff --git a/arch/arm64/lib/crc32.S b/arch/arm64/lib/crc32.S > index 8340dccff46f..5dac63da4247 100644 > --- a/arch/arm64/lib/crc32.S > +++ b/arch/arm64/lib/crc32.S > @@ -136,25 +136,16 @@ CPU_BE( rev16 \reg, \reg ) > .endm > > .align 5 > -SYM_FUNC_START(crc32_le) > -alternative_if_not ARM64_HAS_CRC32 > - b crc32_le_base > -alternative_else_nop_endif In case you happen to send a new version of this, note that the #include can be removed from this file. - Eric