From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6F3FD2127C for ; Thu, 17 Oct 2024 11:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a85yCoVNb1LX+meq7Q8TdIMD47Q2A2/eEFQX0Jfpgq8=; b=1dH1v4mEW25K7xyD4U0eU2+PNv PafQUSFpyFb2tUM5wB2a2dCWN7jz/CvEhFeLWxC2iDHjXRWeQ37xni1zn1mNohs05ZIYcSaK4hUGJ xItcX0uDcYlV1WRFxTLoECwA4rbV/3a5sRzY1VloEQs6/3rW9LZQfoK0yeI1bJJHUwsADJg3aq+b3 SBOCm2hBEzhbWGgIA3Yw4jDSLIcawiO/3o1U0NCb8Xsu0bbcCDDbpFL2Hiig9F+XA0AvaHXY7xmwu KdNKNDa1etQ+E4dDT0ckdJ+DS72oZKVRsfRs7G7RLTYBx3tF6kQu5LuSlaaLZ6+3OD7cnrtWqAjaR 7H0N8chA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1OFI-0000000EZ2A-0uAx; Thu, 17 Oct 2024 11:00:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1Nax-0000000EUrG-0GAP for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 10:19:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0470E5C5DC8; Thu, 17 Oct 2024 10:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63B19C4CEC5; Thu, 17 Oct 2024 10:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729160342; bh=EwYIiVN0SdU+AkH/bqOTTx9jJa66IvHYmbDVoyJuE1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ldn9oUebm27rhdmUNrnOOid25bg5Cnqabl8JZE4coHOkSMDkAe0L/JXRjSxp8UR1L cK2rQdpLhLvXQuXRvoPWb32T8XPVjrpIVkKJLsJoehDXa5qxTrfXrEbh0AAAZ4ktBY iFM9sgzhMBOfM8ypLdkqQdRwIT6csH5c8/TBB7IDkcvKZrlYzsCabhf5XM+Cvi9K+9 ZjkIxqy66D7ecL44cSqTHccZaralLQVsdC6wiKhCSzMrQlylRPRwuS9qsULCGDBR0w mzmK/IdZ/W5WNGYiGz3I6r17rhQGInyAww+I6Et5AkEcoSFD97NDtZ5edBhATBj4uL vzL+hfqAm32Vg== Date: Thu, 17 Oct 2024 11:18:57 +0100 From: Simon Horman To: 2694439648@qq.com Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hailong.fan@siengine.com Subject: Re: [PATCH] net: stmmac: enable MAC after MTL configuring Message-ID: <20241017101857.GE1697@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_031903_183527_91F7822A X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2024 at 01:44:03PM +0800, 2694439648@qq.com wrote: > From: "hailong.fan" > > DMA maybe block while ETH is opening, > Adjust the enable sequence, put the MAC enable last > > Signed-off-by: hailong.fan Hi, I think that some more explanation of this is required. Including if a problem has been observed, and if so under what conditions. Or, if not, some background information on why this adjustment is correct. I also think some explanation is required of the relationship between the changes this patch makes to setup, and the changes it makes to start and stop. ...