From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Stefan Wahren <wahrenst@gmx.net>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] ARM: dts: mxs: Add descriptions for imx287 based btt3-[012] devices
Date: Thu, 17 Oct 2024 14:18:18 +0200 [thread overview]
Message-ID: <20241017141818.2cf462ce@wsk> (raw)
In-Reply-To: <CAOMZO5DkmU4C0YQoVwCbHTBo=DTRGcz+9K1qHY=3V29eWAfEKQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]
Hi Fabio,
> Hi Lukasz,
>
> On Thu, Oct 17, 2024 at 5:35 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > Stefan, do you have comments for this version?
>
> Rob's bot reported new warnings after applying your series:
>
> from schema $id:
> http://devicetree.org/schemas/display/panel/panel-dpi.yaml#
> arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dtb: panel: compatible:
> ['panel-dpi'] is too short
> from schema $id:
> http://devicetree.org/schemas/display/panel/panel-dpi.yaml#
> arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dtb: panel: compatible:
> ['panel-dpi'] is too short
> from schema $id:
> http://devicetree.org/schemas/display/panel/panel-dpi.yaml#
>
> Please address it.
The problem is that I don't know the name of the display itself
(different vendors) [*].
Schema requires following syntax:
arch/arm/boot/dts/ti/omap/am437x-gp-evm.dts:89: compatible =
"osddisplays,osd070t1718-19ts", "panel-dpi";
arch/arm/boot/dts/ti/omap/omap3-thunder.dts:86: compatible =
"samsung,lte430wq-f0c", "panel-dpi";
which require two compatible entries - one specific type of the display
(e.g. "samsung,lte430wq-f0c") and the second one generic ("panel-dpi").
As I don't know what is the manufacturer of it - I can add:
compatible = "foo", "panel-dpi";
and then Schema and Rob's scripts would be happy...
Another option is to adjust the
Documentation/devicetree/bindings/display/panel/panel-dpi.yaml to allow
only single entry.
[*] maybe I can obtain the info regarding at least one vendor ...
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-17 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 8:17 [PATCH v8 1/2] dt-bindings: arm: Document the btt3 i.MX28 based board Lukasz Majewski
2024-10-10 8:17 ` [PATCH v8 2/2] ARM: dts: mxs: Add descriptions for imx287 based btt3-[012] devices Lukasz Majewski
2024-10-17 8:35 ` Lukasz Majewski
2024-10-17 11:21 ` Fabio Estevam
2024-10-17 12:18 ` Lukasz Majewski [this message]
2024-10-17 12:29 ` Fabio Estevam
2024-10-17 12:10 ` Stefan Wahren
2024-10-10 14:30 ` [PATCH v8 1/2] dt-bindings: arm: Document the btt3 i.MX28 based board Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017141818.2cf462ce@wsk \
--to=lukma@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).