From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70867D3C525 for ; Thu, 17 Oct 2024 17:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BklMX6kfbrOCfwq57rgPw+skZZbUrE/VXthIxbMG8vM=; b=hnUbN8usd8+7dWiKNoxmi9OI/N ik0x97LQXvyDIC3TzhYyrnq54aH8Ja0Tu8mRUPDFFToDU8u9q5UkWmjDXLXDHJ7VVOcTVufmGWsyQ Pi7a9ezvrk2P2U4ZAkCUjsm/c4l2oucREpIw2YkPavROS7nrHQDoH0rvjjv25VfcWV3zIRGA16me9 zmNBxz0FuhxPsO8Pa0HS3dPj9+8Ub6Us4Aq11Iu66fERb+h5fnF0YG6+F54ogLcdz19lM0g6wleGw dg8oCRAoClI7Ix+LYvJ9spWsKTkbsFokM05PoK/tPyAlF4EqtM31kPdsj8MA9TEkRvHCz0FvwTOO3 VmLtAPlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1U56-0000000FgDI-0iTk; Thu, 17 Oct 2024 17:14:36 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1Txi-0000000FePw-2bjF for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 17:07:00 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43152fa76aaso1465165e9.1 for ; Thu, 17 Oct 2024 10:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729184816; x=1729789616; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BklMX6kfbrOCfwq57rgPw+skZZbUrE/VXthIxbMG8vM=; b=QvvGqoMF2Jfxovf0fDqoXtCgb868ENGVXMHLRGj9DRInSHGSjeUhrozdiqDMpns5WK LlEHoj9VFoUi+2FMhHTfdLMPFWDBmpjgojvpu7PmwgfjKk28MKk5rx39JuEH5j/oXA39 7ypfoQeDSEnSOpHUgpFbC5fHatkt3pnM/NwrYOIPFFBRU58T2pIgqmKtB26uG6ud9Itc 80zjAhMralXh1qH7yzOaBcuVmfYStx/UIJrocDZ0wZ7J+l7Bjh8KhOFDWM0jIInqiEue 619OdSHEdNVJOJbTYxHtTkW+uccB8/FLSNBSekY1Lh3oUHrgM/nH9tOf8rOdF5j5umlJ ljYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729184816; x=1729789616; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BklMX6kfbrOCfwq57rgPw+skZZbUrE/VXthIxbMG8vM=; b=h8tY41kjbcx5ylyiOnAKKJkcc0Spotao6vhA2KGflr9c9Kcko5EnEAPwgsAzuyOfrP Fd3v+teyMs7sqwbWoLZOpADaXLfM70So6IeeDrmm18ayjBkx/Jyj1JfKB0ZAVEBypqIC G11ztDCiDyp8pBCzzJCo+oKrHb4Pb1/3wrLhBOMSsSUSDIZkBf1Dt9W45TZTi8Zl9T6a HbPXOXfik5a83k6alacZClMKI08wISjKNEyqin1IDe5go+dumT/hDX7RWZGMxEGsly1B QrYnrRoKm+NpL98UIMZlM4bovRyACG2ZWkNxMXVNNI+1XFX8d7++tKBTcCRG8DGJXKNs Yj3A== X-Forwarded-Encrypted: i=1; AJvYcCWfpz2HqxTxDShGwUtZ6YnuV3ZzZz6cn/0yVE5V9PZmW0c/Gnijfxrt7s95bNal2OZie51rw9XcyGhuY1fkdARw@lists.infradead.org X-Gm-Message-State: AOJu0YzpDoueO8HLyy4Z366pzF5i5JIHP45D+wYaXyMb+Mu0Usjkvq9B 7/6JPJfyDQkfFAfopwb+yQfvBsrAgSb5HyLse9yvDeOcecDMgHlp X-Google-Smtp-Source: AGHT+IHzJDME5SIjxnynJhIsVC0xEhR+BB69pSxP+FYEqGEafYCH6L/9yl4C79ZfCTY8848O73S+qg== X-Received: by 2002:a05:600c:3546:b0:42c:aeee:80c with SMTP id 5b1f17b1804b1-4315080685amr24541995e9.9.1729184815932; Thu, 17 Oct 2024 10:06:55 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316067dc70sm1376025e9.10.2024.10.17.10.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 10:06:55 -0700 (PDT) Date: Thu, 17 Oct 2024 20:06:52 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com>, Serge Semin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , xfr@outlook.com Subject: Re: [PATCH net-next v1 0/5] net: stmmac: Refactor FPE as a separate module Message-ID: <20241017170652.jtg2abm532sp4uah@skbuf> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_100658_690566_C3D68484 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 05:09:21PM +0800, Furong Xu wrote: > Refactor FPE implementation by moving common code for DWMAC4 and > DWXGMAC into a separate FPE module. > > FPE implementation for DWMAC4 and DWXGMAC differs only for: > 1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS > 2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1 > > Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a > > Furong Xu (5): > net: stmmac: Introduce separate files for FPE implementation > net: stmmac: Introduce stmmac_fpe_ops for gmac4 and xgmac > net: stmmac: Rework marco definitions for gmac4 and xgmac > net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ > net: stmmac: xgmac: Complete FPE support > > drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- > drivers/net/ethernet/stmicro/stmmac/common.h | 1 + > .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 12 - > drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 150 ------ > drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 26 -- > .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 7 +- > .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 28 -- > drivers/net/ethernet/stmicro/stmmac/hwif.c | 7 + > drivers/net/ethernet/stmicro/stmmac/hwif.h | 54 ++- > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 10 - > .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- > .../net/ethernet/stmicro/stmmac/stmmac_fpe.c | 442 ++++++++++++++++++ > .../net/ethernet/stmicro/stmmac/stmmac_fpe.h | 38 ++ > .../net/ethernet/stmicro/stmmac/stmmac_main.c | 149 +----- > .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 4 +- > 15 files changed, 527 insertions(+), 405 deletions(-) > create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c > create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h > > -- > 2.34.1 > Sergey Syomin is the one who originally requested the splitting of FPE into a separate module. https://lore.kernel.org/netdev/max7qd6eafatuse22ymmbfhumrctvf2lenwzhn6sxsm5ugebh6@udblqrtlblbf/ I guess you could CC him on next patch revisions, maybe he can take a look and see if it is what he had in mind. I don't care so much about internal stmmac organization stuff.