From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98352D3C526 for ; Thu, 17 Oct 2024 17:25:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ruAjioQ9k7jbFZfBIq4ftH/WHh/CcrYyuu9X+EyIj3A=; b=kdnrLWLki3WkSka6ISLhsMNvKG vcvI/SnIs0b4clCGMcYQEF6qwcHF+CRt2+n3gmNT/jPADOCkiJbVC/JlfIx0ksLGhBqDVTaPzL3cU zFRO8eXu2Vvehp9IUnIHUAzPlGqVui+rxZAYaskkIGRKgCJ0mUBo2i7OmJy3Avz258w1w1Zdx/31R gzIHvtiyPTYQFX1j7dwB7Y/lSlJNY2kSiv8mPDQc5LKPmZrX9/q59JWExMLQaKE/GIRRcOUr7yTyw ff6gr9TFEoyo3b++DH/2OVPLUccN897QJlSZNsq6IdkDfFdQaYNtAQyLqWc4u/MZEr5yFwXK6QV+3 lDzq/mnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1UF1-0000000Fhru-1aYF; Thu, 17 Oct 2024 17:24:51 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1U9J-0000000Fh1M-1iIA for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 17:18:58 +0000 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4314e64eba4so1468025e9.2 for ; Thu, 17 Oct 2024 10:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729185535; x=1729790335; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ruAjioQ9k7jbFZfBIq4ftH/WHh/CcrYyuu9X+EyIj3A=; b=PhYrJhYcI5/R16I6+jrE8/lRxXgEV5CPIo6hVWW7Zt7mOTwA+eUEaGPM9Tl0ZP7uDz QoFpbwtybVjwK2Jck9kPBtCogOHISRxJXR87+00nL6sSgAS7Wo2fnH8sAUN6cVXMyFne 39LzBe4pFXH7m0c3EE3YqEyGeeWV21+fFR0iCtcPVfZh2e9GpTr9M9AQJ5sBClZCnzEi D8KUg8K+FHBiPSDXLBxoCHJFQtvW756eGRiWwEKZUuv6KT4mfdyEP3S/5pENSmWbB8cD qPgIt9uYziSYnTkFHwTCqSt3R0UtEC3szIvxh/h5WSTJ9jtEaYRQzsSLiIXIcxW8kjuB S4Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729185535; x=1729790335; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ruAjioQ9k7jbFZfBIq4ftH/WHh/CcrYyuu9X+EyIj3A=; b=Jgt3K0xbkJa7w5ezn4m+W6XkkNbXrmERj06WEx+sRBbuqG6jCel2j5IAAas/d8QAcV SHH/S+hlNdOYvXZgoEYNG301QnWS2tsorB1k0JVDPChv8X6jjjivHUs5zlAriMIaVZ0T yHbXxml3oBekPT8zggD2bt+N/8AzGNfL3VgvoUSWhQfq4c0E4iH2ef11eXStPfIo6u7Y LZQqgCvshaciepG/+Ayn5TBqLE8h5C05HAYR+R2m5LZtSzafieaq49YbBZblx9NKyaWr cYA/Jy3HyIuHyyhYrI99sUMiK4yU9N6G221/UoB71pQRFaHl5a2vaadQRXqj+MKbWWbu jSXw== X-Forwarded-Encrypted: i=1; AJvYcCV6PFg95/oGpdBLPOCz7hiEF8CSpL+Fcz1++/IfDaEu4KNcuUy/TfePi06c2iNnzbEkYdquP0yWqIhEbYSvS6da@lists.infradead.org X-Gm-Message-State: AOJu0YyYbBV5qxuKJf6Vr7ELcZ84mgn8h9bwYp/OPu5MVImHXxmyRERV QB3cbZc6ZT6/uJITQ46RH2TZ2XEsZs41yB88MmxK+GrNeHhQmfkp X-Google-Smtp-Source: AGHT+IE9Eb/5bNteKLsSum3xN8R6ddBqz1cPduAZYwClja5hPYbrIk6zbmBICf6aIECSo0fli7nLvQ== X-Received: by 2002:a05:600c:4e8d:b0:42c:aeee:80b with SMTP id 5b1f17b1804b1-43160ac6141mr11155e9.8.1729185535159; Thu, 17 Oct 2024 10:18:55 -0700 (PDT) Received: from skbuf ([188.25.134.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43160682d0dsm1694105e9.8.2024.10.17.10.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 10:18:54 -0700 (PDT) Date: Thu, 17 Oct 2024 20:18:52 +0300 From: Vladimir Oltean To: Furong Xu <0x1207@gmail.com> Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , xfr@outlook.com Subject: Re: [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ Message-ID: <20241017171852.fwomny3wedypybhx@skbuf> References: <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_101857_470965_0B297A56 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 05:09:25PM +0800, Furong Xu wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > index 917796293c26..c66fa6040672 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > @@ -84,8 +84,8 @@ > #define XGMAC_MCBCQEN BIT(15) > #define XGMAC_MCBCQ GENMASK(11, 8) > #define XGMAC_MCBCQ_SHIFT 8 > -#define XGMAC_RQ GENMASK(7, 4) > -#define XGMAC_RQ_SHIFT 4 > +#define XGMAC_FPRQ GENMASK(7, 4) > +#define XGMAC_FPRQ_SHIFT 4 If you made use of FIELD_PREP(), you would not need the _SHIFT variant at all (though that would be a separate logical change). > #define XGMAC_UPQ GENMASK(3, 0) > #define XGMAC_UPQ_SHIFT 0 > #define XGMAC_RXQ_CTRL2 0x000000a8