From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D069D2127C for ; Thu, 17 Oct 2024 11:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=puN6p+bMjYJtsrg56y32J8yDB4IjMscvJ6LWf1rgN+k=; b=HQy6ysl8AKhoZlQglMRmbpJinY xdmFef42NHjgdrVSZKGeo20P69pPqGWTykRaokuhOW2jhO6gWvwtJT5ov2mk96U0XDlf3K7kXgE9b 4mm/a9NrGh12dV5ZSaaCQtGze0vdDGq3YoQJDAMuCwtNHFKt3i0e1kBL2OHWgqCBbciICQbxAp/IV 3x0YrwV89polbFFjbM9v/JiKNpPX5JsjtWWjeU7Zn0S3QY7KODlFWx0VjmUrAsmZ9TdDDtY6M/Hh9 ynSpdKKquwX2J5fBVfnkZr6UxrfLPbVrqVBd/nohQwhny1y8jYR1TD7A/ymZPGCEIpdUvr0jM+drp KiRDl/3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Ovz-0000000Efko-3qLk; Thu, 17 Oct 2024 11:44:51 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1OuL-0000000EfXn-3wGi for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2024 11:43:14 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20caea61132so7029075ad.2 for ; Thu, 17 Oct 2024 04:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729165388; x=1729770188; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=puN6p+bMjYJtsrg56y32J8yDB4IjMscvJ6LWf1rgN+k=; b=joj/OQFSatDca7u8dY5lCMrutSeFxgxQ276Gr5nt1oH0u9K7oQOmW/fxknSPdcZ8Nf bhDCsYl6gBY5VN1IcOS1bu27cyhKKjnXzpwPJJuG8s+Ll9qyw6RVhUczNUFFKPChthky a8WnYZoV8nTY2tUdFkn91y4P3qXbgSuGroc5azkmgld1kG+hm3bvUWOv3uszwwQ3ucaF z2AEL6aigtcDeXdTV25idqxMWcPCS+4chF2+2+MSkcGqusqRmU+P1ywGTjvUfq5QO3iq qGmPQ8w/aBV2ZPmILsyz2BP2rwLszHFCRgKHM6NmPyP2WpRxvAyzy5DQYxvLmT1X06gB akIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729165388; x=1729770188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=puN6p+bMjYJtsrg56y32J8yDB4IjMscvJ6LWf1rgN+k=; b=aph4Y+jb45U12L13oRYh/WRIZCQNUH4uJuXTYBK5tavWNbnskp2Jc8p0/idMDzseBb HYSMeCNSV9vzAvFe6J4DT63/8i623li+HhzREl2U/PKVJ/0iynIHH3vgZFzN3IXd2nFO 9s6a/PYxTvNFQYbgAL9OdHcb01bVCmnh1Be7vXYPNBaQ14hZTc8progJo6XH6H5kiJIJ 52MPZk0cCTvoGhcdu+/SqHiFVbeUrSCTdpyU1zAIGBtGY4NkOYAefSL9YzNaNmAsJmi0 UrouWLHdG0JWLYWpzRKNBft0rUep0C089Kn/MD7YfWqBBwKpIPEmRq8x88JTi8xql2+t 4uIg== X-Forwarded-Encrypted: i=1; AJvYcCWxr6daK1vVtujT5viDh4hb1GDVFtZBTl8W1uKPv8YySq9aJhUyGESLR6GG99Qg3H6E7pyqaVe8tWWQ6Ri1Zcit@lists.infradead.org X-Gm-Message-State: AOJu0YxtDOkGuTZV07t++fZdNMvUYua3WjjGAlzP0UN87B3dGHZOMT2t XFkihIKTy5CyRi55A/9uk6YrpSQ8iKMczCUqxtKo73rzKvS7U/X5 X-Google-Smtp-Source: AGHT+IHJunnh0cmVmNuXc+ArxYGx076cO6tNN4BAqDDpgEMgZwnt3Rmb/lhQ7qL4SW+VAkF2w9+WzQ== X-Received: by 2002:a17:903:22d1:b0:20c:a498:1e4d with SMTP id d9443c01a7336-20cbb2afd17mr267223905ad.60.1729165388225; Thu, 17 Oct 2024 04:43:08 -0700 (PDT) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20d1804b2d9sm42705255ad.184.2024.10.17.04.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2024 04:43:07 -0700 (PDT) Date: Thu, 17 Oct 2024 19:42:58 +0800 From: Furong Xu <0x1207@gmail.com> To: Suraj Jaiswal Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Maxime Coquelin , , , , , Prasad Sodagudi , Andrew Halaney , Rob Herring , Subject: Re: [PATCH v3] net: stmmac: allocate separate page for buffer Message-ID: <20241017194258.000044b3@gmail.com> In-Reply-To: <20241015121009.3903121-1-quic_jsuraj@quicinc.com> References: <20241015121009.3903121-1-quic_jsuraj@quicinc.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_044310_012761_29E7FE12 X-CRM114-Status: UNSURE ( 7.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suraj, Thanks for this fix. I tested your patch on XGMAC 3.20a, all goes well, except a performance drop of ~10% Like Jakub Kicinski said in V2, this involves more dma_map() and does add overhead :-/ I might have a better fix for this, I will send to review and CC it to you. Thanks.