From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9F9CD30006 for ; Fri, 18 Oct 2024 12:45:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L8KQCsIm2jJLt+V4UFoGNRhYBHbHYlHQxpTfoJFr7sQ=; b=eqbVwbRpSq1jqv63sXX6sJZKyD 5/1D7qO5XiAj8yvWdNvYU8TxEPE1Qbq24SJe4HO0JCGktd7mdrmDcyGsKq53Ut3I2xTzQ88fd4I8U eFwkGBboNT5xhWgvYjX9PwUsLWEVYhRWxoalogIQTIjZ7pjX4LV3M8rDvRZ9wUmgqUoAN9e0e/Yh2 3dV4h5RhkbR6CupXrnL2XXztNmxtZ6vgyn3pWb3dXcIVfYtLJg15VNhoCNlCMEjrDspxCLpxTPyU1 ypQ0ix9HuHsUC4r1BNdwHgvx/3gJ7o9APzyQL857HLk23UiyfCMi3jOjZ8UV3WpV/67ivov9u54CK YwgC6j/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1mM2-00000000mpq-2Nf0; Fri, 18 Oct 2024 12:45:18 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1mKZ-00000000mke-2tXS for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 12:43:49 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XVPW31D4tz6HJlv; Fri, 18 Oct 2024 20:42:55 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 29E68140B73; Fri, 18 Oct 2024 20:43:38 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 18 Oct 2024 14:43:37 +0200 Date: Fri, 18 Oct 2024 13:43:35 +0100 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , Subject: Re: [PATCH 1/8] drivers/perf: hisi: Define a symbol namespace for HiSilicon Uncore PMUs Message-ID: <20241018134335.000079f6@Huawei.com> In-Reply-To: <20241018095745.57057-2-yangyicong@huawei.com> References: <20241018095745.57057-1-yangyicong@huawei.com> <20241018095745.57057-2-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_054347_910536_82B7C53D X-CRM114-Status: UNSURE ( 8.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h > index 25b2d43b72bf..008f18bbef7e 100644 > --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h > +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h > @@ -23,6 +23,8 @@ > #undef pr_fmt > #define pr_fmt(fmt) "hisi_pmu: " fmt > > +MODULE_IMPORT_NS(HISI_PMU); > + Hi Yicong, Put the module import in each module because then it is easy to see it right next to the other MODULE_xxxx lines. https://docs.kernel.org/core-api/symbol-namespaces.html#how-to-use-symbols-exported-in-namespaces Otherwise patch looks good. Jonathan > #define HISI_PMU_V2 0x30 > #define HISI_MAX_COUNTERS 0x10 > #define to_hisi_pmu(p) (container_of(p, struct hisi_pmu, pmu))