From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: <will@kernel.org>, <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<yangyicong@hisilicon.com>, <hejunhao3@huawei.com>,
<linuxarm@huawei.com>, <wangyushan12@huawei.com>,
<prime.zeng@hisilicon.com>
Subject: Re: [PATCH 4/8] drivers/perf: hisi: Add a common function to retrieve topology from firmware
Date: Fri, 18 Oct 2024 13:58:15 +0100 [thread overview]
Message-ID: <20241018135815.000028d9@Huawei.com> (raw)
In-Reply-To: <20241018095745.57057-5-yangyicong@huawei.com>
On Fri, 18 Oct 2024 17:57:41 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> Currently each type of uncore PMU driver uses almost the same routine
> and the same firmware interface (or properties) to retrieve the topology
> information, then reset the unused IDs to -1. Extract the common parts
> to the framework in hisi_uncore_pmu_init_topology().
>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Patch looks good to me
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
but it did leave me wondering why there was no removal of property.h
from some of the drivers now all the property stuff is central.
Seems they don't include, it but do include acpi.h which they
should not. So a nice follow up would be to drop the acpi.h
includes in favour of mod_devicetable.h which is needed
for the id tables.
Jonathan
next prev parent reply other threads:[~2024-10-18 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 9:57 [PATCH 0/8] Refactor the common parts to the HiSilicon Uncore PMU core and cleanups Yicong Yang
2024-10-18 9:57 ` [PATCH 1/8] drivers/perf: hisi: Define a symbol namespace for HiSilicon Uncore PMUs Yicong Yang
2024-10-18 12:43 ` Jonathan Cameron
2024-10-21 12:39 ` Yicong Yang
2024-10-18 9:57 ` [PATCH 2/8] drivers/perf: hisi: Improve the detection of associated CPUs Yicong Yang
2024-10-18 12:48 ` Jonathan Cameron
2024-10-21 12:41 ` Yicong Yang
2024-10-18 9:57 ` [PATCH 3/8] drivers/perf: hisi: Extract topology information to a separate structure Yicong Yang
2024-10-18 12:54 ` Jonathan Cameron
2024-10-21 12:44 ` Yicong Yang
2024-10-18 9:57 ` [PATCH 4/8] drivers/perf: hisi: Add a common function to retrieve topology from firmware Yicong Yang
2024-10-18 12:58 ` Jonathan Cameron [this message]
2024-10-18 9:57 ` [PATCH 5/8] drivers/perf: hisi: Refactor the attributes creation Yicong Yang
2024-10-18 13:47 ` Jonathan Cameron
2024-10-21 12:54 ` Yicong Yang
2024-10-18 9:57 ` [PATCH 6/8] drivers/perf: hisi: Export associated CPUs of each PMU through sysfs Yicong Yang
2024-10-18 13:19 ` Jonathan Cameron
2024-10-18 9:57 ` [PATCH 7/8] drivers/perf: hisi: Fix incorrect variable name "hha_pmu" in DDRC PMU driver Yicong Yang
2024-10-18 13:20 ` Jonathan Cameron
2024-10-18 9:57 ` [PATCH 8/8] drivers/perf: hisi: Delete redundant blank line of DDRC PMU Yicong Yang
2024-10-18 13:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018135815.000028d9@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=wangyushan12@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).