From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFEB1D30004 for ; Fri, 18 Oct 2024 13:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ncuyqn+073AbPxn/I9+hmjCT4FTA9wWDxp3oXpndY9I=; b=kfXHb9cTLR0ZcUq9VZb7/6+xno u2SeYp1KkoknPtKJBKIoG1BsWhNqqNgg3YZaZz1IlwPzkOTtxVR6r9+uiMI/IiWImqEjkcVffYY5x vGInWzvvcgVW4PbvOGiniB+bwDLFlq9UkzqR133WHB1asIf9srrgO7zHu77Uloq5/MFDJ8h7gBrIC kjy1GbRsXd4v0/xkAqo5PFfY1X4gEDTilMQzcdfz2KVAQsubeKoEZ7kDJaP94/96BH2s05rdDROed 7sjGfO5G8f3iPMy5o9HHkP04XSW9l2R+gibwew/eIEzPThJ9cpbDyE0tQ1rGned9tC85xTEdn8VrX HbaTFygA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1meo-00000000pTa-15fQ; Fri, 18 Oct 2024 13:04:42 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1mYh-00000000oif-3FC7 for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 12:58:25 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XVPpk5PzSz6GC8p; Fri, 18 Oct 2024 20:56:30 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id D68E71404F5; Fri, 18 Oct 2024 20:58:17 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 18 Oct 2024 14:58:17 +0200 Date: Fri, 18 Oct 2024 13:58:15 +0100 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , Subject: Re: [PATCH 4/8] drivers/perf: hisi: Add a common function to retrieve topology from firmware Message-ID: <20241018135815.000028d9@Huawei.com> In-Reply-To: <20241018095745.57057-5-yangyicong@huawei.com> References: <20241018095745.57057-1-yangyicong@huawei.com> <20241018095745.57057-5-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_055823_990089_47F24AA7 X-CRM114-Status: GOOD ( 10.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 18 Oct 2024 17:57:41 +0800 Yicong Yang wrote: > From: Yicong Yang > > Currently each type of uncore PMU driver uses almost the same routine > and the same firmware interface (or properties) to retrieve the topology > information, then reset the unused IDs to -1. Extract the common parts > to the framework in hisi_uncore_pmu_init_topology(). > > Signed-off-by: Yicong Yang Patch looks good to me Reviewed-by: Jonathan Cameron but it did leave me wondering why there was no removal of property.h from some of the drivers now all the property stuff is central. Seems they don't include, it but do include acpi.h which they should not. So a nice follow up would be to drop the acpi.h includes in favour of mod_devicetable.h which is needed for the id tables. Jonathan