From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3555DD3E180 for ; Fri, 18 Oct 2024 19:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hcgxytGXYLIyCTqmrdHWOX52J6PeMPVqKEGY/Rxl/XM=; b=qslmpc2YAgm0oQzII7h1SLiYOH JbHippnglhnLJRAQHMEpdnKabjWxsNwft4jDqpmuTFHnSlmplsY96mPZ7TAPOHlqIKAk+4VXXlbe9 tKqrG0kX8Jl2tpQ5wC/3zGNBxvUq92eh7YiOT8KWbkN1R0WgW+tScKGBox0C1eL934+8c+rgMj+Io YeQYE88FUBUJkP8ScazmuzfUrs88ARDPfwe6IuyUT3988Vc0pQtS61hqbhFqzrBVk8WgSixta+K0B OhzU6EC2D/QKc3mdVVTPfRixsWY+Fxc0iF5WLJ6vSF7UiKMkK9w96N1AOZfE3qCJJ6G+NoZty8tjb ZHdFFWMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1sZp-00000001n6w-3Wl6; Fri, 18 Oct 2024 19:23:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1sSH-00000001lgX-1QZj for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 19:16:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 32BCF5C57F7; Fri, 18 Oct 2024 19:16:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72AD6C4CEC3; Fri, 18 Oct 2024 19:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729278968; bh=xYNvEAnbruKmoDP7ruTSaK5ufdaOcVknSAix/ef+r18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y1pJU95MTDQzWNjwBOGBqSBSc88jyOcaXW+B8btrDam5hYaxxwALh1I8mrN4YGae6 JZZSZWz4GlaCN8MUEIHo/OuEjdN61Hc4f8aOT4Dap12KKOtHqTUybZeteKpXaPk2ca 5snSdEhdbRJEb4jNzlFqJF2IX1uD1Yu/wbl344qlY34u8VGaWA1TuBtrmV+gIzGakM wjM94j2TUNLOxfKOH7yxwe6H3HW+lkeJBzZbWnLKj7iNwf4OSIRC89WH5jFtGH04Qx /+xqRy67uVAr4JTtV6fHlCAo6KJ5mv5c64paVHipX0UHnWLwAg8FHVr1VPybaB5Tl4 Y2neu3CE10B6A== Date: Fri, 18 Oct 2024 20:16:03 +0100 From: Simon Horman To: Vladimir Oltean Cc: Furong Xu <0x1207@gmail.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , xfr@outlook.com Subject: Re: [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ Message-ID: <20241018191603.GA1697@kernel.org> References: <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> <4557515b4df0ebe7fb8c1fd8b3725386bf77d1a4.1728980110.git.0x1207@gmail.com> <20241017171852.fwomny3wedypybhx@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017171852.fwomny3wedypybhx@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_121609_448301_790868D6 X-CRM114-Status: GOOD ( 12.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 08:18:52PM +0300, Vladimir Oltean wrote: > On Tue, Oct 15, 2024 at 05:09:25PM +0800, Furong Xu wrote: > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > > index 917796293c26..c66fa6040672 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h > > @@ -84,8 +84,8 @@ > > #define XGMAC_MCBCQEN BIT(15) > > #define XGMAC_MCBCQ GENMASK(11, 8) > > #define XGMAC_MCBCQ_SHIFT 8 > > -#define XGMAC_RQ GENMASK(7, 4) > > -#define XGMAC_RQ_SHIFT 4 > > +#define XGMAC_FPRQ GENMASK(7, 4) > > +#define XGMAC_FPRQ_SHIFT 4 > > If you made use of FIELD_PREP(), you would not need the _SHIFT variant at all > (though that would be a separate logical change). +1 > > #define XGMAC_UPQ GENMASK(3, 0) > > #define XGMAC_UPQ_SHIFT 0 > > #define XGMAC_RXQ_CTRL2 0x000000a8 >