From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA305D3E18D for ; Fri, 18 Oct 2024 23:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=AZgnsT0ovejzPrXz8ue4ePFFXWmt8/o5xrJOZL8dFWA=; b=pdiIcTOQY4lA+t FNs14d9kDgLtfROxThtxS13QoN5te19j0pEYLgwFBJ0kONXYT5h2VUzfcKgiR+TtBBDTv5kq14vS/ sL3UD7WtBOUWwJVwRougmBvo/QHLzM0njCrpuOF5lXgtpn/XVQobzhDLWwVSa4uhtCH6347eicUz3 LoHl2Q2EaHHvRuJ3zIAAHTkGCSUcuehcxdLxT+kw6EKh3QDBxgv/9SedchpWWOjk/5Sea9BRg8/76 WxG8qILt2QDCCsXX/tb8rMUL9AU083dmtphso087NSAeqRirlUVhk58eU7exBTLXkU+NfLsyefcVC 38yd5I8MWue1Ud9tudrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1wB6-00000002EIp-3w5W; Fri, 18 Oct 2024 23:14:40 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1w9d-00000002EBY-2zYx for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 23:13:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 65C7F5C2757; Fri, 18 Oct 2024 23:13:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 391BCC4CEC3; Fri, 18 Oct 2024 23:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729293188; bh=PxigYZHsMS7Ka5btja412U+QAgfuxXzExNadMgste3k=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Kj+Am4S1ctlX8aVYBQNWz6oPsMnQEk2nOAo5koJNfIszdt6Eq47C1G2y4R2hy4GAU /ApgU0OfDgBcDCrtPG5CNhY1fPyd7Jmk3ieIqJy7l7+JCBqeIb4q4kwVYj8eUzMjfB 96gbzFf4veNd+v+hUUQOrjJHyFzgroSLHAzHT/pbcS+KXOy9nx0b65aOJ102DyL+it 2h7/KLbWxSgd+e3ZNlxui6WBdDETnzhe3p+EnHbOg3tVCOvdOqUbSxQnw0rLwNLp9r V4It16N9KjDPspAmRWXOIuC0Hq9YHbBgSDLWBDjssKlbniMC7sR42o1d91nFNGqMoV vuTz7ZPuFUEOw== Date: Fri, 18 Oct 2024 18:13:05 -0500 From: Bjorn Helgaas To: Richard Zhu Cc: kw@linux.com, manivannan.sadhasivam@linaro.org, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 1/9] dt-bindings: imx6q-pcie: Add ref clock for i.MX95 PCIe RC Message-ID: <20241018231305.GA768070@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1728981213-8771-2-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_161309_821456_87A50B81 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:25PM +0800, Richard Zhu wrote: > Previous reference clock of i.MX95 PCIe RC is on when system boot to > kernel. But boot firmware change the behavor, it is off when boot. So it > needs be turn on when it is used. Also it needs be turn off/on when suspend > and resume. I think this background would make more sense in patch 2. IIUC, that's where the driver behavior changes to do something with the "ref" clock. I'm not sure how to interpret "Previous reference clock of i.MX95 PCIe RC is on when system boot to kernel. But boot firmware change the behavor, it is off when boot." Does that mean a previous version of the boot firmware left the ref clock on at handoff to the OS, and newer firmware turns it off? If so, I think it would be useful to include information about the relevant firmware versions. > Add one ref clock for i.MX95 PCIe RC. Increase clocks' maxItems to 5 and keep > the same restriction with other compatible string.