From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECA72D3E194 for ; Fri, 18 Oct 2024 23:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H8qZ2j4nlt8K6QWxDn/epfRZeogbkhmwWE6JLmCjJF4=; b=dwkkpXqV5qNgGhRQZ4JXUu8lRD Cxx0M6H3IBdyxjHUhyGTOTO75XRFuQm0iMo0NsLsCUF5LiXrVZVUnv13ry4+JtzMDfuZ92iZmVI3d jS0P3a1xm0A3+vVqsLxzFEExYpYD9WyJWtskwaVv9U9+oU/5AH8S7gWTJpDBTK9EHSqmLW8J50MIw XaPRatHrT/IE+GhhC1l8+iPeUPff86bREZGr6w/aTxPGaVnZwPPzd6sJHRBqnDu+bS+sTVJDCdWMK AEeiRUcDkl3dDmO4jSoWXhx7fy9hIn36nDenNf2TpFtQoeefKsMgGIHw59w2KzcPEAvIy886+kbh/ 3CXb9TTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1wq5-00000002Iqw-3Pfh; Fri, 18 Oct 2024 23:57:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1wnP-00000002IRN-46QK for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2024 23:54:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EB1185C1A47; Fri, 18 Oct 2024 23:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B996AC4CEC3; Fri, 18 Oct 2024 23:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729295655; bh=RaR858kqU+mXXHEjaDtN3IxglEfrcLqxICMUmQVAAvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IOMEAp6ZWhseG8Mo9PInNTHDs1g6NylQzmgQwOGHHtF1OKFq+N45GJamoKNUOLnk+ /b6TSNhnZEkvTEBVQqjOMnoJRljUpiecuCRts/PvIRdJ1B5+23YvKbIF9TFNIm5uH1 TqIaGjkZb6YbFS+mzHprO8Kgmx+ySAlCCN/cRoIvm/5XtxhHmL1/6uWugOR5HtRomq zk1W+CknOt7e++9i5kmildzd2NAgJ8sMvYXmhzwfQjQ2agOxl+rZdlp6gXz1GV1RlD 3yRTreqeXPs/XFT2Y1YkxizRW7l5L7n9LSfndOwpzlzmx1x80uJcVSRv4sOEmArfvB YUFKHqTNNArqw== Date: Fri, 18 Oct 2024 16:54:13 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, will@kernel.org, catalin.marinas@arm.com, Ard Biesheuvel , Kees Cook Subject: Re: [PATCH v4 2/3] arm64/crc32: Reorganize bit/byte ordering macros Message-ID: <20241018235413.GA2589@sol.localdomain> References: <20241018075347.2821102-5-ardb+git@google.com> <20241018075347.2821102-7-ardb+git@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241018075347.2821102-7-ardb+git@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241018_165416_093933_A37C98F3 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2024 at 09:53:50AM +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > In preparation for a new user, reorganize the bit/byte ordering macros > that are used to parameterize the crc32 template code and instantiate > CRC-32, CRC-32c and 'big endian' CRC-32. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/lib/crc32.S | 91 +++++++++----------- > 1 file changed, 39 insertions(+), 52 deletions(-) Reviewed-by: Eric Biggers - Eric