From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50DBCD0E6F4 for ; Mon, 21 Oct 2024 11:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M+fsGeUa6vXF7FzuCSzJVji15RIGxLkArrqUi1vWSVQ=; b=IWGKmxZYNjzoi3jkPRn+ffdc+3 vWZvd77CqxB9mSy6X9nV1Bp8eP0mI/YrO+Ii6j5zBw4zXFOlcASgLp9Xjhla4qiIkrOav5kwQIf67 T7ebeXLtAnyu9taDVgeaSme0wNMM5Lahs1+cBpk7zxOOy/04mealpBZGBvaHZNKWuKHfi3lbFTahr oaakUFe+yWtfz3gNsc0mUqv62NTifILct8zJGns9Oi1vi4TWLgES0kN3vgj+ag8Vo41msX5FioOfM JX16/8YNAiO9hHFsAMcW6+pSPs6bMTVzuxqX31ImtU8golZLi3LfRIvA6o40BDzHlTCY8Ub7OEKN0 5YvrhfDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2qma-0000000752g-2ual; Mon, 21 Oct 2024 11:41:08 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2ql5-000000074lm-2TYX; Mon, 21 Oct 2024 11:39:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 80E005C3C30; Mon, 21 Oct 2024 11:39:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 560E2C4CEC7; Mon, 21 Oct 2024 11:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729510774; bh=1Jme4gIIz82rExq3mwSUQkm+RToEqsxpUietgBS2oSg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f5vzXI40PqiO/ZlFy4X+1+z1D1NpWRCf1cif1g1uQm2wDrhFuMsfqSSF/ZFbgzIiw R5fD+hUD9cSB7EExwMayiYPSr+eIhwNRwT+eNZAPjRLiWgaTRpYfMlzP1To24tsYJs BNqelR2yVFX3CVc9CHWzAvjOv2bLtC2pee4l0VOUzcesZZ4TO6TuYSU9Se3mfXIqMP E+2ledUt4tXX4B1S1ZRSjjJGsbtUIAEVR/5jifJvH4KxZL3k2viKdXXLt8/jDRzKt9 GXbQCiG0VY6cN9f2xjNcS2xbHFrww97RMYBFDc7uYiMefUQUIFjqQMydoC2Kzz8fmF 37Vq06CEigB6w== Date: Mon, 21 Oct 2024 12:39:28 +0100 From: Conor Dooley To: Karan Sanghavi Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] dt-bindings: soc: bcm: Convert to Dt schema Message-ID: <20241021-exposable-seventh-baed2b1442b6@spud> References: <20241019-raspberrypi-bcm2835-power-v1-1-75e924dc3745@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jsNLbNMoOQF7+2+I" Content-Disposition: inline In-Reply-To: <20241019-raspberrypi-bcm2835-power-v1-1-75e924dc3745@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_043935_695547_53EFFDFE X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --jsNLbNMoOQF7+2+I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Oct 19, 2024 at 07:51:18PM +0000, Karan Sanghavi wrote: $subject: dt-bindings: soc: bcm: Convert to Dt schema That's not specific enough about what binding you're converting here. > +maintainers: > + - Karan Sanghavi Why not the maintainer of the original binding? > + > +description: | The | here serves no purpose, as you have no formatting to preserve. > + The Raspberry Pi power domain driver manages power for various subsystems > + in the Raspberry Pi BCM2835 SoC. > + > +properties: > + compatible: > + enum: > + - raspberrypi,bcm2835-power > + > + firmware: > + $ref: /schemas/types.yaml#/definitions/phandle > + > + '#power-domain-cells': > + const: 1 > + > +required: > + - compatible > + - firmware > + - "#power-domain-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include What do you use from this header? > + power: power { The label here should be removed, it is never referenced. Cheers, Conor. --jsNLbNMoOQF7+2+I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZxY9cAAKCRB4tDGHoIJi 0uWBAQDqyXsS9xBwhJafkY9nPgRKoBLTT3Or7JFqALzIN6u6lQD9Fo2HSsTrqOx3 T3mii/cTYz5+jrAlsyvSCkV4PdqMoAA= =Kua4 -----END PGP SIGNATURE----- --jsNLbNMoOQF7+2+I--