From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 598F4D1712A for ; Mon, 21 Oct 2024 19:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3XQpdZ/rAUZNTwVTGuAx3fog3xbkwIYCyZkG1fc+T8k=; b=uvBRcLrybOMRC6ueGgrt2KYy90 VFE39Oo18v1d7VQkD3K8slPse4HVWQ5LpRDCx+GZ//Dfnn5Pmi3D06gDcigKmg+6fElU1b3nnklVq NOpmY3hoRCL26OfxFFqlLVK25+ABFgtyMDVZZZce4qF2PFocN4cGCuh2k10zTKMFBUCffQhc58AUJ xRCnwUj15iAI1MwOkuguAwZjYlTWaJBFIt6XalPx6tyAzOrC3iij9Tnfpkq3SF5vqlN/cM4yIQjcA mwc1SXRB2KvLz2+pg16RG7SugiP6Tp/TdY8uDYuoinZUnF/UqHityoFfz4rC7Pq2aKVu1aRkSpf9Q QmEndx/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2xqr-00000008Pox-2vzV; Mon, 21 Oct 2024 19:14:01 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2xnr-00000008PDY-3cl0 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 19:10:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1729537855; x=1761073855; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5Npb0UB3xjxu34VLa/hXfqiKXjp+NHGyBf4A2zbCrLw=; b=ZLi6nbQngvKxB0vNucueUlvgdV1hqSq9AOrAOBFXWQkQpQUrshdGh3gc UNP2vQ/6cg5aJGen3aYfsm/YV8o0e5oaesIprUBDsZexCEX4ZcbIR16+H AdnkJGYWJNJzMwMIlbH//tpf7FD5rNtPanKlHl2m096NORJ1g78kzE7xM h/qNQlBNX0hklsO+J7iS5bUwuJIfqyFxJxjwCbsyxOn+PIC4NWGAYT/vt aupHRaa4P00XdSdD0z9RDloI39uIukxGRYEW1fvqGsrxUYQ/xxA0ggPo2 nw4OXlNJu32NFzcXsWOu5rTxTvXAY1anguFUd1K1g9w5jvD+pOzuX/2z5 g==; X-CSE-ConnectionGUID: AY5F0AEfSvWQ3nuwGvWjFA== X-CSE-MsgGUID: GZEoHNsmRTe4gsUIApM8fg== X-IronPort-AV: E=Sophos;i="6.11,221,1725346800"; d="scan'208";a="36683189" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Oct 2024 12:10:53 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 21 Oct 2024 12:10:32 -0700 Received: from DEN-DL-M70577 (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 21 Oct 2024 12:10:28 -0700 Date: Mon, 21 Oct 2024 19:10:27 +0000 From: Daniel Machon To: Maxime Chevallier CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , Lars Povlsen , Steen Hegelund , , , , , , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , , , Subject: Re: [PATCH net-next 05/15] net: sparx5: add registers required by lan969x Message-ID: <20241021191027.wgtyhy53ect2xhko@DEN-DL-M70577> References: <20241021-sparx5-lan969x-switch-driver-2-v1-0-c8c49ef21e0f@microchip.com> <20241021-sparx5-lan969x-switch-driver-2-v1-5-c8c49ef21e0f@microchip.com> <20241021193348.7a2423db@device-21.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241021193348.7a2423db@device-21.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_121056_038280_20C94679 X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Hello Daniel, > > On Mon, 21 Oct 2024 15:58:42 +0200 > Daniel Machon wrote: > > > Lan969x will require a few additional registers for certain operations. > > Some are shared, some are not. Add these. > > > > Reviewed-by: Steen Hegelund > > Signed-off-by: Daniel Machon > > [...] > > > +#define PTP_PTP_TWOSTEP_STAMP_SUBNS_STAMP_SUB_NSEC GENMASK(7, 0) > > I understand that this is partly autogenerated, however the naming for > this register in particular seems very redundant... Is there any way > this could be improved ? > > Thanks, > > Maxime > Yes, this might be a new candidate for "the longest name in the kernel" award. This particular register is a concatenation of: PTP (target) PTP_TS_FIFO (register group) PTP_TWOSTEP_STAMP_SUBNS (register) STAMP_SUB_NSEC (field), and as you can see the register group part is already removed. That said, the tool for generating this, can be tweaked to rename registers if required - I will do that here :-) Thanks! /Daniel