From: Conor Dooley <conor@kernel.org>
To: Jason-Hsu <jasonhell19@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au, patrick@stwcx.xyz,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
yang.chen@quantatw.com, jerry.lin@quantatw.com
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC
Date: Tue, 22 Oct 2024 17:54:59 +0100 [thread overview]
Message-ID: <20241022-prayer-unmanaged-86ea24caf242@spud> (raw)
In-Reply-To: <20241022-clean-rebate-e986d6a82a05@spud>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
On Tue, Oct 22, 2024 at 05:51:45PM +0100, Conor Dooley wrote:
> On Tue, Oct 22, 2024 at 10:17:24AM +0800, Jason-Hsu wrote:
> > Add Linux device tree related to Meta(Facebook) Ventura specific devices connected to BMC(AST2600) SoC.
> > Add subject prefix for the patch.
> >
> > Signed-off-by: Jason-Hsu <jasonhell19@gmail.com>
>
> The indentation in here is very inconsistent. Please fix that.
Also, I don't know what the coding style in aspeed in particular is, but
the node ordering seems very random here. Could you sort nodes in the
dts alphanumerically as the dts coding style suggests?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-10-22 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 2:17 [PATCH 2/2] ARM: dts: aspeed: ventura: add Meta Ventura BMC Jason-Hsu
2024-10-22 16:51 ` Conor Dooley
2024-10-22 16:54 ` Conor Dooley [this message]
2024-10-24 16:33 ` Rob Herring (Arm)
2024-10-25 0:08 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022-prayer-unmanaged-86ea24caf242@spud \
--to=conor@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jasonhell19@gmail.com \
--cc=jerry.lin@quantatw.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
--cc=yang.chen@quantatw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox