From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E224D1CDCB for ; Tue, 22 Oct 2024 10:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r6cw9gKWHFwf8NcSsN5u/OGhJ52KInNJQDE50da7E/s=; b=tUYmxWBKTIGmCa9eglsthTVy+E 0PzdXs3hKwAxQDYPvedTZSoggl3ylRoPObHIwAt+MJQWSghexByk87WjdgBY6qQg83v1wv1HAJiXI hpTomsoSWtOFgieoi0Qvoj8BYgrqJNu95D9/bUwaYAJrhyz2jclDtuKAPpsF87FbqABWJGrzso6+h DzDFT+L1i2v0L7s9uGEaKPrPqp6/hv/dvar2CULW49HJA+2yM1qFoU5ye7sqxGDCuKWM+/aPKtR2O Uq9pjFkAifdKgan+g/6nALd5IFw0kUw3CkeIJpxVADCjm1hWgeVBjdU2mNXz1ubb/a/vOVdhHMH7/ PkwCm6uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3BvN-0000000AUmv-3ydp; Tue, 22 Oct 2024 10:15:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3Ahd-0000000AFkv-1NAq for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 08:57:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F24675C5684; Tue, 22 Oct 2024 08:57:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCEA8C4CEC3; Tue, 22 Oct 2024 08:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729587440; bh=htdXVuBg3rUPy01vK1UMoH1g0fkJC7jNj9EenNcP2hY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JP/vevSM6dZ5CjZgbF+JPWInBBZi7QxSxJQTeGlIWg4akANwQIckgvexhbnWL4uPy 9ZzayKAMqBVoWK+ABAtNcRmIJfYlXCSU+XEbMvramqx7wYKW2/Jj3veRaNCIWXrVJ1 oMzmfx7lge3QWaBBImJajqh2XMT95tj9lT/UGVvDFlCmWFFYPl0ffhdevYA+2exIQh LktrII0F290bHJXSnwI9GsMOyJ/VFwqGtZarQ2Z0rfXQ5orovIHK/QDRWKgStsBCy4 S9M9HVb78xbTglVJx5FOlqFDQ5ZKG+FZwVkDy34SDkEz0WPkrmqtCjeKcjS+WveQ25 9D9nvKQzc2rFg== Date: Tue, 22 Oct 2024 09:57:13 +0100 From: Simon Horman To: Daniel Machon Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , andrew@lunn.ch, Lars Povlsen , Steen Hegelund , horatiu.vultur@microchip.com, jensemil.schulzostergaard@microchip.com, Parthiban.Veerasooran@microchip.com, Raju.Lakkaraju@microchip.com, UNGLinuxDriver@microchip.com, Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , jacob.e.keller@intel.com, ast@fiberby.net, maxime.chevallier@bootlin.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 01/15] net: sparx5: add support for lan969x SKU's and core clock Message-ID: <20241022085713.GR402847@kernel.org> References: <20241021-sparx5-lan969x-switch-driver-2-v1-0-c8c49ef21e0f@microchip.com> <20241021-sparx5-lan969x-switch-driver-2-v1-1-c8c49ef21e0f@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241021-sparx5-lan969x-switch-driver-2-v1-1-c8c49ef21e0f@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_015721_437101_8A9E0CAB X-CRM114-Status: GOOD ( 17.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2024 at 03:58:38PM +0200, Daniel Machon wrote: > In preparation for lan969x, add lan969x SKU's (Stock Keeping Unit) to > sparx5_target_chiptype and set the core clock frequency for these > throughout. Lan969x only supports a core clock frequency of 328MHz. > > Reviewed-by: Steen Hegelund > Signed-off-by: Daniel Machon ... > diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > index d1e9bc030c80..f48b5769e1b3 100644 > --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c > @@ -475,6 +475,20 @@ static int sparx5_init_coreclock(struct sparx5 *sparx5) > else if (sparx5->coreclock == SPX5_CORE_CLOCK_250MHZ) > freq = 0; /* Not supported */ > break; > + case SPX5_TARGET_CT_LAN9694: > + case SPX5_TARGET_CT_LAN9691VAO: > + case SPX5_TARGET_CT_LAN9694TSN: > + case SPX5_TARGET_CT_LAN9694RED: > + case SPX5_TARGET_CT_LAN9696: > + case SPX5_TARGET_CT_LAN9692VAO: > + case SPX5_TARGET_CT_LAN9696TSN: > + case SPX5_TARGET_CT_LAN9696RED: > + case SPX5_TARGET_CT_LAN9698: > + case SPX5_TARGET_CT_LAN9693VAO: > + case SPX5_TARGET_CT_LAN9698TSN: > + case SPX5_TARGET_CT_LAN9698RED: > + freq = SPX5_CORE_CLOCK_328MHZ; > + break; Hi Daniel, It is addressed in patch 12/15, but until then pol_upd_int will be used uninitialised later on in this function when this case it hit. Flagged by Smatch. > default: > dev_err(sparx5->dev, "Target (%#04x) not supported\n", > sparx5->target_ct); ...