From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10699D2CE05 for ; Tue, 22 Oct 2024 17:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3JEQ9MM+0bQRBQpufIz+g9Ep0xv8kpXfh0HhFXLCte8=; b=YfJT2/6c2VafD4s8u3q4RdSE3M +gBsHTk0l9mCyQZ+/gd5CFL4VHRd+6Ux/MH1jneDrpmqvU5kx96TYhSvmsq3xxaXhfIjA4Eg3LBaw lznsHo88evovaviWlnGmOZVsg4lUMtwpI+4dn/Nj7tCoypV7UwnU9ZAjLlkh3+L/93MBQLbCH1/hT Pdyf8lqsFkYON9a6RdkQrf7XT+4/rN6i3ByVfmulZ6rUoHM5YAnHdk8BI1idhEWeI+dlgnazbBI0m oICNRoPwDdDZGTC2/DT6aHfRJCv3FH6fMgi6HTLc9hMCGKqjLHS9ZjnJCiwSAU8+z6MCVbX9U5MLz PK4j3eTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3IIz-0000000BaV4-3hsc; Tue, 22 Oct 2024 17:04:25 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3I3H-0000000BWxM-1kJO for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 16:48:13 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20c70abba48so48622935ad.0 for ; Tue, 22 Oct 2024 09:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729615690; x=1730220490; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3JEQ9MM+0bQRBQpufIz+g9Ep0xv8kpXfh0HhFXLCte8=; b=BDnHEqEiBUH3sz2nYrnVgYIwm5P14JWdvD8Tr7mf321dWklLqy/CKiTtEZFMwmWQ0a BCTs4gXeO5SaBmt5Cd4IflqI0dAhUfJzC5W0gtS/P6cWZq1e2PAQla/U4+aQjyak3sg3 8JtlGhMIJXvXhof4Nx7ar/n1s/tTl0KFr7KnLcdXl7CexyRDu9viSxuJsraUkz1zspUX g5BCj6FgvGJuk5zXyZPfWQ1NkyiQ++Qs/oaaFf7rpD9Jjy5mr2vKwFGAGhyQgeSl7p+Q oRZ4aG39CpXrh93NIHSacl7JCABmeIYwiZsa4Q5Zi4nFQqMERwwE3euuKT8JajWkN7C0 zUVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729615690; x=1730220490; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3JEQ9MM+0bQRBQpufIz+g9Ep0xv8kpXfh0HhFXLCte8=; b=obpBVr72XnRFtOBbGK/VDi0speLO7rRm87fKsyOdK42XjLSgMqqFgXUeVL/1pio+ID p6TM8uK+GGcY8lSuOhDG/560csIf0ngMaCArqOf9uq77HiyDqdXHhs4+y7k5aWFMeNHh pTRJUlmJ59hA1+05pwdtqTIkIT0X20n/gaSo+j9jggF22mzpiCDEFHMl6qP8CCTuN4l2 bOlFgUb1CR+170X4ZE4K1HkeLB3Cx2cND0mOrci07bTs0MZp3HuljFITpf2keRIv3xxn ZT9SbKO36+zAYjpcJ6te6tNqOJ/l3WUTuxbM+CWrwcWipNCMEaYIvBhfKb93z/rlAzhK 98pw== X-Forwarded-Encrypted: i=1; AJvYcCXYkNx8NxNfdqmaudaorYmihSv8T5ckS4dWxsc62aztMEcLLWbNbBIOYlmqWPMeXz7NCmJ3ubsI37YEGQJ07ZCI@lists.infradead.org X-Gm-Message-State: AOJu0YxnzL8a9IC6tVBtOI/LaXrQjEzxNjZxPGzof6JBNFug4e6wZoFb oapYRzUpVHBCvFTud2MPUqQ36cvFbIZiypUoZDMDgzrTPNdCRNyFPejv1n1mDQuF1GwATI3R9yg = X-Google-Smtp-Source: AGHT+IFa07tHycQZi4y8Cv96iyWVS9+/qqyom7Z+lob5auNlXr7DiOgX6ejk3Gy2vlhqcjfCd1hWNw== X-Received: by 2002:a17:902:eccc:b0:20c:ca83:31c7 with SMTP id d9443c01a7336-20f54395ebdmr472615ad.54.1729615690130; Tue, 22 Oct 2024 09:48:10 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f10dbf9sm44820105ad.308.2024.10.22.09.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 09:48:09 -0700 (PDT) Date: Tue, 22 Oct 2024 22:18:01 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: kw@linux.com, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 3/9] PCI: imx6: Fetch dbi2 and iATU base addesses from DT Message-ID: <20241022164801.h7eh2gkuiy7pfkmr@thinkpad> References: <1728981213-8771-1-git-send-email-hongxing.zhu@nxp.com> <1728981213-8771-4-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1728981213-8771-4-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_094811_491847_AE0E7E0C X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:27PM +0800, Richard Zhu wrote: > Since dbi2 and atu regs are added for i.MX8M PCIes. Fetch the dbi2 and iATU > base addresses from DT directly, and remove the useless codes. > Again, what will happen to old dts that don't define these regions? - Mani > Signed-off-by: Richard Zhu > --- > drivers/pci/controller/dwc/pci-imx6.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 52a8b2dc828a..2ae6fa4b5d32 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1113,7 +1113,6 @@ static int imx_add_pcie_ep(struct imx_pcie *imx_pcie, > struct platform_device *pdev) > { > int ret; > - unsigned int pcie_dbi2_offset; > struct dw_pcie_ep *ep; > struct dw_pcie *pci = imx_pcie->pci; > struct dw_pcie_rp *pp = &pci->pp; > @@ -1123,25 +1122,6 @@ static int imx_add_pcie_ep(struct imx_pcie *imx_pcie, > ep = &pci->ep; > ep->ops = &pcie_ep_ops; > > - switch (imx_pcie->drvdata->variant) { > - case IMX8MQ_EP: > - case IMX8MM_EP: > - case IMX8MP_EP: > - pcie_dbi2_offset = SZ_1M; > - break; > - default: > - pcie_dbi2_offset = SZ_4K; > - break; > - } > - > - pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset; > - > - /* > - * FIXME: Ideally, dbi2 base address should come from DT. But since only IMX95 is defining > - * "dbi2" in DT, "dbi_base2" is set to NULL here for that platform alone so that the DWC > - * core code can fetch that from DT. But once all platform DTs were fixed, this and the > - * above "dbi_base2" setting should be removed. > - */ > if (device_property_match_string(dev, "reg-names", "dbi2") >= 0) > pci->dbi_base2 = NULL; > > -- > 2.37.1 > -- மணிவண்ணன் சதாசிவம்