From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9BA0D2CE0E for ; Tue, 22 Oct 2024 17:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zskhD/XRFsF8+SNavxZpLN+TdPJ3gjMLO/S0bb2gB5s=; b=qfAYHloR5dDtsIpY1ON5hmoPTD RRWR5bwShN0vs/eZ0zw3UWzlsI5sXWESueRhDRzzst8ib84uxeyPjqFuwdkQGPsgFngCnqnSPtCDo UgWDg6N4d8nyBt8csp48goo0z4j0DNzKVmt6hRlwPxUkUsBNfI6TEAeJXju4UESv1t+kXzyn3vMav XtiL+YJs5nhhqhECBOJ6g2Q6CN+pa80Whn5RGOv6psUkrm+a5p6gAn3WB1uJsfuOJUDf48eBLACFU sX7pshdblf0wrC7xIi0Nh36vlRmaHUy4UQj3zRhMyeRFa1N5SxeaJDmkeAzioSPQ1cWdfjmVVrAeU ZQrIJiPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3IbZ-0000000BdN3-2QWV; Tue, 22 Oct 2024 17:23:37 +0000 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3IAl-0000000BYks-3PbC for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 16:55:57 +0000 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-28847f4207dso2659956fac.0 for ; Tue, 22 Oct 2024 09:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729616154; x=1730220954; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zskhD/XRFsF8+SNavxZpLN+TdPJ3gjMLO/S0bb2gB5s=; b=NdQDWeWbTnjj5JpyAZsT6FBmiReoWCuTtY2d0AuG53Lt8dj46V0yRJ7xyw1kneullN 8WS8OBAACJtEJvHyM6h81R0GLBOVja/57VzRZuJN5B/s9ED7ahjU9SP/JkHIgmevs7Ps DHxI23ZkNJF4ade+2PmcUT6LzuIjF+OINyQd3kZ0P0jh9PQfHCy7zxabxg/L/SPi0Hcd MyeWWYYv49eDM/Z8olTDNYm/kS8FBcg0BFtj1o49MFSTMzMuLdZ8AIIOwMV8/6k+eOd3 Z7gqla5D4iVHV5eyhJCOdPiSAsz81lu+p21ssK3thmnDuXvXeEVxT+zjBfEQUlnMH62Q 6WSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729616154; x=1730220954; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zskhD/XRFsF8+SNavxZpLN+TdPJ3gjMLO/S0bb2gB5s=; b=THJXJAndJM6WhGgW+OzzdHu7UbOvDQllIFsY0kryWcbH1YholMwvxJxKa8PQSExzDN vKW6s3rWOpsvC/lYcI/xBkjt4qNA+gsz2CVGyFKWJsK68bGBldmpphexWF+aahY2ghLa Ay8W2qMChbPUUiJGOTi7OfaYivVy7KUGE/FJKP4yXNsgJ76k9bFXnLEIY6QKmOECXvm5 /CjQlwdupP1jjKmvOoMuOadwpfh45OXlsWeq0Ua1hYwcUTmMx27II5vCUnIyeCo5B74Y Hr3ZN/9i6GmCHW17GJtuGQe1bf5Zm8kVZbEZ53FDFPCSfuroIUGtDVqEDSwMEnGWWpom A2XA== X-Forwarded-Encrypted: i=1; AJvYcCUx+O0ibIk2AUMwjcWQ/T5fOw8LEFKwormItsNtGfJuIAQS3plgZvdvi9/EMPevV9lpFwLjNjga7TTmgyyc32Mp@lists.infradead.org X-Gm-Message-State: AOJu0YzYU+DlZg7yT2df+s8sTMPP32mrWAEBQnPAHylOCQYC8V9vSRK4 Vmlyg204SCiSOjsss3JUYGnpwUgt/+aCC8KgILDIxSvzMB6Wx9meqrkoppLLiw== X-Google-Smtp-Source: AGHT+IFKRfaJmVMFGvKwHBrjJenW7+/BJEzp7GEOtf7Mc+QC+1nScED+0joTknXDkn7LCJudmbfjfg== X-Received: by 2002:a05:6871:b11:b0:270:1fc6:18 with SMTP id 586e51a60fabf-28cafeb6995mr3491513fac.3.1729616154369; Tue, 22 Oct 2024 09:55:54 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ed9957ba9csm424994a12.82.2024.10.22.09.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 09:55:53 -0700 (PDT) Date: Tue, 22 Oct 2024 22:25:48 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: kw@linux.com, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 4/9] PCI: imx6: Correct controller_id generation logic for i.MX7D Message-ID: <20241022165548.6qhxt7dsd7m7i2tv@thinkpad> References: <1728981213-8771-1-git-send-email-hongxing.zhu@nxp.com> <1728981213-8771-5-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1728981213-8771-5-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_095555_885723_FED8576B X-CRM114-Status: GOOD ( 19.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:28PM +0800, Richard Zhu wrote: > i.MX7D only has one PCIe controller, so controller_id should always be 0. > The previous code is incorrect although yielding the correct result. Fix by > removing IMX7D from the switch case branch. > > Signed-off-by: Richard Zhu > Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 2ae6fa4b5d32..ca8714c625fe 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1338,7 +1338,6 @@ static int imx_pcie_probe(struct platform_device *pdev) > switch (imx_pcie->drvdata->variant) { > case IMX8MQ: > case IMX8MQ_EP: > - case IMX7D: > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) This is just *wrong*. You cannot hardcode the MMIO address in the driver. Even though this code is old, you should fix it instead of building on top of it. - Mani -- மணிவண்ணன் சதாசிவம்