From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83A42D2CE0D for ; Tue, 22 Oct 2024 17:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VS3tXfWam2DO1i7ilVLotgRr0xGMHWMFEHP5fSK9K/M=; b=ghydhKZsG+1Rv8vomn9O9w9ijF Gq5iixjPSme5kt6LTo40oy3P62iy0YHIGJ1jrVsbPSX9S29oNCnGrWJdvVs42nHUwiVBIbW0Dwg+q ne6qNjpYljcPhPKZEiaw9RXLhGoNMWZBrB9TJ1DfBxPhnIgcJxSLzzpPl1y8pLLpjdBa0IQFAJS52 xCRgO6n5YuuAozNdzx1179HivnPcHb2Mpi9O/d6fovUWM06dhOpNlLPne3ap3sz/ljXIVvUqV73Fd cng669Jbvp4ia3yG4jBH7leffJVJJEQkXj4Y0xsKgEmuojhf/cpiPQ9rRZgoSLMp//dJh4EoXyQta b59dKyRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3IhW-0000000BeSj-31wu; Tue, 22 Oct 2024 17:29:46 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3IEe-0000000BZZs-20uf for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 16:59:57 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-20cbca51687so58824795ad.1 for ; Tue, 22 Oct 2024 09:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729616396; x=1730221196; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=VS3tXfWam2DO1i7ilVLotgRr0xGMHWMFEHP5fSK9K/M=; b=rHkEFCc9+GYeTphuTZsNBMa076PIMS/MVXl2YGMrLtO3OoVdg4U+67+d3pay4drnPv rPTB5nGqsCeQ1DCoPD8EIQI6+DpubowOGN0r6Qe/6BxezK/gzc9hsO+s0rmE+9xou4qU L2vSWWoXOBknI/Di6HxgJHWmwXxKV3U7mjnEfqTY46QT3bWul9daev2iUkPbM3dRFF3y jtH35fv3a6JT83jl6LCP1rUOJUZ6o9DZRvBdievKnihq25niRtc2xMUWD/D1z/cgxvGf QrMA6Q7nqsW/Dgy26OHxRbmVhb8VudSZEIiexdUp0/k/LNe882kbDKNTa+DmDLq6uaqn x7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729616396; x=1730221196; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VS3tXfWam2DO1i7ilVLotgRr0xGMHWMFEHP5fSK9K/M=; b=trKUWv9JSQ6z2q/qGU0H7Cg6FWpexI4ZHVmCqoqldaZ1onwUO8vbKMWJIU+jJTabjr qfSa7pUsZ/Nj+xXjWbhxCNdmthvnc/lhJuUGEp7yJW+uctj8Qg8W8Uzuuq/zj4tX1NNJ y9w4bUzG/o6iuFgkOZWRN8/d6Kh32sMmbVDxgD3P/toneE3Dn2ly7LmjyVftRKdiqEUv XtwxJY9doh9bhrfxO+OGa45nn5neRC1F6eSOUnweZgLRUPcVrXnJtnpP7J8pDgdugl8b G13xhYLXwrgYaiaxBvqa6vX8ecg/hgx0SEm3XrhEQyIqjLtdgnymxlV5Usit7lfu8lMu AI0Q== X-Forwarded-Encrypted: i=1; AJvYcCWk318Kv3JnlvDIt31j9IYDeHOhDEZfOgwMFSRfou8Ukj11J0pf4Kw4d2Pk2ZVEchXPzZAIbH3GkPcBEYYV10vG@lists.infradead.org X-Gm-Message-State: AOJu0Yzqrsp2v5J7CV9BNCTdvvq85chmwxz1AnyUijrRMrkbyizYxM6J KYR27dTw9yzHT2DIylvR7oRjZM0Z/PyX53pib84e/jxmrYjR9CClouJgyiXqOA== X-Google-Smtp-Source: AGHT+IEYx820a1axe7TYA5uJ7U5XpkZcGO8wslMBvWfwxZnRbZqXMJz1tinZzuebUznia7UTdzMS7g== X-Received: by 2002:a17:902:ea0e:b0:20c:8331:cb6e with SMTP id d9443c01a7336-20f39628369mr1028375ad.19.1729616395600; Tue, 22 Oct 2024 09:59:55 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7f0bf197sm45044345ad.150.2024.10.22.09.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 09:59:55 -0700 (PDT) Date: Tue, 22 Oct 2024 22:29:49 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: kw@linux.com, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 5/9] PCI: imx6: Make core reset assertion deassertion symmetric Message-ID: <20241022165949.dn6wzgeocond2ia7@thinkpad> References: <1728981213-8771-1-git-send-email-hongxing.zhu@nxp.com> <1728981213-8771-6-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1728981213-8771-6-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_095956_553774_23C46606 X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:29PM +0800, Richard Zhu wrote: > Add apps_reset deassertion in the imx_pcie_deassert_core_reset(). Let it be > symmetric with imx_pcie_assert_core_reset(). > Am I correctly interpreting that this patch adds the *missing* reset deassert for 'apps reset' line? If so, then there should be a relevant Fixes tag. Also, there should be some info about the implications of not deasserting it. - Mani > Signed-off-by: Richard Zhu > Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index ca8714c625fe..93e2bcf9aa0a 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -770,6 +770,7 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) > static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie) > { > reset_control_deassert(imx_pcie->pciephy_reset); > + reset_control_deassert(imx_pcie->apps_reset); > > if (imx_pcie->drvdata->core_reset) > imx_pcie->drvdata->core_reset(imx_pcie, false); > -- > 2.37.1 > -- மணிவண்ணன் சதாசிவம்