From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B30CBD2CE0D for ; Tue, 22 Oct 2024 17:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ApU3fV+UtKxcEYZyM6H87gs38rNpBSSNhr/eTWWEXY4=; b=VL8LwR1XqIWYnMqoPdwIFqJPUC luKdxhVNcdhfrrv548PswqMYJ+IUrphEGD+ke4Qw3ZAUsc7HgJK8lAvkl+rElg+uG9D0TEJ4nl9Ra Yyie+9zhiNmq//8c19/UCZiUF9CBVlD4O3OsixbGA1Nug08BY7xwlhNaYJaaXiAcVWJ6yFFzYt0wo mwvEs9uhBGGzcxr5xoX0bBY87v7WF0533JKFwNWWs/GpvhjuSMqQj5GrPNNNP6u9G93+KisPYyAq8 lXJrCLppEnx4YpYBPMHGHtg986LG8sGdSVrJv3z0bYTsm7BTwQ3EAElbham6USyQEOtMKlakcqeXw Xj8/MYaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3IkZ-0000000BfBl-2211; Tue, 22 Oct 2024 17:32:55 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3IJu-0000000Bacw-3hQN for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 17:05:24 +0000 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2e2fb304e7dso4802988a91.1 for ; Tue, 22 Oct 2024 10:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729616721; x=1730221521; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ApU3fV+UtKxcEYZyM6H87gs38rNpBSSNhr/eTWWEXY4=; b=cM1AJZFRlJcjZCfnnhcUBwbIULMp12+rN4yTeWxN2esdQKtaiJWWoEuzxYuB4+a9Lj nB9LiWx+tZkAT6JPKK9qi+1bI2xM7owLSWWjPbfQGQHfjuqmVbO5W9TnswXNH1ycMSFg B1fbSegvTuPy646hbxWtocky0imD+obzpHgwmA3KxX66U5cWEAJ0wvA8fnRDnbiX1FYb U28ojL43/yhSURVP/AN3h7UdymXuHD/TV00tYlKdtpFhppn1UwBbOyEMyzuId4OjlXuc N2yJ4CuXzbeoFBriSLi+m75vyCW7IocHqS/gvtg4vsBIzwf6LqOmcKPk7NdZtUIkne5r UiXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729616721; x=1730221521; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApU3fV+UtKxcEYZyM6H87gs38rNpBSSNhr/eTWWEXY4=; b=oZTs9ZNVUFEP+yXIHjkyOEVYn7UHIorvx7wi/w7nwa55oO0sJaXOIslajxOhNfe1N2 3HRiifHF0fnGCzR339yJXjMmJGIf8VFd2ANFZppIrAwmwJMMJnvI31YnLBjVR9mUGOsd WZx/gqW7hugRMqHhw4bolruIFn+YWg8MNq2OIawR1fG03CIN2ekkBrcYyZSRurOrFt1L omxtG6tdY7iakPXTgIaChwtIhkFRKxn97WMxu+BJk2GOdMpFLpwHF9DisafzOYQBNAiN yDZzrZ9tUTOPhNwUuqxk7d61kVDO0uuZSxK4SFrZu/j7VmutSjbDSOm8p9GT2ZFnvV+f 3NEA== X-Forwarded-Encrypted: i=1; AJvYcCVQrIvGYHpqdpA3z3kB63I6hj1cbdvV9rQoqxi3yNMwQD+7B/tWvbTiSnDNV1PKLJ8u/F36Igc0HBAEnAdj+vlI@lists.infradead.org X-Gm-Message-State: AOJu0Ywq2C6Sj/S2FW0MCImLG7cZUtFr73R1H+BOoiFNV2Ir5J5aT6Ve /Y3+jUBnOVvODGfEcTubDfoYLdT+SzPhPLmdxPcp+/y91U89QlDMK40dFNgflA== X-Google-Smtp-Source: AGHT+IHRqsW0sRulSaBfDKEdAZUSpR9q80CX2UTyubbP2o+xbSDVjhZp8NPAD81dLI0BL9hvAVo41w== X-Received: by 2002:a17:90b:1185:b0:2e2:cef9:4d98 with SMTP id 98e67ed59e1d1-2e561a01146mr16890078a91.25.1729616721232; Tue, 22 Oct 2024 10:05:21 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5ad389146sm6432096a91.26.2024.10.22.10.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 10:05:20 -0700 (PDT) Date: Tue, 22 Oct 2024 22:35:14 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: kw@linux.com, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 6/9] PCI: imx6: Make *_enable_ref_clk() function symmetric Message-ID: <20241022170514.s6ejwj2w64nivqui@thinkpad> References: <1728981213-8771-1-git-send-email-hongxing.zhu@nxp.com> <1728981213-8771-7-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1728981213-8771-7-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_100522_948375_CB234B5C X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:30PM +0800, Richard Zhu wrote: > Ensure the *_enable_ref_clk() function is symmetric by addressing missing > disable parts on some platforms. This warrants a Fixes tag. And the patch subject should be something like, "PCI: imx6: Fix the missing reference clock disable logic" > Also, remove the duplicate > imx7d_pcie_init_phy() function as it is the same as > imx7d_pcie_enable_ref_clk(). > This is a cleanup, so should be a separate patch. > Signed-off-by: Richard Zhu > Reviewed-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 33 +++++++++++---------------- > 1 file changed, 13 insertions(+), 20 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 93e2bcf9aa0a..161daad34a94 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -388,13 +388,6 @@ static int imx8mq_pcie_init_phy(struct imx_pcie *imx_pcie) > return 0; > } > > -static int imx7d_pcie_init_phy(struct imx_pcie *imx_pcie) > -{ > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX7D_GPR12_PCIE_PHY_REFCLK_SEL, 0); > - > - return 0; > -} > - > static int imx_pcie_init_phy(struct imx_pcie *imx_pcie) > { > regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > @@ -593,13 +586,13 @@ static int imx_pcie_attach_pd(struct device *dev) > > static int imx6sx_pcie_enable_ref_clk(struct imx_pcie *imx_pcie, bool enable) > { > - if (enable) > - regmap_clear_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX6SX_GPR12_PCIE_TEST_POWERDOWN); > - > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > + IMX6SX_GPR12_PCIE_TEST_POWERDOWN, > + enable ? 0 : IMX6SX_GPR12_PCIE_TEST_POWERDOWN); > return 0; > } > > + Spurious change. - Mani -- மணிவண்ணன் சதாசிவம்