From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD5E2D2CE12 for ; Tue, 22 Oct 2024 17:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EYyTRaKGn0PVJQtdVRYtFHSxQ4TFBsfP/i6X4tjAirc=; b=o4WTdZ7ATnywKNvtg468IMX/Nc uWsKYWzmDGhscrSqctjpOtJG7PGhPbhBWfEYM1c6jaZC7wnZhywPmyS6A6yN7DgHH5WcF/eVC1tm0 EE9nUgdCHLdrfDWCc4JGd1Fgum9re2OlEypNH5r/oGWknIzu8ZjN8leCvFnbcAYBg3Bp80EEN2UDd cFC1rpih9t0EhuBjKBn0m3BDn+ozgjXSQ+p6UX2jQi0CD17HnDkVht3ZC83fIMC2RXyuh0js3F3Ye zEQ8j2H4hiZ6cP5ExsLh+koarRqBxK9qzIud1IP8efvMg2SCmPv8Q/y2ulZatW7lBPFtvISm6FLHn v3UC0ZNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3ItY-0000000Bh5q-3IgS; Tue, 22 Oct 2024 17:42:12 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3IZA-0000000BcuU-1QQf for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 17:21:10 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-20cdbe608b3so48627465ad.1 for ; Tue, 22 Oct 2024 10:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729617666; x=1730222466; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EYyTRaKGn0PVJQtdVRYtFHSxQ4TFBsfP/i6X4tjAirc=; b=SeYqd7xG37h4LOg3PVTdJWbVoUCE5O8JktvEXNqf+O6gdPtONS1B2oWNUojySBl7AU EDA41wrZ76Piz6HIYfDH6mFEFpIOK2oQ7Q25njZ5P7k6QvRkUVDsbUpCZW9lTk0Y7c6d 8Exy4UcLzL2rmWa4YDu+REClvGX30a11wlNS1DX/HdCrSUwkGow1WZjt5gpV7Fq2ubxv YaRllIB3e6tUdbQIrKh6tcOezNpHdOgLoyaA3SdkjyCv6P6n7mbNNbP36hPBrIXbZV9Y OBajla3B4xIR1gLVNySxc9pXmGFJKyM6XS3+qfAnwtwZtJ+eCBcB0Y/IDgEMYImZNfpg rRqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729617666; x=1730222466; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EYyTRaKGn0PVJQtdVRYtFHSxQ4TFBsfP/i6X4tjAirc=; b=xCTtQkCJHT+kW4Sh7JY+yDTiCsZBf7/lALOSvocjofGyZ/rULeRkymdwlfo+KlECLy pWNawH5QSSt/CWVO8xo3ZZUh/qoiibqirlAcYlQLNC+KhRg5KUTsxAb+AGGrL06Oln0e 9nyRn/X0cyYcSdusybzD/dxdHjhrEJiIRh/3BIpTu/uQc/0k6E4p7Gn2vbaCo2OogGZ6 nXJ6IMMsK7ogmy2PgajoNzkZDiJ3YY32ENPz3hYSy8/t23fB9o7xL4P5h4euX/cDFEpu DB/6GYmw763WosNTrr++WXtqzwrztc+aHK/wze32ZHBlNQwq4dMsW9nKGi/wKr1jiLdB lw6A== X-Forwarded-Encrypted: i=1; AJvYcCWbgc1lAppUT5ksMslt86RbV9sC4l4h3LaZx7+seGbYfbl+mMpkjiumeA6Gl9HX61ewrues+qLFgWq11lgq0Z2N@lists.infradead.org X-Gm-Message-State: AOJu0YyhWGNHFERNHqw408+3ZQ3kP7KMYtI1+H3vSh0u7lu3JdJaFnji s54BcOEFvnqdIqEy+UCSa+WJbDB/3ovwLHPrMdR/I7GCVefMQsrkXMUVziR+pQ== X-Google-Smtp-Source: AGHT+IEFhMlMl+SifAdPrVg99u83uazLX/A9KcHRvv7Tuv35akUo2976i/YilQVOuBqYd19nUmnDHQ== X-Received: by 2002:a17:902:da85:b0:20b:6f04:486f with SMTP id d9443c01a7336-20e9489afa8mr44178795ad.18.1729617666017; Tue, 22 Oct 2024 10:21:06 -0700 (PDT) Received: from thinkpad ([36.255.17.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20e7eeef535sm45591245ad.44.2024.10.22.10.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 10:21:05 -0700 (PDT) Date: Tue, 22 Oct 2024 22:50:59 +0530 From: Manivannan Sadhasivam To: Richard Zhu Cc: kw@linux.com, bhelgaas@google.com, lpieralisi@kernel.org, frank.li@nxp.com, l.stach@pengutronix.de, robh+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, imx@lists.linux.dev Subject: Re: [PATCH v4 9/9] arm64: dts: imx95: Add ref clock for i.MX95 PCIe Message-ID: <20241022172059.wuw5xel7m4vobarq@thinkpad> References: <1728981213-8771-1-git-send-email-hongxing.zhu@nxp.com> <1728981213-8771-10-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1728981213-8771-10-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_102108_426496_945AE6CD X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 15, 2024 at 04:33:33PM +0800, Richard Zhu wrote: > Add ref clock for i.MX95 PCIe. > > Signed-off-by: Richard Zhu > Reviewed-by: Frank Li > --- > arch/arm64/boot/dts/freescale/imx95.dtsi | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi > index 03661e76550f..5cb504b5f851 100644 > --- a/arch/arm64/boot/dts/freescale/imx95.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi > @@ -1473,6 +1473,14 @@ smmu: iommu@490d0000 { > }; > }; > > + hsio_blk_ctl: syscon@4c0100c0 { > + compatible = "nxp,imx95-hsio-blk-ctl", "syscon"; > + reg = <0x0 0x4c0100c0 0x0 0x4>; > + #clock-cells = <1>; > + clocks = <&dummy>; > + power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>; > + }; This is an internal reference clock, right? Please mention it in patch description since the controller supports external reference clock also. - Mani > + > pcie0: pcie@4c300000 { > compatible = "fsl,imx95-pcie"; > reg = <0 0x4c300000 0 0x10000>, > @@ -1500,8 +1508,9 @@ pcie0: pcie@4c300000 { > clocks = <&scmi_clk IMX95_CLK_HSIO>, > <&scmi_clk IMX95_CLK_HSIOPLL>, > <&scmi_clk IMX95_CLK_HSIOPLL_VCO>, > - <&scmi_clk IMX95_CLK_HSIOPCIEAUX>; > - clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux"; > + <&scmi_clk IMX95_CLK_HSIOPCIEAUX>, > + <&hsio_blk_ctl 0>; > + clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux", "ref"; > assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>, > <&scmi_clk IMX95_CLK_HSIOPLL>, > <&scmi_clk IMX95_CLK_HSIOPCIEAUX>; > @@ -1528,8 +1537,9 @@ pcie0_ep: pcie-ep@4c300000 { > clocks = <&scmi_clk IMX95_CLK_HSIO>, > <&scmi_clk IMX95_CLK_HSIOPLL>, > <&scmi_clk IMX95_CLK_HSIOPLL_VCO>, > - <&scmi_clk IMX95_CLK_HSIOPCIEAUX>; > - clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux"; > + <&scmi_clk IMX95_CLK_HSIOPCIEAUX>, > + <&hsio_blk_ctl 0>; > + clock-names = "pcie", "pcie_bus", "pcie_phy", "pcie_aux", "ref"; > assigned-clocks =<&scmi_clk IMX95_CLK_HSIOPLL_VCO>, > <&scmi_clk IMX95_CLK_HSIOPLL>, > <&scmi_clk IMX95_CLK_HSIOPCIEAUX>; > -- > 2.37.1 > -- மணிவண்ணன் சதாசிவம்